From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 60D3B44885 for ; Mon, 26 Sep 2022 14:21:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0AEC368B940; Mon, 26 Sep 2022 17:21:44 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073069.outbound.protection.outlook.com [40.92.73.69]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE41268B353 for ; Mon, 26 Sep 2022 17:21:37 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iiQ6XIwW1ibpvgxKZnv8bz/DbIJM8oT+js/sEYh+/1qhNet9eUeXpX4F9bdC7Zcyz8cCL5w8aHs+eEboDDJg/wnltUP1IucdI03bN2z2EfKL1b5yNip+qOGzAeJG/KGvqEI2Ohlq9qQNnznZPyIfIn/+jjvte+HrmAMPe8lrJeyi5lt1qq5YYfLkgdBegGfjCQ3j42z/gghqB4zP6Ilxk/YH8487wkQqKk7AhazH9L31WBvsA4OLUbfl7OTRW76FNiKSb9nxyo2l1fEwawro0yioOm1+C7zbJVIrv4/8lVUmDDR8kKussSt7hY7a0lY5pWSsDXeczr4DjcBOqxBqiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tvj29i4Q91mbKU3Wg4ApjWPgOGBZsxd+TLPuFOy/UR4=; b=Guw4YTlLACcvhww9MxPicz4sOGvqKAfBvTOS3cqCSjY3imae1ii1Cnj1aUnt7xF53cRuvCiW+8NpdTXdqyBO4wNwD8Z2M+9wY4eAGKls44XrwGtYn3j0mUvg7cOf+xJuW3N3eQoRJI1YbS49H0HxyPExcO0xlMlT2EihR5giXBJFTBcbhCztL6wdBlwCCVoKEIx7/H8TBhDx09onThFoqMkLx0P75yAiBIzVk39KxsUIcQt9Yx9XYNgt8aYqSV51ETAINQEVq8j0Uk9zbVdCvvx9zBeMX3mocrVlMYd2lwDAwOl8owwcWQzmTGTL1QtA4WRAulWvi+7dJMweKGB2cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tvj29i4Q91mbKU3Wg4ApjWPgOGBZsxd+TLPuFOy/UR4=; b=sFlc4C9+tAJJPD0zBx4XpRYwfhI539rRasbcwYiURppcz2ISpkQaadsY8fAoyYs00dbselnU94Sbe5wmku3M3lUin1so3xn8moOZ19AZk+SehkwL8oQ749ohsB/zAomrm29Fs1Y0gPSQaCShrLT4vd7dD0kwGblbYdwaQ3Ab/J21kkvJ4Y1QnPGuyQS8Xkq8UAra3wHT+PliKGRJZecRGxxwx870DmNJanMpVCNymMzRS6n6EtUW6pV44KR5vspWgo6hrvNeQXTYoIO2i4k/oprwh9YEBAGN58EpKcFWRJglTRhY1RZJzqlnAlflipG1dvFyTmq2Kxy+Z7RxlmxzCg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0423.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:288::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 14:21:35 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18%4]) with mapi id 15.20.5654.016; Mon, 26 Sep 2022 14:21:35 +0000 Message-ID: Date: Mon, 26 Sep 2022 16:21:39 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <165778644704.15564.15015584182496894872@lain.khirnov.net> <165804661780.15564.263905578360823358@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: X-TMN: [6oRQkEFiYRkZJAmASuCuoYYb5E62yhbtLHKlAGCkUKU=] X-ClientProxiedBy: ZR0P278CA0097.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <51478765-119f-c0a3-840b-6d4f93222240@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0423:EE_ X-MS-Office365-Filtering-Correlation-Id: 2281f77a-d30e-409e-e9bf-08da9fca6ae2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: it69DMvbG8pbYDHgeZ2VbrN1ld7MLaYrNlbRo5bML8FTOIV5BZ0Aykx/P2Yof+l1rdqvV/PqdmHhWWFf7hXIAsypCec9fDKTSfSSh8NfCZMCawTvbbfRUPkzktu2ABbSv9dPOia5mWZkKOExCX0Q6+X5fTfIJtaPIIRa543lKszv3arR7Stmww0rjxawAdQkJ3R7bqiG8TSaMlSK+PK8KtGDW33IumAnzExelHI2iypNi+5dimg/xmsjaCFOnxRfm3yt8GPQSQ6JMjOLpbWewd7LW7wMYVfEDeHm+l7x+2o4AQqpfO1OUtIubgR5gU6/w2qJuUDbkyV5QmqZH8YRg7yLsmMhYVjuOCBpcMXAYVLqJX+0ev2qixEpN5pHaR+r2tB0pTkmu4eAWUOIXzgXW0dMsi+APCfJTTCShwN/7imHjIAW3Ckba1BXWLRiRVXgt2FCGGtGctxSGBs0vw6Ev+i6emUE+kP6SIAIPKF1HDw9U3gBJ3Z8QBwGQv87bCKfGI0NDR8bRMx1ycE6LVfiVEWfvDk+RxslmqA9tNaqQdYkgdc0IYc3DlvBkoXjNY9KAQ6bES6SKrPN5gHIeRtJL99BPv83rXyZp2jLSaBQnS07j9G7xAE7vpkZaTcxcTPp0Wy5ASUdl2N/k4CIq4LDGbtxI2uz4wVIo474awiGLhbkcKHkwvTnq+xo+SxGwcwG X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0dXZzRYMENERFZuQ0VPdGNKaHRMU1RxaStDdEZoRXI2OHllZVh1KzFlVDhZ?= =?utf-8?B?bk1vZk9lOVpSWHpNWGhwaXNtOEpSdnJFNS8rT2ZBNHpqa0t6UTlpUkxGemdp?= =?utf-8?B?RlgwdjBFczRUZkk3dlVRZGJOTVB5bU5XTFVwSUovdUxxYnVKUG9IeUh6Ukoz?= =?utf-8?B?NW0zOFFvOTVVS2wyV1BiRFU0U1RPZHdWd2NzVms2RlMyaFRmUTdxK0l3WWp6?= =?utf-8?B?V3J2bDBDU202UGNiL3J0bmc4NUIvS0NydCsrdVdCZGhTdEYrQ3R2YlNsTG1B?= =?utf-8?B?UXJFQUVNZnF1OExWM0J5RVp5OVllLzFwUzU3NnJYWDBKRHNtOTB5YUdLRXpC?= =?utf-8?B?MHJIV2Y3Wk0rZ2MyN3FxdEVHWnd2dGJLanV6OUtuQ2tUVTJ6SUxqQVZDVDdt?= =?utf-8?B?RmxDaGJKbFZ4d3NHSmJJU0NnVkFJQ3FOQ055Y0ZNR2MxY3RQQjBCNzI3N3pO?= =?utf-8?B?RlFKTmI1dkdRbTl6MUNORmNpSHRFS3VqQjN2dVpPRlMzK01ORDAxMnhyZGxr?= =?utf-8?B?UXg0Q3NRVCtMWXIybzh1N29pZmVLbFQwdy9tSUluVldORGtVaml6dG8za1Uw?= =?utf-8?B?T0l5ei82dGFwejlnRnBEeGF0UTh6WkY2bjIrWk9RRExhMmtJTnBXN2dqRzBL?= =?utf-8?B?Qlg2LzBuUW9ZUStFYTlBNVhsSUhSRXUvMVhQZmkwbjFBWWxDZm5mQlBzMTA5?= =?utf-8?B?UXpUbk9HdVlwdkxRZXZNWkVzcE1aeGpqTU5SYkpLYzhFVjNwUWNvUnVwN0Vr?= =?utf-8?B?WEhxYmNYM28xZXRMVTFReTNNK01abW80S2xYTE9MTUtnQ0FSTlV6YmdKV2ky?= =?utf-8?B?Y3hMamxLZFFLR0p3THFCbktSaDNHL3UrcFdyQ1FHcE01R1RZNHVFUmJRbURP?= =?utf-8?B?MXJGU2QrRnpqblRwYnJySTZ5cHhtTnk4aHdYUXhCRzZYNFZOcFpnTmlSU2Nn?= =?utf-8?B?NmIvb2RUdmFUVENyMHdHWmw5ZmtCKzFWSFNJNWJhbHFLUVBES01heHd1TFlK?= =?utf-8?B?QnZoQktFM21kQVIxSStSQ2o4UWpGY3Y1aFMvcWwvK1EvdUFNREM5S2lkNzZ2?= =?utf-8?B?NHlJUXd5RWd4aW5IRS9WaVFpOW5ITnkwR3lsYjNmUC85UXdSbjkzTHJCMjhl?= =?utf-8?B?eUNCeHhDRFRXeTgwcG9IMmdUQ3VvcmRKZzFlc3MzUG1XRGRQQ1ZhRXN2ZjFx?= =?utf-8?B?SHh6Z2dxazVDRnE5WXpaNzR4QXNTYTA4V2ljTXQ0UndJK0c3V0I3bndzT3VB?= =?utf-8?B?V2FnZklRVGNIWWVBV0E5WUVSY1dJZHduVFkycmNBQ0gzZkQrSWNxRWRWdEZK?= =?utf-8?B?VDZseXYwbGFtdnoxdVNGcWZEcFY0WSs1N3RIeGtrMWZ4dUhKanAzdjd3M0d4?= =?utf-8?B?UG9BZk9EN2RWQURlV2RQVUpWampZS1ZGcDBPODU1Q2orSkdocW54Q25LdE56?= =?utf-8?B?WVZwZnVteDBwM3FxWFpXc0NGWmhycnlZKzl5T1YvaXJ1b2ZJaVNUcEVoSzhI?= =?utf-8?B?OWJGTWh4TFBkVlZ4bmIvcFVBQ040bVBQV0FvUnBXd2N4M0gxT2ZTUlJjYms4?= =?utf-8?B?RVZ3NXIwdEIvQ3RzZGJTNFBDalg1ZFcwbGw2Q3JnMTEvdzlETXM4UWlMT1hh?= =?utf-8?B?V2xlVkhjclV1YTBvUHFQaUVpZUNIRnpSYzZBVzI4NE16UW1aN1pzaUhvcUZk?= =?utf-8?B?eDFGSGlNSkt2U0NRUlFzV2VSRDlCNDRVQ3UvajZCV0pTMnBndTBESkNRQ1ZH?= =?utf-8?Q?2AeyghzFfRwEGtrIfcYHJJ1cKnQR6sgW+siz8F+?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2281f77a-d30e-409e-e9bf-08da9fca6ae2 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 14:21:35.3385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0423 Subject: Re: [FFmpeg-devel] [PATCH 3/8] avutil/mem: Add av_fast_realloc_array() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Anton Khirnov: >> Quoting Andreas Rheinhardt (2022-07-14 14:51:07) >>> Anton Khirnov: >>>> Quoting Andreas Rheinhardt (2022-07-12 16:12:16) >>>>> Anton really dislikes the av_fast_* naming and instead wants this to be >>>>> called av_realloc_array_reuse(). I don't care either way. Any more >>>>> opinions on this (or on the patch itself)? >>>> >>>> If people dislike _reuse(), I am open to other reasonable suggestions. >>>> This 'fast' naming sucks because >>>> - it tells you nothing about how this function is "fast" >>>> - it is added at the beginning rather than the end, which is >>>> against standard namespacing conventions >>>> >>> >>> Isn't reusing the basic modus operandi for a reallocation function? So >>> your suggested name doesn't seem to fit either. >> >> Ordinary realloc just keeps the data, I wouldn't call that "reuse" since >> it will often be a copy. This "fast" realloc OTOH reuses the actual >> buffer, same as all the other "fast" mem.h functions. >> >> But feel free to suggest another naming pattern if you can think of one. >> > > I see two differences between this function and ordinary realloc: It > never shrinks the buffer and it overallocates. These two properties make > it more likely that these functions can avoid copies more often than > plain realloc (but in contrast to realloc, we can not grow the buffer in > case there is free space after it), but it is nevertheless the same as > realloc. > > But I don't really care that much about the name and will therefore use > your name as I can't come up with anything better. > (Of course, I am still open to alternative suggestions.) > Here is a rebased branch that uses av_realloc_array_reuse: https://github.com/mkver/FFmpeg/commits/fast_realloc - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".