Re: [FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideo: Ignore skip_idct for encoders

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideo: Ignore skip_idct for encoders
Date: Wed, 19 Oct 2022 14:12:32 +0200
Message-ID: <AS8P250MB07445CAD6ADFC1E1B1D5A0AE8F2B9@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737DB7E1DA91101E51ECD208F299@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> It is documented to be unused for encoders.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/mpegvideo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> index 5095149eaa..448b65bb96 100644
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegvideo.c
> @@ -1413,7 +1413,6 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
>                          ff_mpv_motion(s, dest_y, dest_cb, dest_cr, 1, s->next_picture.f->data, op_pix, op_qpix);
>                      }
>                  }
> -            }
>  
>              /* skip dequant / idct if we are really late ;) */
>              if(s->avctx->skip_idct){
> @@ -1422,6 +1421,7 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64],
>                     || s->avctx->skip_idct >= AVDISCARD_ALL)
>                      goto skip_idct;
>              }
> +            }
>  
>              /* add dct residue */
>              if (IS_ENCODER(s) || !(IS_MPEG12(s) || s->msmpeg4_version

Will apply this patchset tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".