From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 6/7] avcodec/vc2enc: Move transient PutBitContext from ctx to stack
Date: Tue, 28 May 2024 04:49:11 +0200
Message-ID: <AS8P250MB07445C5A751D0AC30755E7968FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB07442EF03FD5DC8CB1FA9E1B8FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/vc2enc.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index 8b9641916a..e72c15e6f2 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -105,9 +105,11 @@ typedef struct Plane {
} Plane;
typedef struct SliceArgs {
- PutBitContext pb;
- int cache[DIRAC_MAX_QUANT_INDEX];
const struct VC2EncContext *ctx;
+ union {
+ int cache[DIRAC_MAX_QUANT_INDEX];
+ uint8_t *buf;
+ };
int x;
int y;
int quant_idx;
@@ -724,9 +726,9 @@ static int calc_slice_sizes(VC2EncContext *s)
/* VC-2 13.5.3 - hq_slice */
static int encode_hq_slice(AVCodecContext *avctx, void *arg)
{
- SliceArgs *slice_dat = arg;
+ const SliceArgs *slice_dat = arg;
const VC2EncContext *s = slice_dat->ctx;
- PutBitContext *pb = &slice_dat->pb;
+ PutBitContext pb0, *const pb = &pb0;
const int slice_x = slice_dat->x;
const int slice_y = slice_dat->y;
const int quant_idx = slice_dat->quant_idx;
@@ -735,8 +737,9 @@ static int encode_hq_slice(AVCodecContext *avctx, void *arg)
int p, level, orientation;
/* The reference decoder ignores it, and its typical length is 0 */
- memset(put_bits_ptr(pb), 0, s->prefix_bytes);
- skip_put_bytes(pb, s->prefix_bytes);
+ memset(slice_dat->buf, 0, s->prefix_bytes);
+
+ init_put_bits(pb, slice_dat->buf + s->prefix_bytes, slice_dat->bytes - s->prefix_bytes);
put_bits(pb, 8, quant_idx);
@@ -789,7 +792,7 @@ static int encode_slices(VC2EncContext *s)
for (slice_y = 0; slice_y < s->num_y; slice_y++) {
for (slice_x = 0; slice_x < s->num_x; slice_x++) {
SliceArgs *args = &enc_args[s->num_x*slice_y + slice_x];
- init_put_bits(&args->pb, buf + skip, args->bytes);
+ args->buf = buf + skip;
skip += args->bytes;
}
}
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-28 2:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 2:47 [FFmpeg-devel] [PATCH 1/7] avcodec/vc2enc: Avoid void* where possible Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 2/7] avcodec/vc2enc: Constify slices->main context pointers Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 3/7] avcodec/vc2enc: Remove superfluous error message Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 4/7] avcodec/vc2enc: Fix slice length Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 5/7] avcodec/vc2enc: Avoid relocations for short strings Andreas Rheinhardt
2024-05-28 3:07 ` James Almer
2024-05-28 6:38 ` Rémi Denis-Courmont
2024-05-28 14:25 ` Lynne via ffmpeg-devel
2024-05-28 2:49 ` Andreas Rheinhardt [this message]
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 7/7] avcodec/vc2enc: Use already available AVPixFmtDescriptor Andreas Rheinhardt
2024-05-30 18:53 ` [FFmpeg-devel] [PATCH 1/7] avcodec/vc2enc: Avoid void* where possible Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07445C5A751D0AC30755E7968FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git