From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B34354421B for ; Fri, 2 Sep 2022 20:16:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 377B068B99B; Fri, 2 Sep 2022 23:16:51 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074101.outbound.protection.outlook.com [40.92.74.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2657868B757 for ; Fri, 2 Sep 2022 23:16:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IKqk3SD+0+FMaMP0ypkHS7H3Kp+yG+Tb3GlO9vUOlAx1aO0CnoDe3ZAj2DLh4M023JCVlWJokfEBk9O+JIJmuPzFkMD5oPyn4m3LaILpy+FwyJFjBUNMslMbmzlFkamodoD1FRpFiAdBoUQBQeEMQQngAbKtLuzbvLbAF9OLWKuclaBI9cpRhkBteJRCPszVC4Tbu6UDpmp5gsc5PsElezbBb/nz6guwKv6i/ZfOOvcR1M7K3/09Ijrfv6UNAHs3KGVRiR0GHEwG2gNXAJl8XVymjGw4eCjZfT36jHBuIyjZkFvK4qz6YcH9epxcqNW5raw/iNPNvyBRsea0S5I2/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T44aCLdYKFSlWZgmbYxIWJ24fa0MVS6r9cLQHeFZU9M=; b=YAU1rm8A3zqedaB6yWI7lHL7g8MFh+xNF3wgjxkHH7PLBv+Hd3RM5oY8gxUxFBrT+bmyH1TN2/MwY7gRSKbD1drMVYIzv/c3zwlIPkFzYAz5rIi1aazrjC261ibAz7g1F/7FYIF7V2NZz2+0TTG/E+8FT9jM+BO1D5l0ogW8dIndIDYcuVNzF8iWo6o0RowkRPVMQB/v6raorS7sMXSa0Kd8/yJVor2aQk/eyc0STBq7FCdK8gczcESUEVmXASDA4FbXFF0ibG4gQzcgNHXXhj/KUJ5js1s91RBNal3YJLQFh5vnFJ5KdlwWa/teu4z27tKU2epNtVzto/MTj14nww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T44aCLdYKFSlWZgmbYxIWJ24fa0MVS6r9cLQHeFZU9M=; b=SrPyomufDqqDXaLx+9zy/niMP3/85jHIBmfYgnOUrs/FLnUt4jWwtDZn6bMfCVOUecO+ULnHESWA6lL37W05G3as2OdxMHGhL7Q14eQfPhW0C6l2Z4AMy8fAFv/Cd7XybMI69eybg6DC/cC79SLQMB8yWORA1hhoY7nZ8HePrWjzzsgLRFLj4rwDIwY1NuSluRB3iCrfmFQ6P4seyB8yzzgN+D+N+HbDyGLWv3jjCtVOXiJZmrREvSXSFenQN+1lbllJ9zS+khKruj8Oce0mca6H0+oqwXj8zLqcQ64NR2a8XEib691roV1jsQGYnselptvPuDcwz6qW3IDaVYiBjQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU0P250MB0867.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3ea::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 20:16:42 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47%2]) with mapi id 15.20.5588.010; Fri, 2 Sep 2022 20:16:42 +0000 Message-ID: Date: Fri, 2 Sep 2022 22:16:42 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [rU5CU0sm/Ua/D83RQNHEjEPDYEveE+tzjzftjukGRTo=] X-ClientProxiedBy: ZR2P278CA0004.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <5f297e38-27b2-39ca-059d-2de98bdea938@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc84826e-5a35-4d09-f1dd-08da8d200cbe X-MS-TrafficTypeDiagnostic: DU0P250MB0867:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: afqt2vBQkTLj9P63LM0lqv8iSqq7JvvwCod3DY3fXFD+FRFn1DUl+Hzt7ZAf4qof7BjVO5KilfXXxGeqzrb/MGE2F9A3Imb+QbgQ2oL5s+kSfBDGMc11bJ3WcUaWwURqpoPqLt9cCvofPW38W9Rh+nhrPIembC3qq6EBHoz+92IDmsqKzL+IjQR+nagEUM4Bbi8V9PZamLf45Q1GjVTAfhqtPqVZh4wXKPYGCGkJ3b0MWw9CUy43KGok7O7DRYtqxS9bq8NOrh+lNWmN72P/nqsh6td4Nw5UJJbwsKtCUBysEPGWCMjigsP+Jl49C491z6WT2G1zVBkM9DJ44qxyX+rWQdU5BKkhVbSXPcdmOBTRXa2I8Nci+Roiq8/Lkr0+RT53CWVtJxyEAcR0iWkmsHN0FqzohxTQUilHt5iQdlhEVg3yAmCKDRbbsgiiGaHcTDWF8lMB/ecV6td5SpD/5HTCXZiMgXM8IWiFPo1i8J75iAlgbukgCcoHdQdbQ2Imuj0Ava4jMh4nnOtZCST5fhPjROFFm6+rSPM7JL8FymX6P1oFC2L2kOKTfDPKE+NPYbUYsuQiopYEw4y/8l/ils40r9Uen15WW1gDITGH/Gi01v/xEvpbUtB1/miB24ds0KKIScVsZMCzPpC+fXuqnUkJR0B/Uzmrm19OeareJcA5q7lLxlx1+LYQJLpq3fsv X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHBteTM4cEpMU3dKSFpHV0JZeURwcU1icnozbWUzUnl0ekxaZ00zcXJnVGVI?= =?utf-8?B?czlsS0twZUR6RDM5NkJQbExWRld1Tnl3dTg2L0g2SmxyS3pEV0NabmdJejdK?= =?utf-8?B?WFdXZkM1V3ZKOExndUU1N2IvWGNhaE1COGsvRzlTdFBibkRmYU50U09uQmt4?= =?utf-8?B?U2o3UGZWNmhKU1NhMlhQVjEyUlUwdHNIRm1zb3NpdmFzT0xSM21ERkg5bTN3?= =?utf-8?B?NFpBYk4xQWdVTXIrVjRyTW1tVUdYWDBzSkp5Q3kvNUZ5amd4bXg0OG0yS1hT?= =?utf-8?B?RzVSYzFSaERNOUM3bXc5ZDBneDl6OUZnZjFLQitvcTQ2cEM1UmJ5d0VwUXRM?= =?utf-8?B?QUxBKzZabmd1YXRLcndVelozN01RZnkxRlBxcW5VMTFXWXdhTjZEVTZUd1M0?= =?utf-8?B?MGNtRGlOd2dISTRjN1dTYW1WM2xtc3kyTy9hTFlwcjByRVQvSVExTDh5OXlw?= =?utf-8?B?d1dBdGlZbSs4RlVMa0o5WGI0TnMzNldmZWdHSE56b0VERFBQOXl4bCtKWmt4?= =?utf-8?B?MW01d3I2b0dsayt4a0huTlBjbXNKMVVBeWZLT1JXdDVjUEVKOTNmSTR0Rkov?= =?utf-8?B?eGliZFpzcDlIVmhJTFVJNCtxWmp3RWhzNVZpcFh5b2RGTEh1aVBFUUxCN29N?= =?utf-8?B?QTk5T0w0OG5PY2h3QmpDem1pa1VKZmRYRzNUU2lac3BpQXBlUlozaEpVb0hr?= =?utf-8?B?YnpjRkhYbW03UVI1NEtORXJNN2lpRkEwN0xlVWFjMHNCOFpyS1Q2T2swZmNU?= =?utf-8?B?SlhxZXhmeGpZR0p2REorTVZVc3dtalNRMytXRS9kcnlRRTFtQXlGUTVsZzdn?= =?utf-8?B?cGJ5V3dyTnk3UUk1ZUQ2SnlveStMUm9zLytCL1Z6TUdjSWIxODJ2VFdjN24w?= =?utf-8?B?VXRUci9sckN4bEtPclJRNStlbVZGOTZhLzFpbzVNRjJLVUh6WU9kL2ZuU1lZ?= =?utf-8?B?THhwZWtzYnVTWGpUNS9JS1NnczZpNGtlajVyelNrUUFPMnlEL1FwRmlWVTV6?= =?utf-8?B?bm43WlE3b3dYNGZBelRYdk52MHI0eDBhSXkyZ2d4Q29CV3NjdWNLZmg2VmlP?= =?utf-8?B?OHk3TDlnZW14OCsrQ0NnS1RtWWEvNG5FOHY0QjZNaDVYUjhZNmlKSDJZelh5?= =?utf-8?B?ZGs0Z3I0bXVlL1ZuRktnNmlaUnJjZVFyREw5LzlORVl6aTB0dUZqT2toU1hG?= =?utf-8?B?VzN2b0ptQ0w5WjA1Rm1xUkc1NUlQYkF6SkxWcVRTeVArdXVMb2hQc3EzYWFP?= =?utf-8?B?WTVOejhOWHp1UmZQMENKVVV4Sm1DQklibWIvQ0VEaUxsQ25Cb2JNYjNQOGVl?= =?utf-8?B?V3hLcmVzZmxXejNLN2JOdXlXS1pEL2I0ODJtWFE1ZjBueVVXK1hRNjltZTE2?= =?utf-8?B?SzRNMjBodkEyTFZnRFA5SVg0RG9jYy9XaitwZDU0VGJ6UU11SlVZejhzelFi?= =?utf-8?B?L1JRWlVHcEZFTk41cDlaQ1hWL0pMd2NDSkU4RldUOVduRmV6NlFGU3BjZlpu?= =?utf-8?B?Ykozb2Q0NEkraXNVdGMycWZNZjlmV1U5T0pFNHlZdHJKZngzRFlKeVlFQk16?= =?utf-8?B?bWtrWWtVZm1PL2hLR2JRZmNoWmhYQ0F3TmVsVTZPdGdyMThmRDYrZnZaYWpu?= =?utf-8?B?NVgxanNkN3UwWVNnMW1wSzR1NUFkdEZrRXMvSzc0T3lBUWJpSUVsTkw2V3Jh?= =?utf-8?B?Mm53RWYzUlBxWUd0Mnh4RkdpVXd4MmZVaGxIUGEwdndpeWpyTzB6SFFJMGwy?= =?utf-8?Q?GpIjQqinFh4dsxcH6RvLCYMTYGCnBGEs4ulyMnt?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc84826e-5a35-4d09-f1dd-08da8d200cbe X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 20:16:42.2093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P250MB0867 Subject: Re: [FFmpeg-devel] [PATCH 10/11] avcodec/encode: Avoid unreferencing blank AVFrames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > ff_thread_video_encode_frame() already returns blank frames. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/encode.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index 2c02b24cf2..8c6d81286c 100644 > --- a/libavcodec/encode.c > +++ b/libavcodec/encode.c > @@ -263,18 +263,17 @@ static int encode_simple_internal(AVCodecContext *avctx, AVPacket *avpkt) > av_assert0(codec->cb_type == FF_CODEC_CB_TYPE_ENCODE); > > if (CONFIG_FRAME_THREAD_ENCODER && avci->frame_thread_encoder) > - /* This might unref frame. */ > + /* This will unref frame. */ > ret = ff_thread_video_encode_frame(avctx, avpkt, frame, &got_packet); > else { > ret = ff_encode_encode_cb(avctx, avpkt, frame, &got_packet); > + if (frame) > + av_frame_unref(frame); > } > > if (avci->draining && !got_packet) > avci->draining_done = 1; > > - if (frame) > - av_frame_unref(frame); > - > return ret; > } > Will apply the remaining patches of this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".