Re: [FFmpeg-devel] [PATCH v2 3/3] tests: Add fate-hevc-color-reserved

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> ---
>  tests/fate/hevc.mak                | 3 +++
>  tests/ref/fate/hevc-color-reserved | 6 ++++++
>  2 files changed, 9 insertions(+)
>  create mode 100644 tests/ref/fate/hevc-color-reserved
> 
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index 390ccf46e2..8113c04300 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
>  fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
>  FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>  
> +fate-hevc-color-reserved: CMD = framecrc -bsf:v hevc_metadata=colour_primaries=0:transfer_characteristics=0:matrix_coefficients=3 -i $(TARGET_SAMPLES)/hevc-conformance/AMP_A_Samsung_4.bit -vf scale,format=nv12 -frames:v 1
> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_METADATA_BSF SCALE_FILTER) += fate-hevc-color-reserved
> +
>  FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>  FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>  
> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
> new file mode 100644
> index 0000000000..cba6397aa8
> --- /dev/null
> +++ b/tests/ref/fate/hevc-color-reserved
> @@ -0,0 +1,6 @@
> +#tb 0: 1/25
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 2560x1600
> +#sar 0: 0/1
> +0,          0,          0,        1,  6144000, 0x427b9a00

This seems to simply presume that hevc_metadata does what it is supposed
to do, but this is not really tested. If hevc_metadata were a no-op for
this, it would pass the test. Why don't you use something with a hash of
the output of hevc_metadata?

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".