Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o
Date: Sun, 17 Mar 2024 18:29:39 +0100
Message-ID: <AS8P250MB07445402D9E974B39E938F8E8F2E2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <667A4FEC-FF74-4DE3-8BE9-034CE1548083@remlab.net>

Rémi Denis-Courmont:
> 
> 
> Le 16 mars 2024 13:58:23 GMT-07:00, James Almer <jamrial@gmail.com> a écrit :
>>> Seems the conflict comes from
>>> https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287
>>>   and
>>> https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c15f1239f1f16816749a7fd3b6
>>>
>>> Perhaps you could also try asking libbluray if they could use an internal
>>> prefix. Otherwise you might need to do a rename of that function on
>>> ffmpeg's side.
>>
>> libbluray 100% needs to either prefix it, or hid it so it's not exported. It's a library, so it should not be exporting such simple and short unprefix named symbols.
> 
> AFAICT, FFmpeg is just as guilty as Libbluray there. To support static linking, all non-static symbols should be name-spaced, and here both FFmpeg and libbluray are failing, and thus both should be fixed IMO.
> 

You forgot that FFmpeg's dec_init is in fftools/the executable, whereas
libbluray's is in the library.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-17 17:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-16  1:04 Helmut K. C. Tessarek
2024-03-16 14:07 ` Gnattu OC via ffmpeg-devel
2024-03-16 14:26   ` Christopher Degawa
2024-03-16 20:58     ` James Almer
2024-03-17 17:26       ` Rémi Denis-Courmont
2024-03-17 17:29         ` Andreas Rheinhardt [this message]
2024-03-17 17:37           ` Rémi Denis-Courmont
2024-03-17 21:13             ` Timo Rothenpieler
2024-03-18  0:32               ` Rémi Denis-Courmont
2024-03-18  1:21                 ` Timo Rothenpieler
2024-03-18  2:31                   ` Rémi Denis-Courmont
2024-03-18  7:32                     ` Martin Storsjö
2024-03-18 10:52                       ` Andreas Rheinhardt
2024-03-16 21:09     ` Helmut K. C. Tessarek
2024-03-17  8:05       ` Gnattu OC via ffmpeg-devel
2024-03-17 12:10         ` Timo Rothenpieler
2024-03-17 19:45           ` Helmut K. C. Tessarek
2024-03-16 20:55   ` Helmut K. C. Tessarek
2024-03-17 21:19 ` Helmut K. C. Tessarek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB07445402D9E974B39E938F8E8F2E2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git