From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 366944A494 for ; Tue, 30 Apr 2024 21:06:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B41DA68D58C; Wed, 1 May 2024 00:06:52 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2068.outbound.protection.outlook.com [40.92.59.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1E9368D54B for ; Wed, 1 May 2024 00:06:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hGzcTvLmg7iXyvuNAzZP7SfKeTREXlyzRrFTb2MTCx00loYEa287Iu6Ycvts5JtVayDSj6vhF+N2kW+eegVXRcttLzcoCE32bNv7m0AsJyvvLSloH555kfsH6Px8Qme7xJalt2X3Wdrq6KiTX0J9cwG2lYuIDv9u/bCsat/t/B5ie5zS1JTw3TMgZgaGkn/31PQhM/kqAPnrWCkW4jNMwq6IHiAlMdPCl63bsRPLXhiTDzfiTJGVWEln5oVcCyWRRQFlHwKpbJnXJ9UrIzGwZdb4OUkUJPtSb8ez4TYyKWmQ7kqAWH9aOKRx8JNWTd+GUu2/iRwiumQJH/LKL+o/qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hgn1XSjCRmuG+nRMmi1eTu45jxbAE+XEYBWjVoddODo=; b=CrGp3iIWqIxS3XfQQuyB40OhCe87vc7U2+wL5y8Pwe9n2C4vR9CLmTCdDQGoDUy1HYsu8VlzfyLE0vMdyUJM8ZimB9pM2lqf1a2QAzQBxDWhZQNPNfK+4s8CgaXCPXQ9ocDlsqckBJyBAkPm913AeS3vnzohoTVoCr3Gi1ZaS7Fnt//TCKR2ipM+I3idWa0vMack/JzTEA0ZcuqRbKy8d20RfuKTiXdKU1ez9kxTne2zNxmGufpDKFz8Zu2MzlcZ4tw9Itxae1p54HzRXUUa0VkQ56X8WNEkkpAheKtLAFAj8wGQ8nsK0ELHwxAFd5GNWeu1vLk+qlGurUbkV1bD4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hgn1XSjCRmuG+nRMmi1eTu45jxbAE+XEYBWjVoddODo=; b=bTl4JtbXzde5CK7b3c514Ex3GJaGY3baLBVMVUq5L8R5Q6HvCIEmCOYAdbFA59hLLsZp17vEUYTHRM8EJQ4pvWXeUwIeSs5KMEIGNIo0szBQCgfLcb3rpSRMhpcNlbekyfXWlhgARTnXC0i9kE7+T+3u3FY6SGeYkxjY/6tJb520E766FpaanvR5N0KXdztq6V5sDnh2lMgsUnhfj9+u3ObtlL7b3nzjS3DSynQpkVvrocJmpegsLyq3Tkw+dn8SksKktA4kmHxoUrfLhNOmwUUJV838kS27uICCxTDTWx3uehcdP5mrAzc+7F0SF4JUAfnGXdmqvqpPhWaAUsF3nA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0148.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:275::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Tue, 30 Apr 2024 21:06:43 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Tue, 30 Apr 2024 21:06:43 +0000 Message-ID: Date: Tue, 30 Apr 2024 23:06:41 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240430204026.GS6420@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240430204026.GS6420@pb2> X-TMN: [no2/+TKqHbUlBTxi1o65D2O2zSRjBjkcXgW9bscACOI=] X-ClientProxiedBy: FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <79ed19eb-c650-45c6-8283-abe134c1a431@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0148:EE_ X-MS-Office365-Filtering-Correlation-Id: 4747cc06-d953-42ce-9efc-08dc69597009 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: 6mD+kNbmPmjrjf1FQ3C2cdl4N2YTLb4wbv+tUmDkNJVNA483QeMg/eM++wDx/aGGuwtRYKiylwqTj91XUVCs3vFJtdP5kig6cBnRK6q7G1YlHBNM47UQVY+o77lmvnSnJpFkH4D78+lGRrFbbbMdcsWGub8SOOOBi+4tF34voLmdNcI7MRzLQwgd7Y+Ml1HDFCB2qAAdHtiK7yR7wqsj5tEjXnBbio3hPI5UfjxE7Wfe8MO7Og0oy8DV193lnkPc7slrWu9MhnPPHVo3+K4GNGVNfMtzIpeAy9DL2sQysf6BumvoKWMKdZx7AwoEb4nzMv3Z8QF3T8wohIeh4iw2iGWQ1AF7wL7nuNP3EORVnOi5YVPRKArU2nGmbizjbECEMAUvNvFfH2rYp6f7Dyn+MojMvGL9nIyNBRt4tvQUlCqMS9nonGZDg9ZiPBoRXMHZKAzBA4O4B994yDLW+OqPXW7Ffke7rCB23jEEWiSy9qFYXkpSVktyp4IZZWYiMHShshNITWVmb6xs7APBIuUttc5QvpSteVVeFjOkdtaJpSwbu9CnT08KR5AY/y0OqK0t X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUlEVXY2L1hMY01kQTVLOVN5MU4xRU5hSmovN0hteFZxOEhuWTZZSW9lTmZT?= =?utf-8?B?VTBzQ0Y4MFg1RkZVVEcyZkQ2a3BkVXRLOG04Rmd5c0FzTVhrZXVRSUMwR3F1?= =?utf-8?B?c2llck1BVTJpSjlzOVVjV3NtY090bUZjWXp1NFhuUUZCZmVFU1J6SGtWd1ZM?= =?utf-8?B?Q0Q5TmFOSlNlaktXY2ZQaUczTFdQT1M1QTdYemxsOEJDWWpUa3g4eXNEUDZn?= =?utf-8?B?V0JwTlM1aVJ0WXI1NTNjcXhueHU4SFVyUGlIMjNSdmt1Z0VCbnBFQXlyY0ls?= =?utf-8?B?bCttZEZmYVZqVEJjTEdCUE41S1dMQ2o0c0x5N2tKRlZMN2k2Nmo1c0ZTbDZ3?= =?utf-8?B?QUJxNE9TQmdYQXIza242aHYyY1lNbFhwNENENUJIeDVadnZ3U3NiMmQ4cXRV?= =?utf-8?B?Ti9lZVNxNGNEeDFwQXBhSmlaMkFCbW9VdnltOGV2Z01LcGVNM0pUUVExU0Qy?= =?utf-8?B?T3hYeG40amZtejdoSzAvWmVPV1VFMWMrK25RbUpvM2dvd0NRVHRtOUpBTHRD?= =?utf-8?B?c2ZIZnpacFdFR2JvcFlQNE50em52NEg4TDRlMm9pZVJTSitPUVJXb1pyTW5a?= =?utf-8?B?bFNlKzZncE1wMDR1eFZkYkFPQmxXdjFrampZZWN2SjVEVEFINng3SzZPaElE?= =?utf-8?B?cDBNSGNETVBOL0k0UUtiblQwRDlsNi9TNDRwV1hlbTJ4L2J1cVAwb0cyUWpj?= =?utf-8?B?czdOTmxRSWxxVGpXdDRySjUwZGU0akZwUnFQaEVmZzNrM1Nzc0tQOEdTQk1T?= =?utf-8?B?dHl5aWt4V3hqQ3AzUEoyVERsRkNCUXozUHFRZHF3MWNtdi8vU2Y1UzVMRHIy?= =?utf-8?B?WmRuamVpV1JwQktrczArMFMzTFB5V21WQlJvVmtrZUN1RCsrZDVoMEhTSi9r?= =?utf-8?B?Z0lKamRkSHIrOGJiQSthTWNVQVo3Qm0yMUhMdDg3Rkt3R3pFZkhHYTRnMzk3?= =?utf-8?B?a2RxUGw0dmg2Y0ZBTkdYUzZmZDJqMDFjRS9Sa0gyWVF6U2s4M280TDkySEV3?= =?utf-8?B?ZWpYUGxCdmxxOWR4MENIMklmelRIUmxlK2lKZStlMDV1b3lPM3hSYjlGS08x?= =?utf-8?B?S0FaQ0s5emVNdGtoNjVnVEtLdFpCNHlkUEd5RGpUQ2UveUs1TzVqcnY4MytK?= =?utf-8?B?cnpxQ3ZDeUpPRFpkbGFVVDAwVlpITEFZaHF3M01wSXpKZm80a2U0dTF2T1M1?= =?utf-8?B?M05JUUFZNlJ3MnlIUHU1NDA1VmN6cm5KaUQ5MUdyMFZQVkVKdHdsZTJNT05x?= =?utf-8?B?cTR3NEtOZ0p6eVI0Z1l0MkM1UXp6NnA2YkdnT0hhbWM2MG1xT1J3RHFnR0ZR?= =?utf-8?B?czNPeTIrb2VrdXplN2k2Z3MvUHowZkJJOGRkU29PdU5xSTBmeUp6M0ExRlJw?= =?utf-8?B?N01hQW9Id1hTc0x4b0lGamk4aXFLUDF5cVJYZG1hd0dnbC9UYmk0Y0lRNG9w?= =?utf-8?B?eDZOVGc2YW5vRmZKR3laNmtKZlZDS0QwMUxObjdKNDFEbnZreHJYZEJOdGhz?= =?utf-8?B?a01WeThrWHBXTmhNVjVDTGloNmdtaTM1aUJDU3lZZzJ4YVhST0dYYlhIYXNE?= =?utf-8?B?ejZLSHhIUjl1RVRrbmxtMkFzOWhzWDRuUXAxdWhjaGE5SG0rNEMrOXkza3px?= =?utf-8?B?bnRXYmxlUkpvajdwZ2FheHhnTTRpd0txTXJqRjBVekZma1VxemxaNFR6Q2Jp?= =?utf-8?B?VmtmTWttaHBOUHl2N01XemFwRWxCQkZFZmlkcWdtdzRpeTVyV3U0Y1ZRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4747cc06-d953-42ce-9efc-08dc69597009 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 21:06:43.4470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0148 Subject: Re: [FFmpeg-devel] [PATCH 17/57] avcodec/mpegvideo, mpegpicture: Add buffer pool X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Mon, Apr 29, 2024 at 11:13:58PM +0200, Andreas Rheinhardt wrote: >> This avoids constant allocations+frees and will also allow >> to simply switch to the RefStruct API, thereby avoiding >> the overhead of the AVBuffer API. >> It also simplifies the code, because it removes the "needs_realloc" >> field: It was added in 435c0b87d28b48dc2e0360adc404a0e2d66d16a0, >> before the introduction of the AVBuffer API: given that these buffers >> may be used by different threads, they were not freed immediately >> and instead were marked as being freed later by setting needs_realloc. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mpegpicture.c | 155 ++++++++----------------------------- >> libavcodec/mpegpicture.h | 27 ++++--- >> libavcodec/mpegvideo.c | 37 +++++++++ >> libavcodec/mpegvideo.h | 2 + >> libavcodec/mpegvideo_dec.c | 35 ++++----- >> libavcodec/mpegvideo_enc.c | 13 ++-- >> 6 files changed, 112 insertions(+), 157 deletions(-) > > This seems to change the output of: > > ./ffmpeg -y -bitexact -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -ps 50 -bf 1 -bitexact -an -qscale 5 -ss 40 -error_rate 4 -threads 1 /tmp/out4.avi && ./ffmpeg -y -bitexact -v -1 -loglevel 0 -i /tmp/out4.avi -bitexact -vsync drop -f framecrc - > > --- A 2024-04-30 22:01:12.964146819 +0200 > +++ B 2024-04-30 22:00:57.407969834 +0200 > @@ -38,7 +38,7 @@ > 0, 32, 32, 1, 115200, 0x74c44bae > 0, 33, 33, 1, 115200, 0x921c5255 > 0, 34, 34, 1, 115200, 0x9a8553a9 > -0, 35, 35, 1, 115200, 0x817b6334 > +0, 35, 35, 1, 115200, 0x310061fd > 0, 36, 36, 1, 115200, 0x4c9a5f6d > 0, 37, 37, 1, 115200, 0x5ee86279 > 0, 38, 38, 1, 115200, 0x04055061 > @@ -74,7 +74,7 @@ > 0, 68, 68, 1, 115200, 0x49dcbf4e > 0, 69, 69, 1, 115200, 0x1ea1c7d1 > 0, 70, 70, 1, 115200, 0xdf77c67b > -0, 71, 71, 1, 115200, 0x33d9d206 > +0, 71, 71, 1, 115200, 0x7f6bd16d > 0, 72, 72, 1, 115200, 0x5e37cb3a > 0, 73, 73, 1, 115200, 0x15abcda3 > 0, 74, 74, 1, 115200, 0xbf4dcbd4 > @@ -86,7 +86,7 @@ > 0, 80, 80, 1, 115200, 0x17d1d667 > 0, 81, 81, 1, 115200, 0x0c1fdf9c > 0, 82, 82, 1, 115200, 0x7eabde6b > -0, 83, 83, 1, 115200, 0x3bf6e873 > +0, 83, 83, 1, 115200, 0xe623e7af > 0, 84, 84, 1, 115200, 0xf480dc82 > 0, 85, 85, 1, 115200, 0x5fd6e098 > 0, 86, 86, 1, 115200, 0xf520de95 > @@ -98,7 +98,7 @@ > 0, 92, 92, 1, 115200, 0x34cfe1c2 > 0, 93, 93, 1, 115200, 0x1d94e1c3 > 0, 94, 94, 1, 115200, 0x6d32e147 > -0, 95, 95, 1, 115200, 0x09fbefd0 > +0, 95, 95, 1, 115200, 0x7e40ee91 > 0, 96, 96, 1, 115200, 0xa5f5eb43 > 0, 97, 97, 1, 115200, 0x39b9ec3d > 0, 98, 98, 1, 115200, 0x3256ec18 > The decoder uses mbskip table values that were not properly set/cleaned before. The issue is fixed if this buffer is reset every time. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".