Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rv34_parser: Merge RV30 and RV40 parsers

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/rv34_parser: Merge RV30 and RV40 parsers
Date: Mon, 4 Sep 2023 15:56:48 +0200
Message-ID: <AS8P250MB07444DEF952FA6444DF860128FE9A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <178b0ca4-5b08-6703-685a-9d53d5237637@gmail.com>

James Almer:
> On 9/4/2023 10:44 AM, Andreas Rheinhardt wrote:
>> They do mostly the same.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>>   libavcodec/Makefile      |  3 +--
>>   libavcodec/parsers.c     |  3 +--
>>   libavcodec/rv34_parser.c | 16 ++--------------
>>   3 files changed, 4 insertions(+), 18 deletions(-)
>>
>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
>> index 08fd151619..bf3b0a93f9 100644
>> --- a/libavcodec/Makefile
>> +++ b/libavcodec/Makefile
>> @@ -1203,8 +1203,7 @@ OBJS-$(CONFIG_OPUS_PARSER)             +=
>> opus_parser.o opus_parse.o \
>>   OBJS-$(CONFIG_PNG_PARSER)              += png_parser.o
>>   OBJS-$(CONFIG_PNM_PARSER)              += pnm_parser.o pnm.o
>>   OBJS-$(CONFIG_QOI_PARSER)              += qoi_parser.o
>> -OBJS-$(CONFIG_RV30_PARSER)             += rv34_parser.o
>> -OBJS-$(CONFIG_RV40_PARSER)             += rv34_parser.o
>> +OBJS-$(CONFIG_RV34_PARSER)             += rv34_parser.o
>>   OBJS-$(CONFIG_SBC_PARSER)              += sbc_parser.o
>>   OBJS-$(CONFIG_SIPR_PARSER)             += sipr_parser.o
>>   OBJS-$(CONFIG_TAK_PARSER)              += tak_parser.o tak.o
>> diff --git a/libavcodec/parsers.c b/libavcodec/parsers.c
>> index a663b9e253..5128009cd4 100644
>> --- a/libavcodec/parsers.c
>> +++ b/libavcodec/parsers.c
>> @@ -66,8 +66,7 @@ extern const AVCodecParser ff_opus_parser;
>>   extern const AVCodecParser ff_png_parser;
>>   extern const AVCodecParser ff_pnm_parser;
>>   extern const AVCodecParser ff_qoi_parser;
>> -extern const AVCodecParser ff_rv30_parser;
>> -extern const AVCodecParser ff_rv40_parser;
>> +extern const AVCodecParser ff_rv34_parser;
> 
> This afaik will break command lines like "--disable-parsers
> --enable-parser=rv30".
> I don't particularly care, or think anyone will care, but letting you
> know just in case.
> 

I am aware of that; I also don't care. AFAIK we don't give guarantees on
that.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".