From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 16/18] avutil/hwcontext_vulkan: Include hwcontext.h Date: Fri, 29 Mar 2024 00:10:45 +0100 Message-ID: <AS8P250MB07444CF18C3D8C4311636DC48F3B2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) In-Reply-To: <GV1P250MB07376DB62F134F911FBD81A18F3B2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> struct Foo * declares a new type (namely struct Foo) if there is no declaration of struct Foo already visible in the current scope; otherwise it is just a pointer to an element of the already declared type "struct Foo". There is a gotcha with the first case: struct Foo is only declared in its scope; a later declaration of struct Foo in an enclosing scope declares a different type. This happens in hwcontext_vulkan.h if it is included before hwcontext.h, because some declarations of struct AVHWDeviceContext and struct AVHWFramesContext have function prototype scope. Compilers warn about this (during checkheaders): ‘struct AVHWDeviceContext’ declared inside parameter list will not be visible outside of this definition or declaration Fix this by including hwcontext.h. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavutil/hwcontext_vulkan.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_vulkan.h b/libavutil/hwcontext_vulkan.h index 895794c867..cbbd2390c1 100644 --- a/libavutil/hwcontext_vulkan.h +++ b/libavutil/hwcontext_vulkan.h @@ -26,6 +26,7 @@ #include "pixfmt.h" #include "frame.h" +#include "hwcontext.h" typedef struct AVVkFrame AVVkFrame; -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-28 23:13 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-28 22:38 [FFmpeg-devel] [PATCH 01/18] avcodec/mips/ac3dsp_mips: Add missing includes Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 02/18] avcodec/pcm-bluray/dvd: Use correct pointer types on BE Andreas Rheinhardt 2024-07-30 9:18 ` Sebastian Ramacher 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 03/18] swscale/ppc/swscale_altivec: Fix build with -O0 Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 04/18] swscale/ppc/swscale_altivec: Simplify macro Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 05/18] avcodec, avfilter: Don't use "" for system headers Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 06/18] postproc/postprocess: Don't generally include arch-specific headers Andreas Rheinhardt 2024-03-29 14:54 ` Sean McGovern 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 07/18] swscale/swscale_internal: Only include altivec header iff HAVE_ALTIVEC Andreas Rheinhardt 2024-03-29 14:55 ` Sean McGovern 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 08/18] avcodec/msmpeg4: Don't include x86-specific header unconditionally Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 09/18] swscale/swscale_internal: Hoist branch out of loop Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 10/18] swscale/swscale_internal: Don't export internal function Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 11/18] lib*/version: Use static_assert for static asserts Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 12/18] avutil/common: Don't auto-include mem.h Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 13/18] avcodec/arm/mpegvideo_arm: Use static_assert to check offsets Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 14/18] avutil/internal: Move libm inclusion to the beginning Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 15/18] avutil/internal: Move FF_MEMORY_POISON to its only user Andreas Rheinhardt 2024-03-28 23:10 ` Andreas Rheinhardt [this message] 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 17/18] avutil/internal: Move avpriv_set_systematic_pal2 decl to imgutils_internal.h Andreas Rheinhardt 2024-03-28 23:10 ` [FFmpeg-devel] [PATCH 18/18] avcodec/arm/vp8: Don't discard const Andreas Rheinhardt 2024-03-30 13:47 ` [FFmpeg-devel] [PATCH 01/18] avcodec/mips/ac3dsp_mips: Add missing includes Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB07444CF18C3D8C4311636DC48F3B2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git