From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7920946B19 for ; Tue, 3 Oct 2023 16:39:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADC1568CB2C; Tue, 3 Oct 2023 19:39:07 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2039.outbound.protection.outlook.com [40.92.91.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D38E568CA07 for ; Tue, 3 Oct 2023 19:39:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RH6Et4l/Zg2y/SBtjLjwJef2XVLA0HcyuywRUyZp+gEin6HkpayQs/Pe9CFHuDiG502FP7UDTmlKK3emoI5xBjnSCFu5Cc1WIvpswmZSXpXEQL5veh2/zPIBApLxI6+GzLxGFVOqFt5bVJpL9pLgOfid37q5MUy6vqdOII3e4AUb6wWdRfqVLni+Cz31u/1PUVbEimKMLwZGA43WuIjpMVZjGKqpR5NgM4Vhd2ugSLZw2M6GvaRtQFn/87zviCcHh4yeuZt1J+iOrSv3FsCESWiJRllR4/d2nJr9XdDEY+mISkAiaGoegjBGXaGKFQ8DV0jjQDIJxMhWZv1xE55BlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Byeh4f1N8ycc8EzhGlgAVc4cT8m/tpRgoj0QyPd4GSA=; b=NsmFTgynIZckUK3RmmXbo8RkueHm0zv73I9y1ZY4xzKwh5QFrO0CkO58vmSv984UB2AI6xNUZ9Vvlhn1dIeD38B/BPg4f87GX7FZCERkq8ss8rmxhYf5esHZgxUG8WwT9ooMe+zwo5VPg313CnqetmvPLGduCrc7n8qsLFJWANC2BYL2vlG0G48Y/ZjaIH2SX4eGFTJwH7jbJKkVPjKy4UT6Nx/DmSReXo1jg3x9niDgV96nUiuMcrNsfCrUXg4Vfh3lWVbGdghZDHwgOcRTchPzt8JLs2LlBF+WvObrUd4MyQwmj2xF47KZqBX81uIzp6aA1P2soThN+89dbq5vKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Byeh4f1N8ycc8EzhGlgAVc4cT8m/tpRgoj0QyPd4GSA=; b=ELl9GtMXjvpA9fo0J+LP722Aw9qIV9XaTm77D5UrI8L3FQq4JWDuePbPa1SuHMT8rct+IlLpQnGS6fyAHlLhPYVfRCFvPmEV/KPgKUnwo2cnbnGhQZfyEgfdOCXLD9NaTrDJ7ND0AZw/lRqEOxG1Pw22/wL4fK530KFikp8E/POaiREMislKWdQRWgKlfY+eu/FCPQ4Ll0fbTuw142CtTh/MBLlSJUpz5ybsRyN6t5T3GiUmMDxMfL016RRWqnW3ZigrgKYhXpNPcrVwq+6lgmZuOpv/fBTfLT9Keoyz6h0XEANwLRrl5wPC9Wa6otDe+dylkTGMImN2N+8iMwsCsQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0034.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Tue, 3 Oct 2023 16:39:00 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Tue, 3 Oct 2023 16:38:59 +0000 Message-ID: Date: Tue, 3 Oct 2023 18:40:15 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [VdYbVCigzUsrBlvfDcQzoVNnv80vwAug] X-ClientProxiedBy: FR2P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <885e7161-18a8-4068-a39e-f76dc6cea4a9@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0034:EE_ X-MS-Office365-Filtering-Correlation-Id: ca5e7dac-5bae-478a-2f30-08dbc42f3ea3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: puF+M6d8bIjNeOhfdTsPsAQzhoUwCt+vVDkkUnuwBH15tID8omMO+OxqEX+frM0hk100hZA8XzO1higA/wzNgF4Cb3nqjEQpKkrLKy7AqT+0W+2CyXcgNIuRUc11cdlIyVu264p91pO+yac1Mq3MxveWre6CG4jThgX39BHGFgZSHQnScUlq49aMlvXLNgvhdvJ96L58CEz1p7B04eEKWdeTI8JEPGdXCwYGhKCCg6ux1NHS1WQ2qfEFmvBU4k6nTHW0qdD8378IlH30mAYecHK6DVOMhzjzvxE3JLlPzYzFG2FELWR43K+kqseIQpPqvZML9kEPeAm0JB/f84C3qdVMnIRLry2s1z6c9A7v8xxPDg/YtZKu37NS5HMXPhhdMge4f+TocCFPIK0q5iMQpkXs3/hge8OdFbcyTdAVdXZJwg8NqLy/sZBeBbjYJRvTtqBDM3Uqht9UnW4ICHJGmfrfG054GFR9Y5BX59NqiIIjEN7af5/X3hph46nRzulX9CrhoWot/tMFBOTQp6Owp994noC8cGkn20Byfw3sL6O/JOyPNf9+hxbWePV71TXq X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3Q4Vmo1c2R5VzhoVjVzeTg1NkVrY0Jxb2VaRXBTUHkxU3VwamZkUk94Nkd0?= =?utf-8?B?NDN6Um13K0FmRnlKa1VYNVJZQStjcElnWHloQVJZeWVCQkxKbHB1djNJcWxT?= =?utf-8?B?MUJlT1Ftb0lncVpFeDB2OTM5cW5GMEc3TEZDMUk4RVRSYi9TenZhTllTVWZ2?= =?utf-8?B?MTBLbjhXd1dRdHBzSnNoWXErUTdPZStYMUo1Q2xpZmh0ak8vZnFiaTRUaGc0?= =?utf-8?B?WCtHaU90L0pXSDRzc1FsQmUrN1gwQ0szTjV5WTF6N0FtZGttQjZQVXBKeTZC?= =?utf-8?B?M2Zoc3pKK0hmNXVNczFvOGNJdFdpWUIrdGJDYTJrUFljVnl6OG5rN0tJVFBJ?= =?utf-8?B?Y3kxbHFobytMM3hmYy9KalMwTXpzeUIwVTBRcmVNSWhBRVhvbmJSOCtKd1dH?= =?utf-8?B?b0o4UmozVDJ5RjBaR3BMVjlzY1dTQ1ZuazdibkQ1WlJ0ajBybDN0cVN0eEx1?= =?utf-8?B?S1FDa293VWlPakVIOTBkMW5wbFVUdUlMajdIY3F0elFuTFUrSzJ0aWFGaGVt?= =?utf-8?B?L3VkYVRkbkQwK1k3Sng5eGtXN25kSFFMdTUyNG1zZU1VTVVJSzYyQlFqTk9H?= =?utf-8?B?RDlaM3Z6TmpSZkVkQkJrblpWeDBJTEJubWRpUllKdGRWZXhPeFlvWUJtKzJP?= =?utf-8?B?MDhHaFI5NTlNWmJ0OEFoZWtScTQyV3lTS1Fadmx5N1Y0RGdrL2d4TUswWFlI?= =?utf-8?B?Y1dReXBoNU9waWFTYUp2eUVPR3FlUkVxWVBKd3lmTGpwbUhJMjExenVVZUhV?= =?utf-8?B?RXNJVS9wa3IzeVJ6NFBuRjNUdEtBTWczOEU2TnlTQ3RROW9oSmp2UmZqekc5?= =?utf-8?B?QXFHcmxKMG1aQWV3N2habkhUek9Ib2ZpaXZhdUhzS3RGcGx3VHNwZmkxRFNw?= =?utf-8?B?ZFRCT1dYQzh3ZW9ra2NHeTBubUJ1dzhMWmRGVUFITS9kNnYrMnZ5UUlDVEcx?= =?utf-8?B?d21KejhwTCtRc0JMbnJPNW5aNmh1YTJ3UTUwRlVRQTlsTmdLaHZKMUlKZW4r?= =?utf-8?B?Rm00ZmZHVklwd3BVYkp4NDF4Z3hyUTAwZzVYZ2xLdmdEU3RtelZEYUlYOUJv?= =?utf-8?B?M2FuRytZWmxJVmNnV0VseUlUdjFvSGFSUFZJVlRGeVN2SmZXSEswbTJuZEZ0?= =?utf-8?B?TFRoVHduVmwyWTFsbDdGUXJNeTJvNDZQT0pCWUZHRThJU2FVRW9XcW5yUXJo?= =?utf-8?B?anZxSWc5aldlc05PVnIzcWRYb3hlR2tydEtTLzFWMFlUN0JuTTB2N2ZmcExF?= =?utf-8?B?RHhFbEdFOUU3d3g4M1VsYkpYZ2cwbmR3djAwa3BWdUdlWDc1eUM5TnprcnN4?= =?utf-8?B?WFJhWTJIOFF0MGd1VmF4RHZFcHl1eFI4SjVXWU5wbUcwdk9iS2l3WldUOENT?= =?utf-8?B?bFhUamp6a2ZSZnFPblNHc0xncEdsNThnYW44SGJmcEZwL2dES3pua3pYYURW?= =?utf-8?B?YWorUWdseDhwY2FPSjltL1UwZ29wbEVNSXloUWFLVFNOL3hUbStnSHdneWpP?= =?utf-8?B?bEtudEtTYUgyMnFiL01JUDgxSVk4S01sRWdvT3hzZUF0ejVJclVYQ3hJNS9V?= =?utf-8?B?Y0FlSGs1ck5qYjF0emx1WUVzMVJQWktnQjlsMXdodEUyKzAvQ0w4WE11YWtM?= =?utf-8?B?MEhUazZ1TGtFRWhBSXdSMVNFSWRoYlIvSzJyU1YwTG96Qlk1LzhKYVBkR2xt?= =?utf-8?Q?sNUCnlfUkXlHMiUuSkVG?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca5e7dac-5bae-478a-2f30-08dbc42f3ea3 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 16:38:59.9298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0034 Subject: Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > The FFmpeg encoder will be modified to also output 2048 samples of > padding at the start, to make it in line with other encoders. Once again: What is the advantage? Doing what lots of other codecs do is not a real advantage. > > + { "padding", "Override the padding at the start of a stream.\n", > + offsetof(AACContext, override_padding), AV_OPT_TYPE_INT, { .i64 = 2048 }, 1024, 8192, AACDEC_FLAGS }, > + A decoder is supposed to decode and output what is given to it by default and not trim it according to what you expect to be normal for encoders for a given format. It is not even clear that there are any padding samples at the start: The first packet to be fed to the decoder could be from the middle of a file. In other words, the default value of samples to discard should be zero. Furthermore, the description is wrong, because this option itself might be overridden by packet side data. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".