From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements
Date: Tue, 3 Oct 2023 18:40:15 +0200
Message-ID: <AS8P250MB074449F4B353F57F7D6FBA408FC4A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <Nfni27T--3-9@lynne.ee>
Lynne:
> The FFmpeg encoder will be modified to also output 2048 samples of
> padding at the start, to make it in line with other encoders.
Once again: What is the advantage? Doing what lots of other codecs do is
not a real advantage.
>
> + { "padding", "Override the padding at the start of a stream.\n",
> + offsetof(AACContext, override_padding), AV_OPT_TYPE_INT, { .i64 = 2048 }, 1024, 8192, AACDEC_FLAGS },
> +
A decoder is supposed to decode and output what is given to it by
default and not trim it according to what you expect to be normal for
encoders for a given format. It is not even clear that there are any
padding samples at the start: The first packet to be fed to the decoder
could be from the middle of a file. In other words, the default value of
samples to discard should be zero.
Furthermore, the description is wrong, because this option itself might
be overridden by packet side data.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-03 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 4:07 Lynne
2023-10-03 16:40 ` Andreas Rheinhardt [this message]
2023-10-05 2:37 ` Lynne
[not found] ` <216A8695-AE2C-4CB1-8704-DA82139B4C75@cosmin.at>
2023-10-05 17:22 ` Cosmin Stejerean via ffmpeg-devel
2023-10-05 12:24 ` Derek Buitenhuis
2023-10-05 17:32 ` Lynne
2023-10-06 17:01 ` Derek Buitenhuis
2023-10-06 18:58 ` Thierry Foucu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB074449F4B353F57F7D6FBA408FC4A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git