[FFmpeg-devel] [PATCH] avutil/display: Drop wrong comments about matrices being allocated

[FFmpeg-devel] [PATCH] avutil/display: Drop wrong comments about matrices being allocated

[Andreas Rheinhardt]

These functions work just as well with stack based matrices.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavutil/display.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavutil/display.h b/libavutil/display.h
index 31d8bef361..0c73bff5da 100644
--- a/libavutil/display.h
+++ b/libavutil/display.h
@@ -90,8 +90,8 @@ double av_display_rotation_get(const int32_t matrix[9]);
  * Initialize a transformation matrix describing a pure clockwise
  * rotation by the specified angle (in degrees).
  *
- * @param matrix an allocated transformation matrix (will be fully overwritten
- *               by this function)
+ * @param[out] matrix a transformation matrix (will be fully overwritten
+ *                    by this function)
  * @param angle rotation angle in degrees.
  */
 void av_display_rotation_set(int32_t matrix[9], double angle);
@@ -99,7 +99,7 @@ void av_display_rotation_set(int32_t matrix[9], double angle);
 /**
  * Flip the input matrix horizontally and/or vertically.
  *
- * @param matrix an allocated transformation matrix
+ * @param[in,out] matrix a transformation matrix
  * @param hflip whether the matrix should be flipped horizontally
  * @param vflip whether the matrix should be flipped vertically
  */
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/display: Drop wrong comments about matrices being allocated

[Andreas Rheinhardt]

Andreas Rheinhardt:
> These functions work just as well with stack based matrices.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavutil/display.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavutil/display.h b/libavutil/display.h
> index 31d8bef361..0c73bff5da 100644
> --- a/libavutil/display.h
> +++ b/libavutil/display.h
> @@ -90,8 +90,8 @@ double av_display_rotation_get(const int32_t matrix[9]);
>   * Initialize a transformation matrix describing a pure clockwise
>   * rotation by the specified angle (in degrees).
>   *
> - * @param matrix an allocated transformation matrix (will be fully overwritten
> - *               by this function)
> + * @param[out] matrix a transformation matrix (will be fully overwritten
> + *                    by this function)
>   * @param angle rotation angle in degrees.
>   */
>  void av_display_rotation_set(int32_t matrix[9], double angle);
> @@ -99,7 +99,7 @@ void av_display_rotation_set(int32_t matrix[9], double angle);
>  /**
>   * Flip the input matrix horizontally and/or vertically.
>   *
> - * @param matrix an allocated transformation matrix
> + * @param[in,out] matrix a transformation matrix
>   * @param hflip whether the matrix should be flipped horizontally
>   * @param vflip whether the matrix should be flipped vertically
>   */

Will apply tonight unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".