From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 35D7F49A0D for ; Sat, 27 Apr 2024 09:47:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70AB468D2B5; Sat, 27 Apr 2024 12:47:43 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2066.outbound.protection.outlook.com [40.92.89.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DBFFF68D233 for ; Sat, 27 Apr 2024 12:47:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eI+XybQpsmBS1zTPG2+qY7GVxWtCVhHCSwlLUWCfJN/juLF7pQyuywp3qH1N70gm6bUfsawAmmx6k6gc0SkvDMvjX9MauA0D0P7GZZL+TwTfteDgkqPlxRFSXQT7rtDf9K0FgJ4VPau+KBigGqOzmnK3ndsj613cH4od51iW88T0HNhSj7tWEzr3ipBUDUTcpX6sZkOlbEIIGbyeGVMCkhf1B0De1YPnKMmZKHw9R1pbDIW2DTgWy0e/N5r6RRfJevIo+X3sHdwyqNGBRKwROtsENmfdf1rpetXUudKXbPncmX6gOh/oGQuOMa0Oisvl8itaZGuGetSfnSeuQpr4Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nj4eErYevyG1M5w93kucPCHQdHoADx7N5qRIbQVDz9Y=; b=BE2/WpkCbqx4lEIsAx9M3kTL5zgF1jDMjzOQo4/fKOwlSk4mjZNLAjP1u3tsKO09+yL8qTThVI2/2Wt1F7tkBuAM8Xx3VutYVrT5oXvbP2PJIRoP0+Z/hKWIr14+mkcQ3xnEGa0aJv1F+BzuYGKd3KlxFnwBYeTKnvmUAY2vuyFrRdNK1w/L9dW0UCY95JnIteOAd8whw+J+rMFqPR3fKEYaFZUcvP+hRp0WB5jpM4mjlE1NsRpaUcB9IaAuFf+JqfqxdRRYXgiBhjSnC87NE2AyUnGaa8unbpjfyoFum33pN5k8i+/VUPPRGIgqWqG0FA2IIbt1Fb6Zch2fPoGGuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nj4eErYevyG1M5w93kucPCHQdHoADx7N5qRIbQVDz9Y=; b=qPBMUisY6SMmHrVEvZfKVo0BoE6xOUgJ9FbMKPgVZDyRSoyN87VpQzBUn933/qfKOca2geIP+SK0mtQQ9ORsaCc6fyHGjBoQwy1gs8Tg2PPeoHG5b8c9peIYu9HfJPNxzoGwq4CRwgTvhP+aGSTAzTTVhrfVCaBqz5yUNh7W5h0G7lI/NH3BZFZ089O/NRXUaVZ1K/+yHBUxJ681dKQhnB49qGdY7dd4vQS8/uKqOdYjpBoHpHF+fl93NCbuwi9LTNxQRLz2mADlHRfT4Zw4TqfZv6Vluq4ol/eArsb6co8ezFM/5LdSy69LxDMDFm5pKw0O6jI4U0ZpM1PbiuzGyQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0326.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:329::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.31; Sat, 27 Apr 2024 09:47:35 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7409.042; Sat, 27 Apr 2024 09:47:35 +0000 Message-ID: Date: Sat, 27 Apr 2024 11:47:32 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240426235211.3718252-1-michael@niedermayer.cc> <20240426235211.3718252-2-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240426235211.3718252-2-michael@niedermayer.cc> X-TMN: [04jeTHGFN9LOfPVvYuNvC5Um8GWwAGpvRYYV4VhIZGI=] X-ClientProxiedBy: ZR2P278CA0086.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:65::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <9bd62308-7ad4-4df3-9922-e290d0d1d8af@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0326:EE_ X-MS-Office365-Filtering-Correlation-Id: d0bf3c28-64b8-41af-241f-08dc669f10ce X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1602099003; X-Microsoft-Antispam-Message-Info: LFxRUsxXvNbcEHUCsjGxQIb7jNFK6T36j1C5U2b+do0hZsPDikpaEnBNTEJ/uhAUlyYepdWvMZ4iS+lsQk7b8WEVgaMG7mbPobO8ZVXjJtmtEK5z3YKnJ9YZuLe2GvSh4I+kB1GUoiTAKQqIM/GJxdHgDPdQzOEaL34kWPSBDBLr4aaxDh0zcRb7E+vI4ekOvulW2BcWsXlSFqjnc9GEijE0Jkzq2NSJZiNRS5su2jXmbMn9qZRstS9Pfv3DDeMvSlezMklV0ENHo7iWhk03HRN1LyyeJqB7TBRqBjLbSgaSQmyroQonrKS9Fk1TwImHJbg6jKi8irW6qlyWAzeoR9kZC4+5dVI6WOq6uBA6sT8KJF493Cvx5flK+IrjM0nnEK04XOsRbEEG+vJPHngCEQxTSEDRXiOr0m2MgOdMAMhLi+Alj/Nd+Ggvy4Tv/uaDHtI1MLhDjHMIpOD28f6HCVc6HevwWW9n0jbHYBz/al5lhU6neTYxaxC84+WhV16Vg8XnpT2lsatZ4kSeMzbhIsTJYCeAMYj4SVC3n9+vSvBZCNgzy4fgE+DPqhiaAaNW+n6sbCHI8Vqv2QiDhdl8W/Sekq+RcInXMD6BZwhmYcH0LuiSf85vfgY0Wni6RZmTQ6Q7+i7JlpxTHxPtUuPRtv2bZa/bRxPu9xWe6p7kL5k= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFJRMkJiR2lWbk0wdFdrZlFIU2dGQVhheTZIWjg0dGNyQkxYOHlUeGNMRzA3?= =?utf-8?B?ZUg3Q0tSQjl4K0dlbnp1ak1DcmdabGlJZVdrUGRKektabisvYmJpN2ZONW1G?= =?utf-8?B?YnY1QllDcTNXUjVyWFZyZ01CVjZwNUdwNlovUmNRNnRSNzRvWXc4Mkd6Kzlp?= =?utf-8?B?SVJDeGlPalR0aDMrQmV6OEdyUG5OQVg3Y0k2VEkrcVQ0QzQrZHEweTVlUXll?= =?utf-8?B?YTlHZGdwMG0vMUdxZmNnbysrckNUN1RkeStNcEVHa1d4TGM3b0xPcHQyQk9T?= =?utf-8?B?ZGpEM3oxSk5tSmtzRnJqWC9OQ3ptWnRVNnZzVDUvU0RPbUtDTk9rKzAxMGRz?= =?utf-8?B?S0g2ZkxIVFhyMlhjcGl5SWtLdUFrQzcvR2s0OXJqR1g2UGdyTGNjM28vbVJx?= =?utf-8?B?YTFBSXY2Vi9ySkJOWTRnRDRoMDAwK2EzcTliUG83cDBkd2k4N0pJMTEwMW83?= =?utf-8?B?OGtiRjhUTHN5NWhibEltRStaR3luSHE5M3J5SU0va05LWlYzZ2hEdmxSZ2NT?= =?utf-8?B?YUI3dTJoZFFSWWhnOE1SRXVuWHdLR2ViYm8xMkRZc3BFcjdXVS9CSm5nejFB?= =?utf-8?B?WllBL0I0bUI3cjcxK0drdzBXR0Mza0JaY0dlRFBHU0ltajh3R3JwU3FTQ0I2?= =?utf-8?B?Y1dsOG03cmpvd3pmQ3Q0bVdyZExWWkJkZDdQbU1YYWhpZDhuYzBLRVZlWURh?= =?utf-8?B?WFMxVWFKdHByMFBFSDdDaFlMRjNaNGNLVHRaeFJYRG9tOE0wUC9ZcWtJMXVv?= =?utf-8?B?Q201ekhiQS9Vcm83eHR2Tmh2c2dZS2dCWThjSEhPU0hNaFk2TmNYcDJCR0Zv?= =?utf-8?B?TGV1UkNaYkx1aEhzQkRzQ2c2WVdyeVZrYW1WRVB1MjdTMUs1aTNoQVNIOU1O?= =?utf-8?B?eHY2UlZOdGI2VUdIVk5RT0czMFlFVVhBTThSVGxsRTBsRmZpYmIwYng5ZjZo?= =?utf-8?B?NmFRUmFTaVNCSmVHVTFZdERpYmVYd0tCTVQxTjhxd0FyYVQ4Z3ZMZ05PVVRI?= =?utf-8?B?cVJVSkRqaS9JTkhvU1NpZnNxYS93eWxUUVI1eU84bElIcnc5RUxmSUprNXRN?= =?utf-8?B?OEE2RDhRVndlQzBDWU1UNGMzMjcvNmNGSXd4VnZoVHJNdG1wbDQ4U3V5VDZn?= =?utf-8?B?aGYrNUNiMHJ1MGlYeitMelg4SllnWWtEMWhrQmFTMWRPMnNSZU13Ny8zaDR0?= =?utf-8?B?RXZBRitGcEJoeHBOR2k5cUg3SEN2ZzdYSTF3OVNHdXh5SkFmK2I2R0tCNDJW?= =?utf-8?B?SDJielpnVHl1YjF2NTJ6b3ljM2JjYnJDUnBNRGwrZmlKU3dXWjU1aWxJL1dr?= =?utf-8?B?a3psMDZHS1VRTmFQZ1lVSUd5YlVlaWVRY0NGRkc4ZCtQRXE5N1NJUjR1NTA4?= =?utf-8?B?c08vNTk1a3hGNDZxQ1d0OFlKY3ZmYTYwVWRBdkZ0L0VjNW1QNXdsQnJKaTR1?= =?utf-8?B?ZGxxdUR6czhtais0T1FZRTZFbE9XdCtWbFNTdzkyV1c1K0FzdkRFM09KeDQz?= =?utf-8?B?Z3V1MDIybU55RTd6WlNSMmFLbEc4dUNxSXVINHQ1bDJJYzZleHpWOE5xdHJ1?= =?utf-8?B?aGpMMmZRUVZBS3lCd2hrSHg3d29Gb3FWTFR3YVJESllsTlIyM2l6cWVVd1Zm?= =?utf-8?B?QjNHR3phTGFaeGk5RjJsdFBJcmlRaVIyYjhwUWMyVmNlUkQ2NzFadFRrbnRB?= =?utf-8?B?aWdXUW8xYlZkOEhsZVdMMVY4YUkwN1dXNEZWdjNiRU9oUmVzK3NlSFZBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0bf3c28-64b8-41af-241f-08dc669f10ce X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2024 09:47:34.9782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0326 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vp3: Call ff_progress_frame_unref() before ff_progress_frame_get_buffer() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: Assertion !f->f && !f->progress failed at libavcodec/decode.c:1688 > Fixes: 68190/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5942090287611904 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c > index 2a5f68dfa8e..09527607767 100644 > --- a/libavcodec/vp3.c > +++ b/libavcodec/vp3.c > @@ -2651,6 +2651,7 @@ static int vp3_decode_frame(AVCodecContext *avctx, AVFrame *frame, > if (avctx->skip_frame >= AVDISCARD_NONKEY && !s->keyframe) > return buf_size; > > + ff_progress_frame_unref(&s->current_frame); > ret = ff_progress_frame_get_buffer(avctx, &s->current_frame, > AV_GET_BUFFER_FLAG_REF); > if (ret < 0) { LGTM. (If I am not mistaken, this would have triggered the av_log(avctx, AV_LOG_ERROR, "pic->data[*]!=NULL in get_buffer_internal\n") codepath before switching to ProgressFrames, i.e. using an assert instead of erroring out uncovered a bug. Maybe we should use an assert in ff_get_buffer(), too?) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".