From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9589D489D5 for ; Wed, 21 Feb 2024 23:29:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BB2F68D089; Thu, 22 Feb 2024 01:29:47 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2076.outbound.protection.outlook.com [40.92.74.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DE07968CE10 for ; Thu, 22 Feb 2024 01:29:40 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ccn/rpkY/hS5qeS67A0fpqf4utllsK5E83R/ijiMWOKljtiapV+eho9iQq2CaEGF+eWOzaHNxZ+V/MUsTNintFgnjDkyJHMBVHqF+7dzOcfgJSzdZcHN1UKChKeizQG2KvqqKU9jf/+k2BwqoRoMAYVFc4TJ8/WQJXcHJhzDBc0Mn9bJ+1dDxGCetMWc0fKY4fOSeRN8p8D4x/M15Aq9d3ssWC1R5Dq1IMh76i4cctWizrPYL+8uZVWE7RkHCIRGAir5PHkjk5AD2mK6Rz62xJnDwwvGLZ8eH4+F/fSN3s38mh2+0qSZxVF4cGuOxJ3ZKcc+8dSwlV/mIdWOkIabYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XjKHocVoQEg/xzNedeCb2kMaDHfUo1rRMDzud5nrUBc=; b=lfN40XrRxa/2DYOMS7pK49LhTTwp0+dSOgWaT/4Mxx83y5Ye3e29OWBkjZ7glB5n6nWkGjpdd1e4jqjcH0sTlB4SZISIpylnqKL+UIDZhlymfVR4pHidu2jj9TzvPG8ogAU2IPDv8KCSHBsgBdr7+8a4Tha5KJH241SnvFjDmljSIkZWIUBwtjZy3lTc+ssYSGofifu9qANWKE/FPhFaYz7otLPuQOAXxJ3J9m9F2ijbR5twr5uHZVclhPecG5yjAioN2irePmvPWw6O8Pd0EA883b9zM7qoyc7lQ31v15iE6lG885gFcsW4XglQ1TqdmvzyK5BXE2VMUyG2S/63bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XjKHocVoQEg/xzNedeCb2kMaDHfUo1rRMDzud5nrUBc=; b=OyhFb0cgez7Sh2nsriDqczKbj97OW7gFNrIl3xg5cqe8LeQMRFnO2E+iMqxTrctxQsORM+rx/4OrB3crtH3zBB8eVXS92J/dIHadljk9FtDoBDcRm8dVIfTvH9gjHmwiRhQ39VXn9sICdvkapp290z7EsbFynfyUFi28D0mEOLHEL8xplYa/1T3NRK9rMCQOvXAzIW6PRMSoEwGzR3fvykw6lyBgiIE9L0IVsOHFrBCsqZ/+HHgVQ+LwPpOQWKMQRgyeIgStiMGRsQ1MW5zCiagcBI1ulNcRpp/msKd5yN0pDTVsBEEa+H0WWT4BjhLwx5IYzt7tTsFofxCWvn3lgg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0258.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 23:29:39 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7292.033; Wed, 21 Feb 2024 23:29:38 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 22 Feb 2024 00:31:28 +0100 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [yP51pG1GvvZXiCZ3Dw0JNMym9Yt1k0pb] X-ClientProxiedBy: ZR2P278CA0083.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:65::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240221233130.1861976-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0258:EE_ X-MS-Office365-Filtering-Correlation-Id: f962cd5f-d2d6-40ae-9a93-08dc3334f8bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TnoELgxn60JlDh6Hcr8QzU3dVzqes8XI6HBgaixljvTqqJIaJ1HQgHO9nBroSTAvIwxSnbTb9ZZtj9AEWnYr/eQb4N4h/zScBj/k5yaj9j0WbkgNvmrRHXU1+bR2+gCwMhG6fQiR5EDQUR1KBS0hnW0Z63R9MIzS3e/FRYqL3uYtxQI13GLiLC8hR6Q9+RyKnI12SPvrwqTsZX5JYD5IHThNIfIhYm9DZ8JUlv3DsMSOh8Tv6RUxBmwbhHDQiQIBz/Y2rN/qGpQbknXAF0wWQxrrKOnOmRqX8v8opJoY1cNZVUeQyEW5zm6+LMlaCmHoh2dxh8drUZ/Ajjx5xTyGJhgSvgsUg+jn434supFo56xT2L7wC1qxzA64bcbY/fEEXZmEFr9NUEaSnd+QKQiohzKUXExwb7brLDdT0Im8MFMNKdeuWmpiS6K4fDQF7g8mqMAU8rREOZ9LzJimDZleuWk0iKb6BRTYJ/uk8iKM62depgxQY+8EEdbBaEqX2hoygMRzJuAm5+xGv2kyy3Uz5Ecy3lR9AS7lKknI0rkyZH4urNFMLcc251Eg/qqX2cs3u8hKxYulliYeEGnG/fN8e8w3l4YtEhGP+P15GVsKDkcyIB5KoAwA3WcKjwJ5he5p X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?16Oekgrgv82fOQUQfESftAKOblNyI+sC8LGYLPEYvguZ4yHle12nupet4D8x?= =?us-ascii?Q?tO5ihMhCv+6vGU4Nlm8WpuuKoQMNT0pcW0DQHIAZhboiVxlbUb8SXwW18pSg?= =?us-ascii?Q?EyULZrGjDnZ3ggS4xac6DA09J9ZvIkf4kCAQCoVYOxQfXv5boriB3gZdRQL3?= =?us-ascii?Q?yP2Fw52mpX+7eAUBvEJT03XepXVY+gWgbolaIQtv0jFo/S3YRKkA7+EI2XoP?= =?us-ascii?Q?abzHplOTyhbzNjXEcdr0zFbaOVo8mAfcr9aciwq+WuFGg4h2dVmbvdrOtiAp?= =?us-ascii?Q?KDSbBdzhDZJzZofA0NCSklhHA1k6Dc9e2LeVYV3AKtp7ICXRlbsmG17fxYdZ?= =?us-ascii?Q?BFlHsfaHcztcHbGVoGrZfrrfcDAR3NBRtchHyXCaczYldRw2UOnfwh+vxrim?= =?us-ascii?Q?ovW4IP54tFx4UDtKZan/QMv0f0E19xdEJ3f+cFxmLDLIZVXZuM+nYtTwbo7P?= =?us-ascii?Q?pM/F0+MEmA0RpI4t+PRdmrhEq9gIV3xJhH+9BwS+tbpLHy+dRZ3YemEiFPff?= =?us-ascii?Q?OJnZg86mqN3bMivMrOK4unmQWVt0fvDdHPPT8q/cINNU3eW0qj8EP24N/wJl?= =?us-ascii?Q?UFw2kzgiavNTbYKCe2MnfRHwZduoTstlxtnyokMrXUG+gPt6tbS7x+UHCbbz?= =?us-ascii?Q?zD2z6+h0JLN2xzmXyfeEBoBrqgna5QM9SwmaRtRuUMEnfBPCGMoIFcd5zKPj?= =?us-ascii?Q?6RP2tWri3R5q2omDJ25/ZfDVCxhriBq7vNJtELmPG8OtJyBwanUWD750ESo3?= =?us-ascii?Q?NHgRblagdrBvOnD7vE4mLcSoU+Vutg8ez9qXHXY/ZSOgrHIGdIFyVM3C+v6d?= =?us-ascii?Q?2IBVlxMxNN6TcQe29Xtjy1/r41aLKO6KOS0sjWPOW+fOkKOSkmC0qZyXFG/O?= =?us-ascii?Q?wt9AYxjEjV9P/2hqhD6ZycwDo7EwPicmRBqSNl+PHNL7fNA1VqxiNVkcdXsl?= =?us-ascii?Q?FpSNuqPOk+dm1uQAmWlmkgQqJ6KZiBzl3ZPaW4qVgHBi/s9tj4c4fTpT5JOD?= =?us-ascii?Q?ZAbgKoEmI+W+SlOLG8iK7ILvSL+OaZ8dIM1eg9nedx06k7JzN8wrCQT/Kool?= =?us-ascii?Q?8929StHvsaGI8RTX+tvvwPsYbPG/H1M3ocQmwy4/5U9aysGUBf/S9wCWcGbd?= =?us-ascii?Q?1hRRUhgQ/BtZbh7i2xJVeFWS7VeOCIME6SFzZ9Ay/x4c87mfQeAYT8Jx5t8r?= =?us-ascii?Q?yLIeElrjrCDWh9dgGFRtStwLUO5CZ40B/Sr0miOmbDmseARFVVnarktGV4MM?= =?us-ascii?Q?Ko3rdkO/4HS5SftWo32j4kc96q3pvJq+exn3qBLfaA=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f962cd5f-d2d6-40ae-9a93-08dc3334f8bf X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 23:29:38.6975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0258 Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h266_syntax_template: Don't omit unused function parameter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The calls to the sei_decoded_picture_hash read and write functions are performed with four pointer arguments; just because one of them is unused by the callees does not mean that they can be omitted: This is undefined behaviour. (This was not recognized because the SEI_MESSAGE_RW macro contains casts.) Signed-off-by: Andreas Rheinhardt --- I found this via UBSan test failures with Clang 17, but actually there are compiler warnings for this: -Wcast-function-type for GCC and old Clang and -Wcast-function-type in conjunction with -Wno-cast-function-type-strict (without the latter, Clang warns about conversions with different pointer types, like int (*)(void*)->int (*)(struct Foo*); the latter typically lead to UB (when used in a call), but are actually common). libavcodec/cbs_h266_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index 26ee7a420b..e75f2f6971 100644 --- a/libavcodec/cbs_h266_syntax_template.c +++ b/libavcodec/cbs_h266_syntax_template.c @@ -3430,7 +3430,7 @@ static int FUNC(slice_header) (CodedBitstreamContext *ctx, RWContext *rw, static int FUNC(sei_decoded_picture_hash) (CodedBitstreamContext *ctx, RWContext *rw, H266RawSEIDecodedPictureHash * - current) + current, SEIMessageState *unused) { int err, c_idx, i; -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".