From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 3/6] avcodec/ac3enc: Avoid indirections, allocations of small arrays
Date: Sun, 14 Apr 2024 20:30:02 +0200
Message-ID: <AS8P250MB074445B72F17FFBB43AEFD4F8F0A2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB0744432E9416A30719F18EDF8F0A2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/ac3enc.c | 44 ++++----------------------------------------
libavcodec/ac3enc.h | 22 +++++++++++-----------
2 files changed, 15 insertions(+), 51 deletions(-)
diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c
index a3a05b3ac8..1ef670622a 100644
--- a/libavcodec/ac3enc.c
+++ b/libavcodec/ac3enc.c
@@ -2180,13 +2180,10 @@ static void dprint_options(AC3EncodeContext *s)
*/
av_cold int ff_ac3_encode_close(AVCodecContext *avctx)
{
- int blk, ch;
AC3EncodeContext *s = avctx->priv_data;
- if (s->planar_samples)
- for (ch = 0; ch < s->channels; ch++)
- av_freep(&s->planar_samples[ch]);
- av_freep(&s->planar_samples);
+ for (int ch = 0; ch < s->channels; ch++)
+ av_freep(&s->planar_samples[ch]);
av_freep(&s->bap_buffer);
av_freep(&s->bap1_buffer);
av_freep(&s->mdct_coef_buffer);
@@ -2200,19 +2197,6 @@ av_cold int ff_ac3_encode_close(AVCodecContext *avctx)
av_freep(&s->cpl_coord_exp_buffer);
av_freep(&s->cpl_coord_mant_buffer);
av_freep(&s->fdsp);
- for (blk = 0; blk < s->num_blocks; blk++) {
- AC3Block *block = &s->blocks[blk];
- av_freep(&block->mdct_coef);
- av_freep(&block->fixed_coef);
- av_freep(&block->exp);
- av_freep(&block->grouped_exp);
- av_freep(&block->psd);
- av_freep(&block->band_psd);
- av_freep(&block->mask);
- av_freep(&block->qmant);
- av_freep(&block->cpl_coord_exp);
- av_freep(&block->cpl_coord_mant);
- }
av_tx_uninit(&s->tx);
@@ -2457,9 +2441,6 @@ static av_cold int allocate_buffers(AC3EncodeContext *s)
int total_coefs = AC3_MAX_COEFS * channel_blocks;
const unsigned sampletype_size = SAMPLETYPE_SIZE(s);
- if (!FF_ALLOCZ_TYPED_ARRAY(s->planar_samples, s->channels))
- return AVERROR(ENOMEM);
-
for (int ch = 0; ch < s->channels; ch++) {
s->planar_samples[ch] = av_mallocz((AC3_FRAME_SIZE + AC3_BLOCK_SIZE) *
sampletype_size);
@@ -2486,21 +2467,6 @@ static av_cold int allocate_buffers(AC3EncodeContext *s)
for (blk = 0; blk < s->num_blocks; blk++) {
AC3Block *block = &s->blocks[blk];
- if (!FF_ALLOCZ_TYPED_ARRAY(block->mdct_coef, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->exp, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->grouped_exp, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->psd, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->band_psd, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->mask, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->qmant, channels))
- return AVERROR(ENOMEM);
-
- if (s->cpl_enabled) {
- if (!FF_ALLOCZ_TYPED_ARRAY(block->cpl_coord_exp, channels) ||
- !FF_ALLOCZ_TYPED_ARRAY(block->cpl_coord_mant, channels))
- return AVERROR(ENOMEM);
- }
-
for (ch = 0; ch < channels; ch++) {
/* arrangement: block, channel, coeff */
block->grouped_exp[ch] = &s->grouped_exp_buffer[128 * (blk * channels + ch)];
@@ -2524,16 +2490,14 @@ static av_cold int allocate_buffers(AC3EncodeContext *s)
return AVERROR(ENOMEM);
for (blk = 0; blk < s->num_blocks; blk++) {
AC3Block *block = &s->blocks[blk];
- if (!FF_ALLOCZ_TYPED_ARRAY(block->fixed_coef, channels))
- return AVERROR(ENOMEM);
+
for (ch = 0; ch < channels; ch++)
block->fixed_coef[ch] = &s->fixed_coef_buffer[AC3_MAX_COEFS * (s->num_blocks * ch + blk)];
}
} else {
for (blk = 0; blk < s->num_blocks; blk++) {
AC3Block *block = &s->blocks[blk];
- if (!FF_ALLOCZ_TYPED_ARRAY(block->fixed_coef, channels))
- return AVERROR(ENOMEM);
+
for (ch = 0; ch < channels; ch++)
block->fixed_coef[ch] = (int32_t *)block->mdct_coef[ch];
}
diff --git a/libavcodec/ac3enc.h b/libavcodec/ac3enc.h
index 41b9a3a20b..54e14d43d9 100644
--- a/libavcodec/ac3enc.h
+++ b/libavcodec/ac3enc.h
@@ -127,16 +127,16 @@ typedef struct AC3EncOptions {
* Data for a single audio block.
*/
typedef struct AC3Block {
- CoefType **mdct_coef; ///< MDCT coefficients
- int32_t **fixed_coef; ///< fixed-point MDCT coefficients
- uint8_t **exp; ///< original exponents
- uint8_t **grouped_exp; ///< grouped exponents
- int16_t **psd; ///< psd per frequency bin
- int16_t **band_psd; ///< psd per critical band
- int16_t **mask; ///< masking curve
- uint16_t **qmant; ///< quantized mantissas
- uint8_t **cpl_coord_exp; ///< coupling coord exponents (cplcoexp)
- uint8_t **cpl_coord_mant; ///< coupling coord mantissas (cplcomant)
+ CoefType *mdct_coef[AC3_MAX_CHANNELS]; ///< MDCT coefficients
+ int32_t *fixed_coef[AC3_MAX_CHANNELS]; ///< fixed-point MDCT coefficients
+ uint8_t *exp[AC3_MAX_CHANNELS]; ///< original exponents
+ uint8_t *grouped_exp[AC3_MAX_CHANNELS]; ///< grouped exponents
+ int16_t *psd[AC3_MAX_CHANNELS]; ///< psd per frequency bin
+ int16_t *band_psd[AC3_MAX_CHANNELS]; ///< psd per critical band
+ int16_t *mask[AC3_MAX_CHANNELS]; ///< masking curve
+ uint16_t *qmant[AC3_MAX_CHANNELS]; ///< quantized mantissas
+ uint8_t *cpl_coord_exp[AC3_MAX_CHANNELS]; ///< coupling coord exponents (cplcoexp)
+ uint8_t *cpl_coord_mant[AC3_MAX_CHANNELS]; ///< coupling coord mantissas (cplcomant)
uint8_t new_rematrixing_strategy; ///< send new rematrixing flags in this block
int num_rematrixing_bands; ///< number of rematrixing bands
uint8_t rematrixing_flags[4]; ///< rematrixing flags
@@ -232,7 +232,7 @@ typedef struct AC3EncodeContext {
int frame_bits; ///< all frame bits except exponents and mantissas
int exponent_bits; ///< number of bits used for exponents
- uint8_t **planar_samples;
+ uint8_t *planar_samples[AC3_MAX_CHANNELS - 1];
uint8_t *bap_buffer;
uint8_t *bap1_buffer;
CoefType *mdct_coef_buffer;
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-14 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 18:28 [FFmpeg-devel] [PATCH 1/6] avcodec/ac3enc: Avoid allocation for windowed_samples Andreas Rheinhardt
2024-04-14 18:30 ` [FFmpeg-devel] [PATCH 2/6] avcodec/ac3enc: Avoid allocation for mdct_window Andreas Rheinhardt
2024-04-14 18:30 ` Andreas Rheinhardt [this message]
2024-04-14 18:30 ` [FFmpeg-devel] [PATCH 4/6] avcodec/ac3enc: Combine loops Andreas Rheinhardt
2024-04-14 18:30 ` [FFmpeg-devel] [PATCH 5/6] avcodec/ac3enc: Combine cpl_coord buffers Andreas Rheinhardt
2024-04-14 18:30 ` [FFmpeg-devel] [PATCH 6/6] avcodec/ac3enc: Avoid copying samples Andreas Rheinhardt
2024-04-17 15:04 ` [FFmpeg-devel] [PATCH 1/6] avcodec/ac3enc: Avoid allocation for windowed_samples Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB074445B72F17FFBB43AEFD4F8F0A2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git