[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check

[Andreas Rheinhardt]

Fixes Coverity issues #1596529, #1596531.
Introduced in 8e35e33d42efb89ff7e3da92b841a3b43a5a95bc.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 fftools/ffmpeg_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index f108f8daf9..382d0f75b1 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -862,7 +862,7 @@ int ofilter_bind_ost(OutputFilter *ofilter, OutputStream *ost,
         ofp->fps.vsync_method        = opts->vsync_method;
         ofp->fps.framerate           = ost->frame_rate;
         ofp->fps.framerate_max       = ost->max_frame_rate;
-        ofp->fps.framerate_supported = ost->force_fps && opts->enc ?
+        ofp->fps.framerate_supported = ost->force_fps || !opts->enc ?
                                        NULL : opts->enc->supported_framerates;
 
         // reduce frame rate for mpeg4 to be within the spec limits
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix check

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Fixes Coverity issues #1596529, #1596531.
> Introduced in 8e35e33d42efb89ff7e3da92b841a3b43a5a95bc.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  fftools/ffmpeg_filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
> index f108f8daf9..382d0f75b1 100644
> --- a/fftools/ffmpeg_filter.c
> +++ b/fftools/ffmpeg_filter.c
> @@ -862,7 +862,7 @@ int ofilter_bind_ost(OutputFilter *ofilter, OutputStream *ost,
>          ofp->fps.vsync_method        = opts->vsync_method;
>          ofp->fps.framerate           = ost->frame_rate;
>          ofp->fps.framerate_max       = ost->max_frame_rate;
> -        ofp->fps.framerate_supported = ost->force_fps && opts->enc ?
> +        ofp->fps.framerate_supported = ost->force_fps || !opts->enc ?
>                                         NULL : opts->enc->supported_framerates;
>  
>          // reduce frame rate for mpeg4 to be within the spec limits

Will apply.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".