From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 759AB4ACD4 for ; Tue, 18 Jun 2024 17:28:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 803BA68D6CC; Tue, 18 Jun 2024 20:28:29 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2066.outbound.protection.outlook.com [40.92.48.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D3BA068D5B0 for ; Tue, 18 Jun 2024 20:28:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JFSggalYqiNLyEYsNcfRv0cDZI7bXOAcKgQ4TwLhcCOVLK6ye81b7BLk/y9I8d9XssglYorW9QF2lF6APmNqpx+cQ0MvfM2NXIgZZG8GVcdLQ4iTyYp7fBbDrqKOF4LejiG5tEGIiaJKSid4/3RBDfjwea8neLqFJ4miUN2vrw3dwR3mphS0x3RLavkJo67rgfQMmu8+PGKKDOVNIczhJcJlRJfTLrZrQIeuwmRsHlAImUzhV32dTMdZ3UcoO500JH7J/A6oR40sssQep9Vs4V9ZuTQ1lfJyMIANsC6V0D25NjNtstEfHvKT4WRhqveKzWdc1GYy2sJqlrY4d3AOZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xjWwl+KLyb9TVBMS/uGGU6/C4wxSPV2VDXq8QYV/KQ8=; b=Vqm57lGXVY/hTEWLGe1KCoAB8LLkz6/r1+xnpGOhGFaIhg3DA/XHWAKDL3+fCOZsWOn/stcMerpw07u+1X2II9hetY+D3PmNIDhTZifdA9n0i/JE7mlZlBiATHlekm4DUrwDT3+t+LwooMmFwoqalwcHtByZZusGj1ttNITSyPoJDlxkVUG53c2xCab8+UArlRYFzAlcsPyPubsuQVmOraVXgJD7wc9byf/P5Y6By/W5ollOfJqqdqV3GoSEW3/Jt512d+0rxpDfZKTxGZgnsG+Iy0So8RN/+c8UPKJ3rxMySCD24TpzqiARnbiVkP155YKxMf9oBeovMuMU/O0UYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjWwl+KLyb9TVBMS/uGGU6/C4wxSPV2VDXq8QYV/KQ8=; b=HhPhJdZc27ND53nfgxf5Nn4/7vqa8kc/7XJvSTrch7s4Sxfc+9NH/f3e5UqY1/AAqa3mLyhcGEekYmFH0QzT/11SO1ibYLzd5zdpubQh1iusjdH9K4dzpy7qNrzCtRczUctbVfjUrjSeC0yskVqPSIhhpQdSh3rog1Lzicwa0jzcl8xIdEZz/RKsYjVPMtSh1MIr9LBp3CpLckENO8Am5NZw4D+YHsaT2rnM7PPEWvWMhjQ+YtgicLSg3fEFXF7RKYrCW7+SVVUqNaToW+1LQGXj0YhxD575HXdrJXW5VjROV9sDyLz9K9LS/eavdMvNcO+TjXE9tlBolrWcmI5mYw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS1P250MB0606.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:48f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Tue, 18 Jun 2024 17:28:21 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7677.029; Tue, 18 Jun 2024 17:28:21 +0000 Message-ID: Date: Tue, 18 Jun 2024 19:28:18 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240618134826.2189719-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240618134826.2189719-1-michael@niedermayer.cc> X-TMN: [21I0wsCbGQgDKv+vdUmh4EXuIdI1mAK5qP+1xINq0kM=] X-ClientProxiedBy: ZR0P278CA0061.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <9971afa0-6d58-4ffa-a851-8f41746af704@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS1P250MB0606:EE_ X-MS-Office365-Filtering-Correlation-Id: 665f3c50-688b-4e9a-c53d-08dc8fbc0cae X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicDH4mc3Dcf1ahMv66osZ2jinUBl4l9vh7dnAe9kXXQZt19BOiiMBaGB3IkZXlyR3hEF/NJJOldR92QeiKcxSJk8aFkH/84uX3hv6rDgIRy6gMsBcyoWkl6A0VW2ZgO/epyhyp5WBiIc2qPvU5BLVgu3//o085LOfLCl16wAFHjzJou5Bm0NSxlUkA/yHpRtFd8k+DnhBk3rS61eUBACYxteqdGMsYGWUQmWvdLLoKxwsDsLnA34qPNcY8/Waw9QlE2V2alQrKfDRV0KpnvNr8AEbYUjeX14CviuT5UmVhjAjFGgc0Fz/mbOAD7b935aPqx05V8qvBR9NWzBGBm82LM4G+7kdHFWOaLmiOA7OFTRKkM3iAHOxn+VGmPikJHT3lMP3ds1Qf2506Txj7OpvRyQnGiPbmYQMiOwCl9D1CAx47f4b+r+1H9mMtiehRaO8aNpkBHNkdKeQVaJt5qYcMn7zALtcEvkNN44m97QioS9XeW88qoOjrCKXFs2Q/exQt5Q+fYakGVWxcxyYI6lSZAM9+BArGoJUOZ8TZlb/A6iorinL6i9tLVVrwwyVeDVuI/n5Okw0NcyAC9xBeifgp50snz7kw4H66j5txK1HHhTK4t7AS7zDJd4mqvuHla+yuXfkIJitoUCeNhuaT2nxbMUjxg2em6f7dOl/k4fsOxA4mJU/O36iYtqNikqHIJ05VEsddg/g3FHCG5o1ftK4fMIhSed1H1xsUlhA49Ls1llVQ== X-Microsoft-Antispam: BCL:0; ARA:14566002|461199025|3412199022|4302099010|440099025|1602099009; X-Microsoft-Antispam-Message-Info: gMGHJJbfk6lzhiIdm1+gg7SqgKPV7BYjKzzrue9iFPxHukUaX/JGeS7A3maa6Q+A6wYKs+gr36vqZLal4vXP6Acws3MMy4K6uJan40cxTnQnn117BIEOsq4nt0U7KnxDTPGRE+5lWCfi/Izc/gqHMtGQqnLtSSzoCACYP1v4Mv5YFp705eeeKbAmFLZHEI98IGvaoA44WH2GsFoDEe+Go/HBdgI+VsNjyD2XzKfBcx6p5L92M8oKMwSCUt65w1Jp2GtNNBEJpWWYTl9MbKGHuqiFVkULcEI9ifpCzSs8PhOtekZJexVlEXFWZPnwwM5wuW25Mt/Q1REm+8WTy+x2c+mbytRLzrjwwTxcUfL8t1dUc91oe2FApnlmNt8t7sTgT+LUyya/UMLVtEDLRHdQdCOAVN6AsFUsa4Hvc+PVWAJtku6MclEhwIoHcOR0+Had2PJbP5CTc8ES68uSUZWc/gvqJlLXDKyTUc7qRcouIlrjkqvl2MOwrCfQYuGeAbQ//EcWKnNalaFZKcIURKrTq1hfo6FijV16mJaCmReOyESz40K4VTk5Y1kTh/pj8wCbJglEl5brY0p/BB/OjtTH33xfesTMu4Y65bqb5h/IhWVGwpdFTcTMYMg42CErIVKoK0Uy8k4c+qN7VWfbxhyyL1lL948VAX90rzMxGkZZSgyMI1jUK5QOn3o5PwTAS6jY X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGVOVGh5bFBJblVLWCtDKzl0K2Uvb29BS1JSMU9CM2QwT0pReTJlbXpOdE5i?= =?utf-8?B?aWhFdlZEbm8vRGpGdlQvYWx5b3dBdGNVSzMxL2wxM1RDSHJpbFdqMVJZZGg5?= =?utf-8?B?K2V2UlBhcmVvSzI3a2tFdzd0VHhBOW1lU1dsZWhEYjF0aXJFem1oSlpzcUFK?= =?utf-8?B?cGswVi9HZmJJZCsvc3hXcWkwZDRUUDFBeWtRMlNPSGpxVjQ3YlRHWTNMSFhF?= =?utf-8?B?Tk4zbVFwR0lvcW1vVWxvN1NDeU9JUjEyR1lwYXBrUjFkVDRhRVJJVnZ0TE1m?= =?utf-8?B?RzhiVVpmNWovOUMyb09nN0lVWlFtM09PU2QvTkdEZ2pWc0p3OERMSjI5QkVI?= =?utf-8?B?N2tMN3pZTWZwNHp6SDU0aFNaZUUyYUNPQkFmNENVRUlXUE5xa0V0bzFucVRx?= =?utf-8?B?VmtkbmhNQy85WjR1ZlNJQVB4aGpZL2RxNmlCdmt0WjlFZzVyMjVKSEhVcDJ4?= =?utf-8?B?d2RCVWJYWWdQMDhXeG80VTg2aXFHTlRTbmpFNWloTThWQ0IrUU9idDdvK0Vs?= =?utf-8?B?ZEh1SXd5cytVaEZmbGJZdS9pd3FhdlRNN3VTQkh1K05Va2hzZWlZVjdXcFV1?= =?utf-8?B?bW1hU3BnUjI1dXN5bFFzV0tsaVA3KzA1TjJwUTM1cVJaL0poTU12MW1yODEv?= =?utf-8?B?Q2YxWHRVMklvYTc3MzFZOGpwT080RkRjTGhBWkcvekxYaFRpcWxpTzBkZEJX?= =?utf-8?B?aklqQXdKaFZrWmV0d3VxTWRLNlA4MG8xTGJTWjlqUjdaRjNPQTg1SXdRdGJ6?= =?utf-8?B?QlpjUGszcXFkWHN2bnJwNWJFbWdQRExuWjU1TDh4SHVkc2ZNenVtV2lWbEI2?= =?utf-8?B?Y0Jsc3FOZW1zU3JwcExhcWtrTlNKU1FGN0ZHdWx0a0xtU1pGTnZsR1VHZWkx?= =?utf-8?B?ekRLODdPbGEzd09qcURDZUtuVUxDUWxsVkREWXpkREhqc2tjVXNqQytzMGVx?= =?utf-8?B?WDVleVhUQ3pLOUlVQmhJOVJ3WUg2emJuZ1JmVTJUWHpNdlNqQWtDakpTTURW?= =?utf-8?B?bGUxSEpzYVNNYmI3QVkxWGFpcDBmclV3bEx6SHJyc2Q4dnhNVEVhK29sTFFh?= =?utf-8?B?OWl4OUI2YjNHQVFHaXlqU3NsbG9SWjJzUHd5OGJXMG9jUitUOEU3Q2diclBH?= =?utf-8?B?UThzNDFDMXRnTGUvRzdmdVNPenA4MTc0MnkvMnpyZytWb0pNRDRuSGc5N1BQ?= =?utf-8?B?NmxELzlpOVBid29ra0NXcklzUmxyRE9iM2Z1NU16aVF1NGJxeXA3S2tTOFVI?= =?utf-8?B?ZTArUDB0cFJWd3QvalhVeTk2blZJNEo3OTJ2ZG5jSDhjWWpaNlVTWXJyUHl4?= =?utf-8?B?Um5ERkV3T2dzdnZQNWsrcS9DUFVRcUlQa0ZPL1A2Unp3TFN4TFJ1SEswalRF?= =?utf-8?B?SHVBSTJzeFNWR1FkV1FGT3I3Wk9GemtxVkw1VEZ1REloQkhLa1RUbGpRRzJk?= =?utf-8?B?U3lyVkpPenE0b1E2cDJMMkluOHJXMW4yOStpWlZXUzlvVlRhcWlCbWJFUlEv?= =?utf-8?B?Q0packNJSlNpQ0xFYm1yaTAwUnhldEJMUnVERVZaZHlJNjFZMkVkdUtndHhw?= =?utf-8?B?dVo4cWgxTTBqOG9MOGY3MEVsaGprTmYrcnZaMlUzWENJa2d0dTlTTFdyUHRp?= =?utf-8?B?K2wvZW0rWTlQaklRSzNzWTl4cHdyUnVQS1Y4RzNDbGw2K1JueFVkYlY2eWpU?= =?utf-8?B?eEs4U295QkpFWkdFZFpOZ0tidUM0bWdSM0R2andUM0JGdTBubzRKZVhRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 665f3c50-688b-4e9a-c53d-08dc8fbc0cae X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 17:28:21.1642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0606 Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/utils: apply the same alignment to YUV410 as we do to YUV420 when motion estimation is used X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > The snow encoder uses block based motion estimation which can read out of array if > insufficient alignment is used > > Fixes: out of array access > Fixes: 68963/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-4979988435632128 > Fixes: 68969/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-6239933667803136.fuzz > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 337c00e789a..7914f799041 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c > @@ -259,6 +259,9 @@ void avcodec_align_dimensions2(AVCodecContext *s, int *width, int *height, > if (s->codec_id == AV_CODEC_ID_SVQ1) { > w_align = 64; > h_align = 64; > + } else if (s->codec_id == AV_CODEC_ID_SNOW) { > + w_align = 16; > + h_align = 16; > } > break; > case AV_PIX_FMT_RGB555: avcodec_align_dimensions2() is for decoders and happens to be used by ff_encode_alloc_frame(), too. But decoders should not be required to add more padding because the decoder needs more. Instead the encoder should add more padding itself (by using more than 2 * EDGE_WIDTH). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".