From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3A23F4FEBF for ; Thu, 3 Jul 2025 19:14:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C75B268F0AC; Thu, 3 Jul 2025 22:14:50 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2094.outbound.protection.outlook.com [40.92.90.94]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id F321668ED6E for ; Thu, 3 Jul 2025 22:14:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h+CxC1t3TG5loP8DARmR7enW6lnJjIWSEvV/CLll+XlDQ7bvjfsESyGtH4AwW8wzd0U7GsVRDuoIj3w0bmGHsHXQfS+dSKX5d9bmRwqSkWMBV/YmJ5GGLb7vkUQ4l4c1p3hBaL/XpSIL9y+JYziUCLIvzJh/4+tGAuJc4PAWTxSseSoB/C7MmTtreRASze9ShFAzLvEfJ2W76Kodul8ee/4Y2gmE9daY1MC5GMUt96CQw1N/1ThKIRaeayIgGZLYOVMcvhI5Q6vu3vlXzTi2Nxyi5cb71jqhPnIULGQJemiEwlnIxkPJKr+AuUPrUcbocrta1wm65Vptc0BhWfYiEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bT67OEYkFWUXvrdXCSqU0JkF7GFORlyIWZahi27Euz0=; b=wOXb1OS6rgMZBYKDIlmNXTgW5/73vWHSEAgeTpzo8oJvwAlMxLvwo32gNGh+c3ScnHahxpz/oQwaiVKVnHS675I1DNrgbW1BrfiFt5dG2vPNRn/zb8AfGfPxp1580K8YQYY2mwThVlK9MzwjkH2KDcf1t/MYp9BUjG0D9UdA//4wg+eCimyU47YXK9RvMf04CWCMdRsxM2YrUynr2pbeKxdikfidn6vTKmaewjmrLXzvU3w+IcyDWEF0EXBskxlJEJhe9xIA2JjUTiU0bz/WUvDqeyH6IHqKL67Odas8aoNtqyEpB/RDu2E6zuB83Wa4VkM6g2z/Vz8WEpS0wqy62g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bT67OEYkFWUXvrdXCSqU0JkF7GFORlyIWZahi27Euz0=; b=B2+8c7JYBI/+lWJrA/dWPFiPgN493GHqtX4l41DrxGcXydnmyPI4BsOSFsoWG5OLi1NOAwkfOfT56qexk8gHrTJMRUcW5LBbgmklEBzM2RBeXGku1irtnnVRpZylVcikGZAC9oPStQpK2u0Fv4Dy+C1wZPKyUMlQrwPog0wV+R0rKdtAMENSwvV7UF76AdqEZR+Pm4gbqZtGwSrdvN7IgdJ9WpOan0qsrylK+fC0roqqPsfQx97fylZ+mWtw3PDkXd/NZLC/rdNrGz/FTZsPHK4rZRUTKVWnI4CcpJQtbJGFdr0z2Rbnhg3gI6PbWSt6RkSUDDGLVB/XZSOKPBQ9tQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0385.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.23; Thu, 3 Jul 2025 19:14:43 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%6]) with mapi id 15.20.8901.018; Thu, 3 Jul 2025 19:14:43 +0000 Message-ID: Date: Thu, 3 Jul 2025 21:14:42 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250703020131.2506428-1-michael@niedermayer.cc> <20250703020131.2506428-2-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250703020131.2506428-2-michael@niedermayer.cc> X-ClientProxiedBy: FR2P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::7) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <462ed187-d015-4706-9849-263a625c81a0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0385:EE_ X-MS-Office365-Filtering-Correlation-Id: 6aca238a-5e58-472b-ac5c-08ddba65dd89 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmpEumVcsW5TnV0VP9oHPPxbx5jeRvhEI5ssBwNV88MRSNjf/XJwcoGKaZnWTAnaqAWSZntPcr1xIpb6tXQBI1/R7cPuo09FkOp9Bhh+M2IdHmvAEKQnkjxfgCoEESh3VgVsBYi5CCEy4JYT6bb/qYC2UswQZIwnAqvu/g7HCavEXO+4FlBxRbPchkN9HTGtwu3x0od4kWeGwA/llssD9JZvi4wHyoZW+HQuo7Utyu0XpdCZolbV0Nn0zVFq5WUXDUd2KcoWHlf0rFd0J31Q+e4OeE+5UvGkxnCVIAivb3KlTdaWjK/bOwt4guKfLqeqXIcW8iA30/bSzPHdj2JZc1XnG0FBv36oB5QsCgYjiVIhkdmi8SBZmfjnJhm86klDWhKkYZOHsothIJK6BfL2RHQhKfO14+Z9nOW1g9+hnmQ0FlzJWFhe3Ff9YR/XsI2CFzB8U5RvBQULZ4otRWj/RGtT42uhMZD7s9r2zP/PA77M6JwSO7OAIKeEp+YjBdFrAEC4MCrROlC3CCrhD6cmcsl+/TYQ4C1prJckgMu6vVTHyEPAtB24RAOnwC1Bikf3WWv0RtxkBzPphpogT3qrnNTDz02pvnFzcttdBMNQDzClB4tIJY/pF0wmTQIisW6EyI4Sllq2JZ0Q8uyhgRwQ6bGIUER+BXMKY5BRaqh3RblNTInJsF8gVCRvIy8TpQ8OY8OLtI7X87aKVtwHUIhTnroRxtoBdHR/+NEORYN+riCavO68oiGpyOU02UR69XUg9CI= X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799009|41001999006|461199028|8060799009|7092599006|19110799006|6090799003|5072599009|3412199025|40105399003|440099028|10035399007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZThaRTcxSHJlbHVOZGcrYmRCME15Y1Q0V1NjZFVqeGhXVjFZYzN5OVR5aC9C?= =?utf-8?B?RDlzTE9XOE5TL2oycENKQXlpWEVEelBnTjlpQU9SajgyRUY1cklLdlNXcWxM?= =?utf-8?B?ckFlSnRWUDZUSE9wMjl4bzNjRjdHZE11bkFISnQzTm5JbFhlZ3VmUEhJWGMr?= =?utf-8?B?dG9sRCtUbmVsZTV0ZXh3UmZYRHhxL0pIVytJSll6dUgyQzBIbmpMNUw0bVB0?= =?utf-8?B?VmZrbUoxSStxRWFBSm8xQmI1aVpXSE03RWw0UnN0dGN0K1JtcXQ1Rmh0cWNp?= =?utf-8?B?SFArTVlVczB2YldyYkVaOUpZK2pBNEN6TnhhWWh1ZUJUQ09YdytGUkd4ZnAv?= =?utf-8?B?NHk1ZDN3THBUQjN6TnhNbjMyK2o4cjR2eWF0R3ltKzFwdWhONjZHQm5WLzhW?= =?utf-8?B?Ni9hN2M4Wk5NNVhjSHRTSThTTFk4NmtvWmNOaUxiMVVhQ2NFWC9semJheEpF?= =?utf-8?B?alJPSjJ2aTNtL1REWW1nWTdhcGJBMUF0YkdWUUJsa0RLcGQrR3hOcDhUblB5?= =?utf-8?B?UjliYldHY2N6MjhnYnJFSUUrMVE0RHRrKzlYVWxybTBvOU82RUZnNlZOblBY?= =?utf-8?B?NGNnb25zWUVPNFpyVW1KNVpsRXZOZ2Fja2hNRnY0QUJCVkhpS1NtTWNXUUQr?= =?utf-8?B?azBFY0J4NWYya2VDWGZYZ044M25DRXNoMnFoTWFZdmFONys1RXJPNE1NQURN?= =?utf-8?B?bm5rcTFLdDZJY2JjbnR2M2ZCNlF1SjRwMFJrdmR5NTRIT3dmL2w2b0hPMjRO?= =?utf-8?B?Q2ZyNzJXKzN6NUtzNWRrR3d6T2t0TmpER2JhWHJmUGViMW5TS2kvRXBoRU52?= =?utf-8?B?aEpDNU16a0FKd21zbXNiUXRZcnlOVWEraU5zZmExcWZDWVc5RUhXeUx0bXZY?= =?utf-8?B?cWdoSE5xQUM4YUUzU3hKVjZybXQ4NnVxSVZ4cHVvK3BmNzlsYmU5Z2NVOE94?= =?utf-8?B?cmdhT20vSjcxUUZQem5CUHhaaHZ4MGpTNUdlMXR1OHFPSGFDUjBJZDc4bGNi?= =?utf-8?B?WnlwRjhOeHRHNmMvQnEzVFY2RTZwc3B6b25uY21DTnhKeFlwNU91SXpPT05v?= =?utf-8?B?T0NNMFc2bTFmd1VURzZ4amZCbFdWUHRHWDJtTW9IamJCcTZGOUM4Mk5lMkJx?= =?utf-8?B?SUpneSt1VGhTVllLa2Y1bU9rcVVZdmFQWGkzc05OVjVnSmluYW9MNFdHd0lj?= =?utf-8?B?M002Tk5XSjdtd1U5UEo5aVJOOFpPVml0SHV5d29WT2FCcElQbFdHYTN0dDNQ?= =?utf-8?B?VnkvTzZuSGFVc2kwdnhDQ3hOT0UxNjBoMGtUbEtuNzJIc25ROHJvUXltd1Ux?= =?utf-8?B?cnBHRnc4MXRKNmxFV2sxQnAyenJkMVpickJrQktZOWxwRHVEVmlyVTFwRFF0?= =?utf-8?B?bDBMcFhUblFrRTY2cVBLdjBwTnY5M2YzL3J6WWNaSXhJb05Yc1hIQ2VTSzJa?= =?utf-8?B?L0VXaTJLZDh3ZnFFc21YMWlOZFFoQkRKcjJ1Q3dkQXhNNEY2cW01S2xRK2lO?= =?utf-8?B?Y2lVRGg3KzQwWC9LYkhqWCtnSm5pOFVPbmNueUpzM3J0L2dlK2dkUEpCVWs1?= =?utf-8?B?MWNPY0hqUCtjUHZ6ZWlxVjBReURFakhMaGdGTzN0MWkvY1FvVExoQXF4Ymlk?= =?utf-8?B?UXZrMnJBWmxnQ0x0bnFob1daaWNiK29lckZjRXk1bExHbFpORkhxNDVYdlJC?= =?utf-8?B?R1FFVVdlVk1YU1UrRkM0QXNiYVY0NFNZSlR4TGE4NDRvUmpJS25LY3NRPT0=?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3NZMjQ4RFRxa3c5M0svVnpydGwwYTJDcU13ZFprSU9JZTdPcUtvckFLQ1JW?= =?utf-8?B?WXhEKzA3UXBBWUdzNklFdVkzV0daMGxWWXJZWGF3bUJGWG9HeWVYb3grZ3c2?= =?utf-8?B?RFMwaFpnWE50aThTUkdhMnBuOW45TTFuQW1veDdvVXBvb3A5ZHBaNlJmZmJQ?= =?utf-8?B?cm9SWEc1YkFYb2gvZGQwWnFVbTNaeUpINFFlS2NYK0lhRFBvdGRad2JVaVd4?= =?utf-8?B?T3lFdXFQUG5CTU9zNEpWaEE1YkxWWkNFM0xVOENCd1FlcVk0Vk4vTVBQMzV5?= =?utf-8?B?OU9GZ1hvdTNyUzE3K3N3QkdIVXVSNlg2NEdrVU85MkVCVFFZSE1oTDFZWXI0?= =?utf-8?B?VmdkZFlrTTVpN0NRcGpNL0dHWVd3NnBRRG5UMXBiWUhkNGhZUHRuN0Z1Y1NZ?= =?utf-8?B?UGhBWHkyb0VkWFZ4Tm8rNlhuOXF6UjJGSXdSOFdSZVdqRTFCa3lxYVp1MW9r?= =?utf-8?B?N29Oa05JL1JEbXJxaGttWXhjclhyQVQ2eU55SUhXQ2x0VE56N1NDSmRUYWNY?= =?utf-8?B?VUJ4bHR1RUkvZk1rdVh6V0NTVGVKV2JYdDcvWVJLUCtDT0NNWHZaMmhuL3hq?= =?utf-8?B?RDlWekpQNG4xKzRSZy9DelFHRzJ6aEZXNm04WUxiQ2dPbnMzTTVqZmdTUTRZ?= =?utf-8?B?SCtSdDlLV01aN1JLYjRKVFBHOC96czNRemRQVHltWkh6NlNsaGcyUWhTZGUz?= =?utf-8?B?MU05MXhnMmJpa2t2SjhiMXJBeERKUUVtM3pyWEFlazkzaHM1cXNpSW9oVDZq?= =?utf-8?B?WHFvTkJFdDQzVVFxdGJZMk84RVNJNDJMc1R2UHZsMkJFTzRIck9JcTR3eThz?= =?utf-8?B?bWJGWGowWG94ZndhRzNObnNIYWwyWmxOS1FkOFc1UENWQndxMTY0eS9XMXA5?= =?utf-8?B?TUZnaG9LT1ZIbWg1Yzl2Qnlub2M3NXl1NUkvbWljWlIzL3c3aDFjd1VjanVN?= =?utf-8?B?eGd3YXU4ZjZWTkNLSmc5VWdyOWJRT3NITklZcC9ONzEyTGRqSm93cldtVU8x?= =?utf-8?B?aHp0cXZiK1NlWG9kQmYxdmRiTDRJYks4VnJKbWdaajMwS1NBenBBVHJNZFZi?= =?utf-8?B?eGJiTVBmTkZLYW9NQmlwMkJDUDY2WjVOMHpEUEJLaXpxWnBMb09ML0R0ZmVB?= =?utf-8?B?N0FaZ2MwMlhsZWZYd01pVjArS3pSMWpZZENxeU12b0JUR1lkaUxjZS8vdTdD?= =?utf-8?B?N0RVK1dOVnVoTklIQ0VKM21XVkRhaEZwN3hlaDJjNkxwblpxL1J2djUxc2dN?= =?utf-8?B?OGV6VW5BT05oaUs5UjY0Y1dmY1VmeGZwWDV0V3RoTW5jQ1BrQ2xUVTA2ejBC?= =?utf-8?B?c1FsVGRwZUlZYk11ZEQzUUtUQlV1SzdFcElKYS9XYTc3blNDMnJMTFN5WkdV?= =?utf-8?B?VDkwRDR6R3Zvak5CK2ZEUXpkNGFBL1E4MW1Cd3JZWkh3eWRuSU8rSDhjcHNQ?= =?utf-8?B?R2czSVFQdnMvVURFQisxaTJpcm9rTm8wWHM4S3dyYS9qaUs4ZEtWbTk4bFJT?= =?utf-8?B?S2FuVG93ZnlXR05abDlITmg4ZE8wUnFlczZMQnJYWmVhWERJUFpHd3JuOXZ3?= =?utf-8?B?ZFBsWFFoK085RmcxbjQ1dW5Tak1hZ3hZMXRNYW9lTUNUMXhaWEtkbHVLa1VI?= =?utf-8?B?NGM4eGU5eWt0RHNYLy9TdDAxdkRtK2QzZjlpcUVmSlIrbmx6bjVXemI4eDZl?= =?utf-8?B?VFVwSDdjQmhUMVFqaE5IZW52dXpaVkNKbWd4dVkvOUpQZG1UWVo0YlRZUEFP?= =?utf-8?B?VVlXYkhZY2JBMlppTWpjd0F2NDliakdub2tDZTh4WmNSU051TnU2d1ZHZVI3?= =?utf-8?B?eFlYeEVYZ1I3WnQyZU0yUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6aca238a-5e58-472b-ac5c-08ddba65dd89 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2025 19:14:43.4398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0385 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/smacker: Check input before allocation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: Timeout > Fixes: 421650030/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-6144441767493632 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/smacker.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c > index bd08bc7be28..99009bfd361 100644 > --- a/libavcodec/smacker.c > +++ b/libavcodec/smacker.c > @@ -662,6 +662,10 @@ static int smka_decode_frame(AVCodecContext *avctx, AVFrame *frame, > } else > values[i] = h.entries[0].value; > } > + if (get_bits_left(&gb) < (stereo+1) * (bits+1) * 8) { > + ret = AVERROR_INVALIDDATA; > + goto error; > + } > > if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) > return ret; What about constant output (which you even optimized in 08e82e5b572b440f4faf160d2eac923ca47a59f8)? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".