Re: [FFmpeg-devel] [PATCH 2/7] lavc/options: properly init AVCodecContext.colorspace

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/7] lavc/options: properly init AVCodecContext.colorspace
Date: Wed, 11 Oct 2023 17:44:49 +0200
Message-ID: <AS8P250MB07444036912D20EC789891118FCCA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20231011150848.117897-3-ffmpeg@haasn.xyz>

Niklas Haas:
> From: Niklas Haas <git@haasn.dev>
> 
> This currently defaults to AVCOL_SPC_RGB, but it should properly default
> to AVCOL_SPC_UNSPECIFIED, following the logic of the other fields.
> ---
>  libavcodec/options.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/options.c b/libavcodec/options.c
> index a9b35ee1c3..c39218d7fb 100644
> --- a/libavcodec/options.c
> +++ b/libavcodec/options.c
> @@ -123,6 +123,7 @@ static int init_context_defaults(AVCodecContext *s, const AVCodec *codec)
>      s->pix_fmt             = AV_PIX_FMT_NONE;
>      s->sw_pix_fmt          = AV_PIX_FMT_NONE;
>      s->sample_fmt          = AV_SAMPLE_FMT_NONE;
> +    s->colorspace          = AVCOL_SPC_UNSPECIFIED;
>  
>  #if FF_API_REORDERED_OPAQUE
>  FF_DISABLE_DEPRECATION_WARNINGS

This is wrong; the default value of colorspace is AVCOL_SPC_UNSPECIFIED:
{"colorspace", "color space", OFFSET(colorspace), AV_OPT_TYPE_INT, {.i64
= AVCOL_SPC_UNSPECIFIED }, 0, INT_MAX, V|E|D, "colorspace_type"},

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".