From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 94A29497F0 for ; Mon, 20 May 2024 09:33:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04DE468D164; Mon, 20 May 2024 12:33:55 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2092.outbound.protection.outlook.com [40.92.48.92]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A859468AD99 for ; Mon, 20 May 2024 12:33:48 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k1Db0Iymb3w7NCQLFM/94zDTUcOoyWZzu+CFs2bshtdmy0g50HRR62j4LX1cH3thrrJdZA2/7wUlgswMyr14S0gSANFjjGtvH4WvtJxnbBQ/20Xg+Whfd2i0r9lmyFKemRVg8xUnwh/ZO2jS1UKQX3EqIJc5Wvoc3CERan949nx5iZgexh/zV+JzmRN0NdXXKlNpbxfJiNRfdy0/MJBEXQk4u6vppPD3rPfryP5V5M9/wBXuZP92gqR6PVNJ4rPQyaCWk1EaQJBIALJWJ+NMhiQ8I+oJle2Vh/aXG7HNV0wGUDHscIzgKdufm83Mr6bN56swti6JLPIGHm+bgOa3kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LdiIDbvLBN7HbuYiRuOAMc/7bpl6+KMRyr1q9fpKEso=; b=h3L5x5WYZfP7Jf04FwR6ouQcPf18rtHBE9GH87QUMVW8DmS9TFDL2ADwJRKAzAZlkdv+HO5DdO+m1hnC1YB+zSuujlbxE99+EFP33bv71/2Bk4E4bAeQMzF6FrqgRolykNU8b0iJqJB3xKTcEZ2Pf1Q8Zx5mD/9ngf93zj7tv8EEUnyJLs1JKUmKg7pgFLvqJ1OYvF8keCOmxwWs88tCCW8ckHIvQfm6ljKP9PX0uC4KIJFmEm42S5Oiciyeba9gwZB8kAyyX9MdftAypC79MJsEnDB1kwg69+SbcIbkJ6arZeMckSuUx/cEeUjFjBHGmzRqmjReiybN9Qt5uq/W1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LdiIDbvLBN7HbuYiRuOAMc/7bpl6+KMRyr1q9fpKEso=; b=n9o1FQEdVy6plcsa2RHevbqzWg1ytGe8k5HX/FExwxfV5RpgemHzMJXp/gjVEYfcXTblEEDh2xyGgZJevUCYBC4OigD4L9h1FmpToPDcn83wMAl4Kp8JbbG2JTB9ErCz/z0Qic1uCpCKW1P1ZlKIg8Ex+6euxMk6zoM1df0vq3xeIGzY1F+ZBeJ14CH7dcgyRFhLz4MJSFIyT5qGQtq13cRWFZNIpCBrbIt7z/t/i889UDifsHAEu5tUXyr0OSIeoW2CouRKNXT9Mcw/CJtDWArIuJBMghwZaBhW0LgorKTEazzIG3AbHtH+hl4+495xMNDUy2mgAfj7ppRB3UwytQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0375.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 09:33:43 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Mon, 20 May 2024 09:33:43 +0000 Message-ID: Date: Mon, 20 May 2024 11:33:41 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240520021944.361686-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240520021944.361686-1-michael@niedermayer.cc> X-TMN: [FSA21rmtyZD5G8ORcdjPboCS4bkyKiQZbfFBfOOdaOY=] X-ClientProxiedBy: ZR2P278CA0041.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::10) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <128f366b-4650-4c57-b1eb-0007d045f1af@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0375:EE_ X-MS-Office365-Filtering-Correlation-Id: 5160a7fd-e392-4444-d518-08dc78aff083 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|3412199016|440099019; X-Microsoft-Antispam-Message-Info: TqHb/iJ5GJRDiHUBzmomUu8bIMtYegGGekh6bfo2kUNrbxBluxUvO36OmwuiWE1Da2nx6WoSVdpi5YVjwGF7mYbrx31cmd0bHOrgy/TK2js/pz0UidVcsxjUHKbka02uEiFHAxjAv9WiZuEd4zInS1Q3soglayUBb1bUYQUQ5Wkj5+eouEdcjFr6mi9BDsiJZ2IH9vJY0kJ3Kp1coLQxzYHIo7VAIL5JVMQq0TCxVXR3dk/F6OXCyZr7cavHa1sqDLXkvcWUewW3UIIWziky0wIOHYy7tw8OByKJNX/9BDTG5xGsbAe+YEOp3SbGWbfnNv/S3iRPrZ18uMUJVeqHyet7HdJnbPIAEpMUMFjdM5SdFgNPeWGjtxxLf2DqXhfRYw8c/eJILV6/NyEAjwyqRfu+1aT3luZHbucDKrzteEx7V+G9U8CV0bqQx8nCz3/r6eUm3vk0K2wl0yccJq5T0x5kDYm43Lvk1LMtxyzh0FBl1ZHxA1dRaswxmfen6Vo1LqxjV3rx/kwqUqy55bqOYkzxFCp4Zyd5GSM+G8WPdw2N02SAZltWy6pep82hcwC2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkZtTXpod2FFdk5VdjdqTHdaajloOEpUbVhGcFpNaXhCTzRwTmwyYkNyNzdM?= =?utf-8?B?SmVEYUtieG10TDNrWndHd0JjRlZBWHpxYXgxSXlDM0djTm1neGlGUEV2UHgw?= =?utf-8?B?OHQ0RDk2bUMvekw2ZWwxV0hFZHpTSjlOeDR3ZmlnN1RzVjVtRHV0VmgzUGk5?= =?utf-8?B?UndYTk44MXUrQnlwNm9xL3g4U1FpQ3pldGRQVW9ZVSs0c0FjRlhiYk9FUnZP?= =?utf-8?B?T1VkdURvZDcwQ2FmbGdkTjZQb2hrVHdoL0loTHgxTnJXYkpxZjM1cS9nYlVa?= =?utf-8?B?NW9oRFMwTjNQQ3VHQ25TL2o2c1I3MWZleHB6emNXQUtpamRRSmpOWGlOYXdB?= =?utf-8?B?TmMrZWlaZTZHUGpaMkR2ODBRRk15TmR4VlBBRlVyWFdaV2hLK0w3emlLZW5p?= =?utf-8?B?bnZvRWFXOVN2SDN3Nkcycm5hOW0yUDZkbU1DTlF3SlVaeXFmRHJGcG4zVEcv?= =?utf-8?B?TXdOYnVzeUY2TStVZ25SZ2pzcC9PRFF5WjlyWGVXR3hyNGV0OXhlc0owdmRp?= =?utf-8?B?dW9rWlprS1k5bEdlT1BzcTJvKzZiYVpDeHloekcxMm5NaEIvYzdxdDJwRXBx?= =?utf-8?B?OGRKNjBiVTdkeVplcDhDNUFBamtKQmtBRzBaL3RBMUhRSGZLZWdXQUlrNUNY?= =?utf-8?B?MmhsbVA1Q1M5SWVRV1lUOFBic0t6L3R6NGwySUcydUk1cFlDcTFKNXVwSS9v?= =?utf-8?B?dXlFcUZSMHVtN1EzZXF6WnBwZ3J0RVdBTGYxUE50ZUFWQ2R0c1BNVzR4MGxR?= =?utf-8?B?WWQzdFZlWUI5czlubzBKam96TityMTVhbDhIN1ZwQkViM1BuMjV6eDhtNHIy?= =?utf-8?B?UGM2NVZ5R2pPMExHemZGVWpHTkRjdG5yNU45VDBxY2hhbTF5ck80WTQ4eWll?= =?utf-8?B?eFA3MmRldTFjWW5wc2lCYmcyWG9ZbE5Ua1U4ODVpc3JMMlpWV1RDK0h0c0FG?= =?utf-8?B?cjh6QWwreGhQWEJDNW9VenowbmNlMExqMHpCaVF2ZnY0OGkwTmhoNVQxV3ho?= =?utf-8?B?Vit6QWxZY3dSZTVYWVJwVnR2Q1QyQ0drK0E3dGVJV0J3N2llYVlhQkZDczZH?= =?utf-8?B?VEI5YVhKdHd2RElJdWhLZkRyRk1PamY0OStaZVBQOG5iNlVkUzQ0cS90SjFS?= =?utf-8?B?bmxaQ0l5dlVvbFFjRG15aVBkNXdjYVdWTG1pR2dOYnM2aTlCWm1zV3hwYmMy?= =?utf-8?B?cEFNWnFjMnB6emhkSzZhbG5mL2F2T1pBSXJJSTZUbUZUS0thZWxkL3NZemxi?= =?utf-8?B?Z0dhVkNjQjdsampDOW5vOHZYTlB1YStsUVVzVlFYelRMNGw0R0R1OXU3KzIy?= =?utf-8?B?MXg3Y3dJN1Y0bndKZ21NSWJxaVJWNml2ZXN4MTY1WE9GeFYrZ3NHdWpyYlRG?= =?utf-8?B?Ym40cWdMN09KTktEOFJrMis4Zk9GdVNFcWFjeHJOVVlvbW5uUTIrM1h1OElM?= =?utf-8?B?Q1FHK0psVThRWmFVYnJ5U1lzaEpweklOdjRYYTdEb0tPTkp1L0UvUGIwZnJo?= =?utf-8?B?LzVoVmpGQm9OaHlwZlVwWFNFUUVPNGF1cjRQRTNZcjZ0TTJGeTNxV1lGQlhy?= =?utf-8?B?ZGJsWCtIb3BHNFp5Yjg4SHlIakJDUk1jT29tZXZ5TzJnY0JJcGZwUWxYUkMz?= =?utf-8?B?UVc5enM1amlST0VuS0xPaWZKZXpaaE40QnloWGY0cFdFNkFscExKeWdsRWpz?= =?utf-8?B?VDFDNndXZktRcENoU21XSkxBaFh5UUN1R3JMMXRmYTlGMUU4Y3FoSVd3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5160a7fd-e392-4444-d518-08dc78aff083 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 09:33:43.2305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0375 Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Fixes: CID1583742 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavutil/hwcontext_drm.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavutil/hwcontext_drm.c b/libavutil/hwcontext_drm.c > index 0847db09a08..e080c0597b8 100644 > --- a/libavutil/hwcontext_drm.c > +++ b/libavutil/hwcontext_drm.c > @@ -166,7 +166,10 @@ static int drm_map_frame(AVHWFramesContext *hwfc, > #if HAVE_LINUX_DMA_BUF_H > /* We're not checking for errors here because the kernel may not > * support the ioctl, in which case its okay to carry on */ > - ioctl(desc->objects[i].fd, DMA_BUF_IOCTL_SYNC, &sync_start); > + if (ioctl(desc->objects[i].fd, DMA_BUF_IOCTL_SYNC, &sync_start) == -1) { > + err = AVERROR(errno); > + goto fail; > + } > #endif > } > map->nb_regions = i; Did you read the comment above the code? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".