Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure
Date: Mon, 20 May 2024 11:33:41 +0200
Message-ID: <AS8P250MB07443C6643E041DBB5F4D8A08FE92@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240520021944.361686-1-michael@niedermayer.cc>

Michael Niedermayer:
> Fixes: CID1583742 Unchecked return value
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavutil/hwcontext_drm.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/hwcontext_drm.c b/libavutil/hwcontext_drm.c
> index 0847db09a08..e080c0597b8 100644
> --- a/libavutil/hwcontext_drm.c
> +++ b/libavutil/hwcontext_drm.c
> @@ -166,7 +166,10 @@ static int drm_map_frame(AVHWFramesContext *hwfc,
>  #if HAVE_LINUX_DMA_BUF_H
>          /* We're not checking for errors here because the kernel may not
>           * support the ioctl, in which case its okay to carry on */
> -        ioctl(desc->objects[i].fd, DMA_BUF_IOCTL_SYNC, &sync_start);
> +        if (ioctl(desc->objects[i].fd, DMA_BUF_IOCTL_SYNC, &sync_start) == -1) {
> +            err = AVERROR(errno);
> +            goto fail;
> +        }
>  #endif
>      }
>      map->nb_regions = i;

Did you read the comment above the code?

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".