From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B82248EAE for ; Thu, 29 Feb 2024 09:34:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0820468D0B0; Thu, 29 Feb 2024 11:34:16 +0200 (EET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2101.outbound.protection.outlook.com [40.92.49.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BDFC568D0A6 for ; Thu, 29 Feb 2024 11:34:09 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bU+eKQQRUNpi3JrsbSfC8xLL7Jh7930v0tptc2yXzP1COaTCbNm5k8vRdiJfnxPEIM1U/pE3clmeEK+LyOYIVlu6Uzmu05SVfRthTqS9Iryw9E0Vjp5ftmZiRH1+r7Cy4Ko67KEswZEwt9CRmSgMul0w1iUXdiIBa9VKP4A/oiS5iVADP9FdpS7sjEwzvEmavtzIA2/ijBxPg3oqExF4B20JjMFTN3WxvE8te38sZ7dydRpfmc0iG31SnFIVYxQi6/q3CYU9QgG4DKi6NMWcaG4yk4UTTF2OAAgHWh6cYbguXHhFYWr0ilDQro3lpWAqQTIFNSOUzXzY42RSJ0KZqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WIga667SZH/XwEuSP2YuO9/bR3g5rlqIR9NKF8ETkng=; b=DUqFmx/r8QBuhjI56Pf4v0crXKSGcEFQKTkVmowEqu0wvcakQWo9+2O2OY39yJl1NdoEP2fB/tWnl+9jWHbxxFvaCIU+BbPaAQ5Sj5s7chbpJj66+FVKDrCrQoBNgVw7EgmXyBvqnxXgRByXOKU+vFPEuYDQbynv89NqaUEIhPeHXf/FaWe6Ck7TP36k2qz1vn/+/QGQ4WmDgkZvNtKbfpkMGQeaiXOix/GKr7s7Lxi20qs2KhLIVm0s+jYFar0/eGPuCciAUGvwsQRpnPV3dzN1PHGQwVnrpgpRdA8UJpmsSPKcbeWHyPcvovYlDUqXpIcGs7f9SebdzsO8RvmYrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WIga667SZH/XwEuSP2YuO9/bR3g5rlqIR9NKF8ETkng=; b=jn96vqkle7ousTQm5JYtsjafHzEjlS/K51PIFhVIqBDMCEW/8MUit3fAJM24oC8glOeZ1c3DpJ4su5PJINZZfoYmjrrZZ7mbpXh4bktIMVpwaN4lbZZkvhI6rH7e2ZliwmXvcX5P/ycl33zrynwSezNdqwhg7In1vbapunDesX6Me/IKgkllLpisNdPJTAp7KD/Il1Or/N7NQoFalO1iYKRWtqJG/6/WSuM1QjsEB1yeBIzMpxXcmZM3ZfgPMcjxjWBUMgNDlBq6Qjd++UlrFpfoS2lQsBvAaG10+Qc0aFBm8iY5xoU47oS5wXVzZn/9qCyu6wQmOpotywYczSKHug== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0225.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:178::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Thu, 29 Feb 2024 09:34:06 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Thu, 29 Feb 2024 09:34:06 +0000 Message-ID: Date: Thu, 29 Feb 2024 10:36:06 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [j159/I5qaRcLnMNHRzE44txL9eZPnm8sE3LrbCHsiIk=] X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0225:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f6ab3cc-4e29-498b-55fa-08dc3909930f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3ojyfVzp52ADcmtYlGw3z6PhZhRdqeva8R3iPpe6E3sSegv+qmZW38VuhML3ann68i3yaTHBSJLfSvwvaO98XcatnvIp2pofd8qCr8K0SDwFk+kWA3exBT12ED2fiQhjakRWHReWm2Ew+zfIyKSy9xNoxhJh4rYgYDaN/MYH7O4qm8G5ZCTOqtz40fbTAiCDT0SsFbkb/E+HHDLtL6DUwP8Zr7uMeAiXUvYx7GW75MeA3+8jnOaFkfoBCr25Atj/k7SwWqBWhIws06+1JeQmNmlMv63XHWZNB+bj6980W9enftEqP0RtgjCXN2K6bJtiDsme68vsGarlFFR/LSFLMpiBqoZr2vuUxdZuBjZVEdJJL9fxfHBJ2Vb17kXS1/y+j6XCdXBXIC1gbbqJ+iDI8DfhKha1w4kr0bavMOQNaNsksLrCqxeCkHPrDTz9sj6dUkKsuy1wD4P4AHEyVRkju7oRRP/Eq9r6bVNg0gRMpe5GIqPtycyDvAkU0+XGDHGaqS0v9ktSvBj6A/u9y0l18UwOQiwwZhZkjkOu97OzTeFw3ut1/voB1mZUJJRJPxiU X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3RZWU5vMjMwNFozL2NYNkJHaDR4bkRVMy9jV0xjTHRmcmc2ZzFzb1F6NEJ4?= =?utf-8?B?SWJ5c0U5WlowZXZTL1hwdzhzZmtNeTEyZmRrazlHajk2djJlblVwVks5NGNo?= =?utf-8?B?eWZWNjBFY3h4R0pCcDFaSUMzUCswa09MaU50T2VaSUhYMGIrKy9tOVJxUytv?= =?utf-8?B?VmVmTmRVM1QwSlQyNHk2QWxoRTloVmc4VDkwZWY0cU54Q1VVdVlHQ2JvQkE0?= =?utf-8?B?U09JVEU3VThudmp6all3Ly9Tby9qYTl5cmVQTytkSUJyUGV6dlRXeWZ3SmJK?= =?utf-8?B?VXZrb2kwZXFaVmVNY0hNTEI3WGc1RG1sZzE0UHV2QTA4TmQzR2FmdEpQQ0ZT?= =?utf-8?B?U05lLzZXanZyYnlGNXNCV29HOFBHY29qZnNVUGhYZmxyMmhUOUs1dXVJVjV6?= =?utf-8?B?Rk1iMWlRb2pnenFUWmZDV25mbmttc05OdWZPUTZBdE1VczYvWHgyZmFxcDJk?= =?utf-8?B?V0hBY3dmMWsxYS8yd3I2NEYxd3RUc3NLdmRtK1JHc2J4RDlnYk9acm0zM2sy?= =?utf-8?B?cTZ6TVpRSXQrTWUrVjN3YTl3M1pRYnh6UFR1YUxReVJzaWwreGZNMGFXUEdp?= =?utf-8?B?c1UyYkZVU1JpMGZRMjQvbzRSOFpHbUo0enJTNE9sSEdWeEY4VjVLYTB6K1lS?= =?utf-8?B?NHhxamVyc1BOOFRuOFVhV2JkSXJSYldKTFArR25VL3ZFQXkybSs0NE8xWHlL?= =?utf-8?B?c1Ywb2NKZmhSQmk2UVFjMWc2ZloyMlo5eStyQXk2ZUNJNkx2Q1hhdDlGZFBi?= =?utf-8?B?TUhqb3ZvZktGdTc3N2drZXNKRVI0M3lsZDNyRXNnV3hOVytyeWQrRG1BbGQr?= =?utf-8?B?QnFkcCtKM1p3VUd3MmJLSEp4UkIrTVlWdGtPUUh6c2E2eEJ5Wjc3bXlIQjBR?= =?utf-8?B?aWpLdEtibW1NcjBBNVRvVHNkM1UzVjlNVFF4OGJTWWdKZ0p5cmd3Yjhxc2RQ?= =?utf-8?B?eDYxTTdqTGhlRVl4Rjg5ZzA1UTYvbWlYcEY5T29XN01ZKzR5TWU5eS84dnpJ?= =?utf-8?B?SWUwNGc5ME1aejNLWFZUM2hNNFJndWs0RUJ6WWdqeVhwci9aQWVhZWFOSWlJ?= =?utf-8?B?Qk9lc3B3aCtJM1ptaFlvNFRwVEpacGJhRStlb0RCaUtPY2lteW9MZmM5NXdq?= =?utf-8?B?RFM4RGhqYksvYlUxTDJxUXVzSUkva3Racm9UZXp2T0tpTEpUSjRuMDZHUWZr?= =?utf-8?B?Smp6dUNZVFJOQkJmZXVwaUh5Uk1qa2ZKNFBBRVI3WENrTExLWTBRbHVPMDNs?= =?utf-8?B?RVNZU3ZZQy82WUczampwUExjYlZ3OTN2dHBLMldtdzJBRDQ5NFdYMGNDSjZQ?= =?utf-8?B?bSsza1VIN2dBLzJOcVJSb0RWbWx6RExJbHNxWDhUV2NOdVUwamlaalZqclo4?= =?utf-8?B?MmtITkxSVk5BYmpLbG9ob0dMSnNWSmZzU25XeUV1L2ZLWVlubGF2cVJQdDVN?= =?utf-8?B?VUR1c1VNeEV6SW1xRlY5czFmSHhtSUdFU3N5R2EyckVWV3JZS3ppSjdRZURx?= =?utf-8?B?RlAybndLYjhpczdGOXlJVmQybVdFNVZ2T0J2aU5OVFByZitUejN0TzByTmw1?= =?utf-8?B?YS9ZdDBnK0xHRWMrUVlCZzh5b1E3Z2thYVRBS2JScEhWem55eTVZVjI1WTJa?= =?utf-8?B?bmVzdVlCMlBqUW90clpaYi9EblZJWmNva0hpMWwydWhvczI2WFR6UXNUOUxK?= =?utf-8?B?U1dNM2xHQnNERjFHTGRvQmNVdktwakNFMVlJVWlBMWV3cENDaGJwL2R3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6ab3cc-4e29-498b-55fa-08dc3909930f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 09:34:06.6114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0225 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/refstruct: Don't use STRIDE_ALIGN for alignment X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It was always intended that the buffers returned by > RefStruct shall have the same alignment guarantees > as the buffers returned by av_malloc(); said alignment > depends upon the arch and the enabled instruction set > and the code used STRIDE_ALIGN as a proxy for this. > > Yet since 7945d30e91b96d2f4f5b612048169087d214d41e > there is a better way to get av_malloc's alignment: > ALIGN_64 in mem_internal.h. So use this. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/refstruct.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/refstruct.c b/libavcodec/refstruct.c > index 81e8c9795c..f89af156c2 100644 > --- a/libavcodec/refstruct.c > +++ b/libavcodec/refstruct.c > @@ -20,13 +20,13 @@ > #include > #include > > -#include "internal.h" > #include "refstruct.h" > > #include "libavutil/avassert.h" > #include "libavutil/error.h" > #include "libavutil/macros.h" > #include "libavutil/mem.h" > +#include "libavutil/mem_internal.h" > #include "libavutil/thread.h" > > #ifndef REFSTRUCT_CHECKED > @@ -46,9 +46,9 @@ > MKTAG('R', 'e', 'f', 'S') | (uint64_t)MKTAG('t', 'r', 'u', 'c') << 32) > > #if __STDC_VERSION__ >= 201112L && !defined(_MSC_VER) > -#define REFCOUNT_OFFSET FFALIGN(sizeof(RefCount), FFMAX3(STRIDE_ALIGN, 16, _Alignof(max_align_t))) > +#define REFCOUNT_OFFSET FFALIGN(sizeof(RefCount), FFMAX(ALIGN_64, _Alignof(max_align_t))) > #else > -#define REFCOUNT_OFFSET FFALIGN(sizeof(RefCount), FFMAX(STRIDE_ALIGN, 16)) > +#define REFCOUNT_OFFSET FFALIGN(sizeof(RefCount), ALIGN_64) > #endif > > typedef struct RefCount { Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".