From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 2/6] avcodec/tiff: Avoid duplicating strings Date: Sun, 10 Mar 2024 15:15:00 +0100 Message-ID: <AS8P250MB07443C42651DB49BC08708068F252@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) In-Reply-To: <AS8P250MB0744663E0FB85672850B8CD38F252@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/tiff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 4c7460cf41..afa1289e27 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -2028,7 +2028,8 @@ again: av_log(avctx, AV_LOG_WARNING, "Type of GeoTIFF key %d is wrong\n", s->geotags[i].key); continue; } - ret = av_dict_set(&p->metadata, keyname, s->geotags[i].val, 0); + ret = av_dict_set(&p->metadata, keyname, s->geotags[i].val, AV_DICT_DONT_STRDUP_VAL); + s->geotags[i].val = NULL; if (ret<0) { av_log(avctx, AV_LOG_ERROR, "Writing metadata with key '%s' failed\n", keyname); return ret; -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-10 14:15 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-10 14:12 [FFmpeg-devel] [PATCH 1/6] avcodec/tiff: Fix handling of av_strdup() failures Andreas Rheinhardt 2024-03-10 14:15 ` Andreas Rheinhardt [this message] 2024-03-10 15:34 ` [FFmpeg-devel] [PATCH 2/6] avcodec/tiff: Avoid duplicating strings Stefano Sabatini 2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 3/6] avcodec/tiff: Don't check before av_freep() Andreas Rheinhardt 2024-03-10 15:38 ` Stefano Sabatini 2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 4/6] avcodec/tiff: Improve inclusions Andreas Rheinhardt 2024-03-10 15:44 ` Stefano Sabatini 2024-03-10 16:06 ` Andreas Rheinhardt 2024-03-11 15:39 ` Stefano Sabatini 2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 5/6] avcodec/tiff_data: Avoid relocations for TiffGeoTagNameType Andreas Rheinhardt 2024-03-14 10:46 ` Andreas Rheinhardt 2024-03-10 14:15 ` [FFmpeg-devel] [PATCH 6/6] avcodec/tiff_data: Remove incorrect GeoTIFF entries Andreas Rheinhardt 2024-03-10 15:25 ` [FFmpeg-devel] [PATCH 1/6] avcodec/tiff: Fix handling of av_strdup() failures Stefano Sabatini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB07443C42651DB49BC08708068F252@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git