From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4AF0E49224 for ; Tue, 6 Feb 2024 10:22:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22A6968D150; Tue, 6 Feb 2024 12:22:01 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2054.outbound.protection.outlook.com [40.92.59.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6412768D14F for ; Tue, 6 Feb 2024 12:21:54 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mU7gIMHfbGv5AmC03dv1p31eTdpj84a5PetGYV7k0Ppr8Wrhs+BK/WfYVRB34HTuB441Ue86UQmqNlQqmuhfWPBX0eYMeuuKcaWhxpXI72QjLOErLiFAd1NUDScq2xWem2zcdwcV26vYQ94g3VLi+KjWEIkAOxSfU4OqT/eJS3fbcQcKGCxPOCGFj2ET8s8T45Esg86IFa7YLPty43WBWL65+4c2fWCnmr8kX9BgiM7DBkgTFXLUyyq2l2uMNgoEKNgnV1g+Qh4fNg9JiB+tBnNXUOkBepOxQWtLusY8C9h93KjB7th5QymfnZVqAuHhywPNflqzKrf7lO/W8wAyAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sys8Lc5N8quBY+Z018fldB9WpS3f/Ck4kohvDoOqWX4=; b=Mfq4cJtcS8dGTUK6H97udGIIGvkbB19krYokWAzmhHIU2uWadmAyRFOCFe/Oqk5296qpG4w9DY1iv+HA7iYbI1SLohqAQgS3/V8nrrEz5eYznCo53U2D5VjWkCKzWk3l7cLvs/CO/pQOUHho1JcYR7V0ICovB/WYOliszzC1XdVPfYFAB3DmDSuLvVWUjJ/uDLZh+LZSk7azxOVs8zFLtnV07xiK1EA8WnUHhIB/DPAZzeuzx+6W8a7dr/aqPFivFUjsR7KNLK+pp535PrYt7Me3NkaQyo0mf6S3TCJrjVgU5FcryV2uJIhA71JYPzvLFIZ6UNDLSDNwRzdkDP5+OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sys8Lc5N8quBY+Z018fldB9WpS3f/Ck4kohvDoOqWX4=; b=cECjG3XPa2mgbY2y6MeIEzQZ7ugIEPHzJgylGXkDSGDd5P8R6cjjVgVUPcu8+2QrITSGfaVuIoeSkGSnTJtk/ehoB5h9Z9OJbXkUBB0KWga2lGltydktl7uJ84hkuWem5mW80Wlhjqbz5LGGf59PQ/sm8HEesKAuxlbsJYyvu48vonJ4vN1CGo7lvZ3mqfiY3bKbhhCC9o30kNBZBffLPKv+xZwqFD17nX5bFBkQewA1r9VTi+F29Znb/Q87ZJRJSSSeNBfOUzHlMJXp7lfvXUoluVL79u6DtbFE3PpL7J5tBypIOA+ulChbiHNKVdzxqXCEmDHDrcvHS+AvlnpqMA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0217.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:378::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 10:21:49 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7249.032; Tue, 6 Feb 2024 10:21:48 +0000 Message-ID: Date: Tue, 6 Feb 2024 11:23:42 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240206101552.28897-1-post@frankplowman.com> From: Andreas Rheinhardt In-Reply-To: <20240206101552.28897-1-post@frankplowman.com> X-TMN: [6+IBEDK5MsyD2xThsC1bKKHF22TlcZfBStpi9HGGFUc=] X-ClientProxiedBy: ZR0P278CA0075.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <4a05a2a0-e381-4bd6-b47e-d485838bc979@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0217:EE_ X-MS-Office365-Filtering-Correlation-Id: e5269db2-2369-4069-1349-08dc26fd6d62 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqmcPDF1KAd/mmqN5uWR7ypSnuENlYOClmt8loImjMoJMafytriFlGRmP00kOzFykpPiyKVqd9XWsql5hY0hqG+UmVFuv4m/NtjRFoEE1LVPJ3cdrToqcmlBpWz1L8eqC8EvHzbaGDxvgl8KcNBh/EXhGxZEtypA44D+Gy1EETYGKl9ZRCbZ54BGHyLFg8c56a2EBCFxqICX+pkmp+xmPCr75TkksmhR1BdEumehCT9ZnYx/rIG6DMPL8oHJYGqjYO/h3e7WY7I9PjHT6iveVC6f7RELKVluo8p8JEHEYBc76g1twjRfIhH06xHLbuOc5gLb8VjIzYu0e27N4K/RQNTYsTBINRFBSGGL7KQIfeedpsm9oFtX1QCGVsMK4U13xJ3qTeGHCEntftAVz9D5RqlTIKURTiBcEoajcq3EI0/6lUpSAExbnkrVMAMVbnVz69dyq5SwM438220NyPvE7Hqca8PKCTjl77QHgINkZDJv/zlOGj9oA8GZ+GaAcrRLGUJaaBVmTA/QXh1TLnY8xyCSQEiMrbZqOKDgo2zz0wbOHgdMevd8DjKO8WC8SiSzAzyspgHkF7tdvL3NHOKlSafTv+Le+xksIB3tBPOorTXlRPuE/fiT5wWjrWDH8a5zVA46blmsNORv0xzmmdubjSjBLDldNu0nOJFHnS0HhcFsRH580/nhGeeawt3bJlKoFkh0FyaMr3L8SwgIM8zLogOyC0vp76EzRYGF8GFEneEyCul6KYkypKWYBbGK07sxD0= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hwxPD4zk7jKcVQb+UFvqkGWvJpQ/Y5CNZaxE6KlC+tdXXrzIoXaSiVgBi1SV5ZQpFue4kjJhR16KsCAAanm2sOobbCY8uMgCQE3qbgndSEowm9NRoItl9xZE0uIRMZAxffgzMldvy1KAzT5G12A203OeZkHThL70TuamxzoN6TUcuo8ZgPP2uU0R2D3EwxXW0horElMy5ICLrKBSlKhu0Gymop53A7EkaQ8F+098xdnlp8BjrXLNFYHouQ1V+KcjSksDUB1rePI4onjgp5j/ifHmgXdVTlcxJ0zjaZZ7MISSu7IHyZAZminnggoEosX2kmCPfhPJs08JYTrl01TfUVxQkRO8+d1vSS9BRmgthiu7sGkUzEvNo+3O3Ka2ybcbb+Iz+Ekan2vvdM43RdRU3zIjxW0SpmUO8DgAAqewcq+vvDcy+0KajW3RjA+i+ClQV12+gEPKNrzu1+PtjN8JG1RO/HmaZ+iadlvn/1+jy2D70rVywHEgWR0oozcSn50Nj0Pcofo9TaMzQiKYlI8wNhRgN1ptJYcjrz1g4vqEGOWKiw973Mf+dwfD7NH7C0uZ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WCs4KzlHYTFYa2lzVXdObVA4VGUwR3VnZXUvNjByWE5ORWx3eG1jS3VnQXNH?= =?utf-8?B?dXpjWTY4aWxyemFRTjRqTDVueSs4ODRPaHphc1d2T2xLVWtsQ2p5WElvVnh4?= =?utf-8?B?ZDF5Y1c0UnhsMFZPOGJEdGVIMzlzVDlvSW05RVpucEJNVGJ1UisyNGhBK0FD?= =?utf-8?B?amh0YWs1ZEp3TDB6UU5ydlNkeU1kUXZmcDgyc2NZdDZxWlFHLzJ3UmRQN1c3?= =?utf-8?B?RW10QlpaTWJ0bkJXOVFEVmpuRzg2VDh4elB2WmlXKzNqYzZHd05ONDVxNndV?= =?utf-8?B?V3daMkNwbHBxS3ZuTml3U2o2b2RiZG9uVUtUdUx2ZVpWaHJUcjU5cXBta2FN?= =?utf-8?B?K2NNbzdPWGhuVDRiVXFlckxPTmN4d1Y5UVhJRGRhVE1UUzVyTFZrYWdGbTlm?= =?utf-8?B?QUhibEhKVHNZVjJLd0FjclRONVpNRGRuUW1EZ1BpaXRETVZaYUZLMitNbHhX?= =?utf-8?B?b241bFJ0a1RGcmM3WlF4R01vQlBndlplMVo1eHAwZythOFU3RGRzdjczSnZJ?= =?utf-8?B?Rm93U1pJNEV4WGdJeXZSOWVwT0QwdXp1cDFPNmdtY2hGZmV1QVY1ZWxQZy9L?= =?utf-8?B?VnJJejM5QThYd282MDJLRkMzM3BoTXVOdVdFbmg1QS81b2VsaUd3dHF5ODg4?= =?utf-8?B?TGZTLzZTMy9EM1BJeEtYVDBPQmtJWU5yMjBuRzVmRGJLdzhIT254eTQ4Um9E?= =?utf-8?B?eGlCYW5xOStaZmpQNi84a0hybWhMWmQ5YkNuQnhId1RkNDgzV1p1MCs1NkM1?= =?utf-8?B?N0VNK3M3VWZXSmEvMU1CTDIvRVBXWWd3bDZTcU9HcUw4T2ZEaXVpeGJsQjBN?= =?utf-8?B?ZG50TUZWcWw1aGlsSEhrWjhRS0gvTkdGNmNFOFFtZm05bkFKeWkwLytCOEY0?= =?utf-8?B?TDZOZVFaMDFGWS9GUFIxRHpxVEFMVTZWRnNVZ21ZMktzUzdiV2FUUkt0WDZm?= =?utf-8?B?MXB1T0ZoWkt6YkxSdHZpVytzL2hLMjZKOE1xYkhydUdyNnM5MzdFUlFuVWxW?= =?utf-8?B?ZG5QRVphRUpUL3JKRVNlQnExTW8zaGhVMVVuT1hOMUxWS2xLa1F5bUw2TDdI?= =?utf-8?B?UFYvSzhvTVJXWWlwTVAwUlZCd2llWEhFSXN6Zit3ZHJsTndnZG93VDdPUk9M?= =?utf-8?B?WHIxTTBhVG9EOGY3em14em9EN1BTcnJ4NnBMcVZmNXZmOGN0WnptOUpmVkVw?= =?utf-8?B?UWY1K3JkYTFDSDJxWGo5enhsYVZCcno4MnR0ZDViL0VGM3hTd2JOdnNvVTh1?= =?utf-8?B?Z0Y1eFpJTWVER3dSSzJUc01oeUVQb1JYOHpqWEJvckd0OUtNWGtvd1hWZmZs?= =?utf-8?B?eFNBcXNLYld1LzVjaU8yQ0JuNXV3REl6U1RGTFpmTjNDaFdXeEdYazQ2R0lr?= =?utf-8?B?bGpNNlk2QUdQc2h6dFhsYlF5NWhWMm1KaVVCZFVnUkF4ZDRQRVl3eFFvaW54?= =?utf-8?B?Q2M5c1RxczdxRFFreWxTZ0xHcXE1YXlOV21GT1E4a2hDdkc3VTJUb09jKzFa?= =?utf-8?B?RmRvZkFORVNmNTdLU01sMWE4MFRSYisrbjlRa2MveVhNRnd5T1VYZEZhNk9M?= =?utf-8?B?a3NucGNCUzJMNTd4ckJxbkY5WmgwQXJ5djJtNW52SVJoL0Z4bXRneHkzK2pr?= =?utf-8?B?YU5wdU8rSDVUS3FYbm5vVDRKWmM4eFd3Qi9VTENmUlkrTHRJRkRkZG9yU095?= =?utf-8?Q?hvHZ73kwdXbOm062b434?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5269db2-2369-4069-1349-08dc26fd6d62 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 10:21:48.6416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0217 Subject: Re: [FFmpeg-devel] [PATCH] lavu/thread: Check HAVE_PTHREAD_SET_?NAME_NP is defined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: post@frankplowman.com: > From: Frank Plowman > > Check HAVE_PTHREAD_SETNAME_NP and HAVE_PTHREAD_SET_NAME_NP are defined > before using them in macro conditions. Gets rid of lots of -Wundef > warnings present when building on MacOS since > fd16d8c68cd7b820eda76c407b0645b7cf470efd. > > Signed-off-by: Frank Plowman > --- > libavutil/thread.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavutil/thread.h b/libavutil/thread.h > index 2c00c7cc35..0200b7b511 100644 > --- a/libavutil/thread.h > +++ b/libavutil/thread.h > @@ -26,7 +26,9 @@ > > #if HAVE_PRCTL > #include > -#elif (HAVE_PTHREAD_SETNAME_NP || HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_NP_H > +#elif ((defined(HAVE_PTHREAD_SETNAME_NP) && HAVE_PTHREAD_SETNAME_NP) \ > + || (defined(HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_SET_NAME_NP)) \ > + && HAVE_PTHREAD_NP_H > #include > #endif > > @@ -219,7 +221,7 @@ static inline int ff_thread_setname(const char *name) > > #if HAVE_PRCTL > ret = AVERROR(prctl(PR_SET_NAME, name)); > -#elif HAVE_PTHREAD_SETNAME_NP > +#elif defined(HAVE_PTHREAD_SETNAME_NP) && HAVE_PTHREAD_SETNAME_NP > #if defined(__APPLE__) > ret = AVERROR(pthread_setname_np(name)); > #elif defined(__NetBSD__) > @@ -227,7 +229,7 @@ static inline int ff_thread_setname(const char *name) > #else > ret = AVERROR(pthread_setname_np(pthread_self(), name)); > #endif > -#elif HAVE_PTHREAD_SET_NAME_NP > +#elif defined(HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_SET_NAME_NP > pthread_set_name_np(pthread_self(), name); > #else > ret = AVERROR(ENOSYS); You need to rerun configure. Since fd16d8c68cd7b820eda76c407b0645b7cf470efd running configure will add HAVE_PTHREAD_SET_NAME_NP and HAVE_PTHREAD_SETNAME_NP to your config.h file. - Andreas PS: There is actually a different problem with this: In file included from ./libavutil/common.h:88, from ./libavutil/avutil.h:301, from ./libavutil/opt.h:31, from libavdevice/sdl2.c:31: ./config.h:340: warning: "HAVE_PTHREAD_SETNAME_NP" redefined 340 | #define HAVE_PTHREAD_SETNAME_NP 0 | In file included from /usr/include/SDL2/SDL_config.h:4, from /usr/include/SDL2/SDL_stdinc.h:31, from /usr/include/SDL2/SDL_main.h:25, from /usr/include/SDL2/SDL.h:32, from libavdevice/sdl2.c:26: /usr/include/x86_64-linux-gnu/SDL2/_real_SDL_config.h:205: note: this is the location of the previous definition 205 | #define HAVE_PTHREAD_SETNAME_NP 1 | _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".