From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B07D649E7E for ; Wed, 15 May 2024 11:00:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F0EA168D6B5; Wed, 15 May 2024 14:00:31 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2064.outbound.protection.outlook.com [40.92.89.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 92C8868D366 for ; Wed, 15 May 2024 14:00:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kAiu7E1Po7vErIpJamzQUP0yU0MJe1+Q1mhpxqtWld7o4Zp74H6bdDgHCBkqt2sxbv5nQ7a20JUraOV0Ce1SJtMrbCqvzNdZm1SEo2nW4w6QwO/vKxdsVvOuHSbwsQ0CHGP4tYEJnFvBG05JrEc6tMxVLoi+KBn7l0NlMx0uROvQHdZeGl/RNHRuGrdSDqB+aoiL1+T8J2a40KCchZvEtpdat30HXa1arleY7Xy1/iQiICPBGufx+td5iGKBE+9AJAGiWx0JRVKT1v9Dori5lB9GpbKRflzFs6IEQlLAzeuUyFGkM9+oWdd/jyNrWk7//kKS8RTIkOqmaX4sdOX5aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bTnw7dO4EGwOFsbeqVDej9cx3mwSG9BzWASL9LgbEpI=; b=f3m+j5ziCnJYUruthWt+OGmmWRtUlXOpGihwl2m5SQo3w+Pzq3Um1em08KTDoBRHIDKjsvIPKYPoaG/3MUj3fb6Bf35QZHHrkPeQkS/IO/5SZjacOo/dbpBsscsCTAizs9CNkk9+ksxVG+gg7v6SeZSMwO1mlm0BtutqZqK3itb/ENMlYNUBouLvIm1p80OAOVpRkrBsZDiZuXhVUdTExfHDvpDdlMd3zaLCVfTN/yKnUd+VSr4NluQwQKS0nQ2Cpoo0SnwKs2xZ4XM2cB5h+NVPhZQPNJv8RQinykakVPJXRuVjnDMOE7xOpv3FA0B9SuVWY40iiv/vNRNpGV9GiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bTnw7dO4EGwOFsbeqVDej9cx3mwSG9BzWASL9LgbEpI=; b=sC34JlkeMqZyE0AHdxCQZnau4tY3GSuLWorNflArlDHRR42dID2lljkQCxcvXmMNYaRgoQ3Kd9bZuT64gm/e3QQ79jZKNJQlkKLB5WJjSLtPUWdtIsfG4/EqYp0dWsMvP1WPnV69ISlNJuCe0KKr/YdVtZtQyVScevtaQxEte+kFXncbwOzd+AqyfjsMvqVrcjdfFRDlfAqgAfte6i/NIken4fMd0wGm8aTiob6G+0948yMqDjXVGQKitAZXfXUY1P2fmizCsBIIu3wMERJ6duXLIV7vJYMy/asGsLo6X4/CEhOruGeYTU8m/UTxUze8DNkYFkbVmG4L/p93tHFCfg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0600.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:275::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Wed, 15 May 2024 11:00:23 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Wed, 15 May 2024 11:00:23 +0000 Message-ID: Date: Wed, 15 May 2024 13:00:22 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [0aBrnO9tLXb2NXLDwgFKbpai/T9qEzbPPfIlhrvzR0M=] X-ClientProxiedBy: FR4P281CA0195.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0600:EE_ X-MS-Office365-Filtering-Correlation-Id: ae469783-9811-401b-e7aa-08dc74ce380b X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: juHrXr6GsROrH6CMho/Wt54dSyE3KhtEFVEabHz21co6VkGvFWZovJqgetUY/66zVVDqcCdIQaGTCkMevYIiGbZlFglu9jWnrEYtSsCJQZysWLRayybhXzrDQMXX6Cg2PuQTmZrNWfb3UxYD5Y6e30vpsJRDi5BK8+DmywMI8PKbHcjHzwxbYWscC+GxpoLZCLxjwktIO+AAlxH44Z30VJsN2GHHai7D8AMKojE6cNzvKuSmn7K+guY/lPQQw1C7kHezzoi8LoORXh+hOoCBC69KflxeZH5msJwABhMZTphK+/TF0A6Idi/DF0uqnAvELd1V1GlS3wUptzBT9aQn52nM5LTVtIkpWmrUhNmR0wYzWaO1uge8sixLjeUwYUkPxzt7zFLG7oh8NsLL5dH4hMo/j63C6gbAGHtuuU6CWa1Z6eiQDDQPk8NgbwD8sO9uLx5U5u8lmR7xYNrUIAZN+2jP8iQqNtDrDab6cBIj8eRaZcGh1Ea5uLLNfQ2ehY+AhY6hNpKjNvkfjaWgFN5/6NHgCLKwF5kTpjPD6HRf5rTQA52NJ5h+LW8LYgSVnFvL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODFteEJXMmtKOFc5emY2dmtwb2t5SGNybytRajdpdUZwdjZlTzF1YW5wam5v?= =?utf-8?B?bldaQWV1WXM5U3FxNmc2eDZpQ3ZzVUhqemQ1VnpHTnpIcnhtQythZEJpQXFU?= =?utf-8?B?b1BBWFV6YkZsZFZsc1pGNEN2Q0tSU2VicFJPVksvZUl3ZTZ2WnI1eUNUVmJj?= =?utf-8?B?WE1iQnJ2dlAvK2NQd0YzVHc3TXl5UnNncS8xdW1qdXo4clFhOGJoTkpvSDY3?= =?utf-8?B?M3ZNQ0t6SW9NVzg5QjFnQ3puN0dUemdvYmNQT3hULysva2tPbE5IckZNY2hY?= =?utf-8?B?RkdkZ3l6YjJJV0lFMkV6eHFjd3BvVklXeXh2d1o1K1VPdzN0RjBqbkhXSUty?= =?utf-8?B?M0VJYUtQMDIvVGVpamxoeFVVUnRxTlZWdHNFbHFYdWwvZXFFUTFuREhUR0tL?= =?utf-8?B?MWs2cUJhTU5HdVVaRFNBeDRPcGkxOTVEVnpWZUF0anBGL2xPV21NQWM5VUpS?= =?utf-8?B?dWlGZEN0YUlkWVgrSGpKaWZDRE5CT0JHMXczSTU0SHBLNGZYanZucWJHS0hG?= =?utf-8?B?blNhaGtVaXFoTkY2a05ZTjdGYi92ZDRPeXJKbDM0OVEySmw1K1BxMGo4dU5j?= =?utf-8?B?S3NBNjY0Y08waEpLcENwNUZyWkRwTnp3Y3IwcXI3SVFXTnVrYW5XZk5nMFA2?= =?utf-8?B?a3AycDN5eWlaYXpjbGVGOC9oZTliYitzQ3FpRkYzL3Q4eXRxdFhub2VaNUN5?= =?utf-8?B?V1V2NzM0aTA5SzI1dWNJa1hOMWVtcHVSczdHTXZ6SXNNdmg4ZFEyTjdyVWMz?= =?utf-8?B?Vm8wNFpGaEtvdTZTZTJtU2xDTzQyUkpwcmlRZUdYL04yWFQzZmRiVVhxemFK?= =?utf-8?B?ZFJjV0hyYTgvK3pQNGRRQmVQVHZPWWtiUmtKa1FlYXhzNHN3ZzhZaUFiN2Rl?= =?utf-8?B?em0rUEZXRmd2VVFETUtEamVFYUVrNUJWNE12UmVwSGZTeTl4Q1dybTM4aU40?= =?utf-8?B?eEp0cXFuZ0UzQlZtT2xhdkRtbEkwMFczKzlUU3BXMWwrdVA5MUUvRFNVSDZy?= =?utf-8?B?eVpzTWJtYXZINkhOVWlwTlpuVE5mb0pSR21VeFZCS3NaRU1BSFpveFFxbXU5?= =?utf-8?B?R3RKQXd3bUlKSlNINXpPckMrSldnRVZPYU9JZmtyWEs4R0dKbmZuTjdVZ0VD?= =?utf-8?B?WDMxZjhIdG11VjUrZEhtL09Ra2h0RDlWWlMrWE83NXVGU1lWd0NkUVVMTWxT?= =?utf-8?B?R0U1MGhtMDJFSG14MEQrb1RjNzI4d25JeHEwV3k2R3JiNGNUMkVpU2dhU0ZU?= =?utf-8?B?RmUvWEtxVE9kbGZPRGZXeXVyODZuSnpKbkJWTkpabCtjVDNCQlFiRkFxTzlG?= =?utf-8?B?d0l4TWpLSUpFTlZVQnVmcUJKZmZscVhGT0EwVFdtSHJSSm12cXV6UFFPWlN3?= =?utf-8?B?MkJuVVNYVmd1MkQ4RmxiT0o5d2t1anVsY25qRklsbUdteTRRMTJ5VkRJUnNG?= =?utf-8?B?RHo5YnhVYzlkQjhBU0lwREhSWUJzaXdTbmh6eWRFNTJ6U1ZaTi9UV1lGOEpC?= =?utf-8?B?SW9yazl5RDZSazZ3ZG1nbk1XeU5KWDBNbVk2Wk85b0NDcjhwL1lHZ2FxMDdY?= =?utf-8?B?Rm1RMjlZWlZPVmdDQVo2Y3lMU1NJZ09uNVFQSUlxUnRtUHpuNkVpang1YWR0?= =?utf-8?B?M0NRbDhvR1BlZkEyWnVRRXBNSThuWW15dHNqNFVHdlhubGhoaDYzTmdjQU9j?= =?utf-8?B?TzVneHM1emVLMnJNck1DQ01uNGZPejFpcGxBcHR0LzZoQmR0SmQrZXlBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae469783-9811-401b-e7aa-08dc74ce380b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 11:00:23.5075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0600 Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/llauddsp: Avoid UB integer overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The only multiplicators used in scalarproduct_and_madd_* > are -1, 0 and +1. Yet it is of type int and the checkasm > test uses the complete range of int for it, leading to overflows > that don't happen for actual users. > > Fix this by using a more reasonable range for mul: Given > that it is used in v1[i] += v3[i] * mul with v1 being > a 16bit integer, it makes no sense to use values for mul > that don't fit into 16bit. > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/llauddsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/checkasm/llauddsp.c b/tests/checkasm/llauddsp.c > index e6eab589b2..969166baca 100644 > --- a/tests/checkasm/llauddsp.c > +++ b/tests/checkasm/llauddsp.c > @@ -49,7 +49,7 @@ static void check_scalarproduct_and_madd_int16(LLAudDSPContext *c) > randomize_buf(v1, BUF_SIZE); > randomize_buf(v2, BUF_SIZE); > randomize_buf(v3, BUF_SIZE); > - mul = rnd(); > + mul = (int16_t)rnd(); > > if (check_func(c->scalarproduct_and_madd_int16, > "scalarproduct_and_madd_int16")) { > @@ -84,7 +84,7 @@ static void check_scalarproduct_and_madd_int32(LLAudDSPContext *c) > randomize_buf(v1, BUF_SIZE); > randomize_buf(v2, BUF_SIZE); > randomize_buf(v3, BUF_SIZE); > - mul = rnd(); > + mul = (int16_t)rnd(); > > if (check_func(c->scalarproduct_and_madd_int32, > "scalarproduct_and_madd_int32")) { Will apply tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".