From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E108549761 for ; Sun, 19 May 2024 16:05:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B78568CD95; Sun, 19 May 2024 19:05:30 +0300 (EEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2072.outbound.protection.outlook.com [40.92.59.72]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E78D668BED3 for ; Sun, 19 May 2024 19:05:23 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzDrvfAOJ9eKmhxvACCiqX01U01NTZHB0ZSS/Xl5GVQQF+n0D8u8y/z3Wt7HJyjeXtOJVc406mhVY9VmCTPOCuG4YIQqhbcsaewTgsmmznSiC8GGppn7BMdOg0LfbNFPMIgn1zoP4SGWwrpc0xtgcNL6Pwsjhptjp6HLzx4eRGFNuyNhH7CZ5H3KlRnyfeFszz9x085GvYSoCMt5LycRd3XvKSQUZ/HT+RKmJ+C36PZNXuynRdnQsNjRDUaZ9tElhHawjN41nx30Ga35BLEnYLKp9C2a5v2nZ3ZG7pdtScaMU0YJx9k9Ibk9P+OUMH6NH5TFrhcFHaAFYCjCx5TWLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D9W5PwKiCjhiukhzR9uvhv+UqmOTRLvc+o5xXtwTZzo=; b=BtAf42k0qxQalFTGwRXixr1fxKn/FOEHLKiTk2xhX5LJjW0SgM5+qQ0O/D9F8mrP2VwQA40/lpqh8/18mQjdjPUTJg9AARosg6+IQeZa9QkQUrjKaJJVFtH/7XdkDw+9uSKcags60dC1WfXXfAJT4r5E19NQSmIgQTMmT4AMwJobxNC3AM/T9Gt1jt0JDMUMXCjHZfrLYm9bT1W+Ox6X+GWHoOp6qiMoK+4QQmQdmBTibMWJbeO+9Br/IT574n8tz/83WGz5LYXpcBuclJ13K1dpVfYU2hMBIH5981gm6P+ecim8s/nORFcB4VNW2NAC5WbjnUMVIfs3mIimkF2SEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9W5PwKiCjhiukhzR9uvhv+UqmOTRLvc+o5xXtwTZzo=; b=lxTRtcjLfjob8EVxlEZ88tI7/LBmA5RfruithONzQYO0m2PdRdEY2j5+HGub4roY6eOILVQUwn8E11SR10Xhezsu+thCpKkvr1A+39rj1D4k5cagKQl5XYJYQ8DSyf9vY3RUli0HSa4uPlN0frudBZCFbuyZyK5aNT5dsvVYQ3ufz63jUgtbduIxCVQCZAzUdQXRBZejF1DKDecwQDEoyGPki7F+q+cwxHq3zDJ1zKd6DeEo10wmpFv/QHBOzDN2SS+GIbZiADIlQosY8ZHrGPw2YvnFDmXPGgQqNGR2ggj49kwuXCKNQHZhtLPKPhxyW202gFrg2i0vYdsNt/E2IA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0591.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:27a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Sun, 19 May 2024 16:05:22 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Sun, 19 May 2024 16:05:22 +0000 Message-ID: Date: Sun, 19 May 2024 18:05:20 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240516231932.6950-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240516231932.6950-1-michael@niedermayer.cc> X-TMN: [fDUONlXjmcDz89mqCb7Y8pkVqcJ0gwbtKoTW7bWWdbs=] X-ClientProxiedBy: ZR0P278CA0200.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <458d66e8-fcb3-4a5c-8630-3817751000b7@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0591:EE_ X-MS-Office365-Filtering-Correlation-Id: fad78b0d-f0dc-4e86-3b7d-08dc781d7ce8 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: N/ywb9+7Hnn7ff8yrHmQ7XfY1TVH2cI1afFEQVcQxgd2LzDN947IhqHbaHpkdv3m5dUXZgzGiXk8HmSEda2w0hRG9ONNCiy0cuE2MyO4SYly2Y1RvDOW5DaMMBZwb7WNCmLgHktuCuSHJYio5UBkh+MEyjXXNwoQQQQ5LZqRtBJrGXgRxsMgjUDNuGS9bzTJOL2aUAft1lhZm3Oh5rOEWqSACNXgmlpR5cizNwFje4xrQO4pPKXqkoeE35/8eWWnvFGTJ2sqjo1IKNuk9rB3d5rChT128ndFIbyy+ijk218qBoOk054UQalGsMmMsPpjYOEdAPvbEMjaUltdaqXeEWKJSSG7JVyr0wDtZtjKbdjlnJYVrAgKyCP78XyDGIaMdrrPhzFTLosi/0BD2/oYJdZ2BMLGHoPn8kfoX+M9APRYHuU5fAp8V4D3ROWdN5+FvwdUuxusjlWC+YZmUmZq81QQkX/DRr+lUxjz9pjZVCBqRQRBQTE2IxokX135vE1v7vRH6/HXol7bMg1W8S1r4wVJhSt9r+AXs7qhplUUAjT40NBWUaAfqU3dXPD4KViV X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d01vM2VIeFd3T1FaUWJWci9DWTViczZmRFBDSVBWbzRGSWRLanl3SGIrcmU2?= =?utf-8?B?N2lmTmxzN3FJUVpobUlQOVJwNUJDMU1PRThvL0RqYTV5QnEzU2tBZGEwbVpB?= =?utf-8?B?MVFWRkRSZUlLQlR0MU5XUWJZQkFKbUhOU1M0STBSV1JYYXQyUE1nbFZ2UlBo?= =?utf-8?B?OXFBbEt5MzZiQVlvMFVRVmNlZW5wWVlxMThERXQ1SS91cmF4M0dYVWdZNjV1?= =?utf-8?B?bHgwb0pjeHhEakdLbG9xYmMzYXpwU3lSeDlQK09aQzlmd0R0NTlDbmhhTmVj?= =?utf-8?B?WmprNUlNVHliMXJaNGUyS1dETzNseU9TbGlhZ1FRVndMVExWWUp0U3orZmRh?= =?utf-8?B?NkVTOFExdXNoN0c3WHZySXdJYlA1aFBGREt5UUNxMDRtNG1FNHNoVk0wU0RF?= =?utf-8?B?cytBV1ZIckk1THZFeFFqdzJxTTVQNE9IUlhyRERzSmE4Q3NYam15MjFoM2dh?= =?utf-8?B?TUp1K1FmVkZqaGhYWGJ4eUQrMi9nNG1Gb292SnhQNm04NitjNkhXbjQzeDdt?= =?utf-8?B?OTJUWUNRYndoMU5wbzFlcThEb1AyTTZqaU1rd21xRG42ZmxtU0NqMFhkTGRF?= =?utf-8?B?dE5YR3pvUmh4Q3RFRnFUcVkrNndtcjd0eGNuaHFCOUQ2U01veVNHQXUzcWRV?= =?utf-8?B?Mm12bmV0Um5SZFVaSzZDY1BVWkN2cmtoNWJYYVd4QXk4RWRmSC93WFFkc0ti?= =?utf-8?B?YUtHbU5rb2JIZjc1QUNub3ZINXJ4dXJzNmdWU2UwbmNJTEh6dFFMRG5qWTh5?= =?utf-8?B?Mm92RlF3QTRnMElBanZnSW5vVm5abzg0Wks2V0JlSVBrQkxJOWtWL1B4bnhL?= =?utf-8?B?OWJjMmg3cVMybFFSVzhWdGRjQzZzVTFnMkduR0hpaGdZb2dFb2ZFaDJEM1l1?= =?utf-8?B?Vm02c0pHbFNCSnZKZXAwRXRMd3MxbXB1Yk9vdDRnYmttTmVSbEJqbkFRUUkv?= =?utf-8?B?SDY3OTZUdi9ualk2Wk9DSmxxOHN2V2VCWCswWnpxcDM0RXZ3dEZaMTZ5VzBp?= =?utf-8?B?QWFVb2swdmNETktadlZYTmI2bi96NFBYVDE1ZjVWVjBRbXFNRk1SR3U4bFdh?= =?utf-8?B?Vi9lYkJFN0V0czk4RWZuZmplRVBSQjVha1BzNWxzaW5YRVUvSDAvZG5GVDF6?= =?utf-8?B?aW5tN1V6QWxGMWlOanhvb1FBTld2RW1ERS85S3FUVnoxMUM3UUhoSUtsL2RW?= =?utf-8?B?Qm5lRGhnbThINFJvK013MHo2clpzc0dyMTlOOTZ2OGw2QXg3WkVjdEdwWXN2?= =?utf-8?B?L0xmcm51WVJ2bzlBR29XSVVxM3NKQU9TbnduVTdnbExtZDYrb2s2d216L1dB?= =?utf-8?B?Y3VGaHJ2elBmaWR0NUc3RnBGcEVvNzNZc3BRcFk1Q2hnd2gyZUtsdi9MaEw4?= =?utf-8?B?cW9YclY2MW9JSVp3Tm1kUTZTZjBlRnlzQUlRMHk1UU5tUnVjZFVzejhyY21Z?= =?utf-8?B?a1o4ZGhSaGt1TlFkYlBRWE92Q2FSTDNCL2U4RGRSSVVIMjM4SW00ZWpIc1BY?= =?utf-8?B?WVY4dGQvRlRNbUdXRmpvSUZjOXVnM3NWT2diUEZYcGhRV3BEUllHQzBYeUty?= =?utf-8?B?T0xnNFhLWS96NFdnaUtIcXBSYzBoRUpTVjhOQlVNVkV4K2xGMFhyQmYrMUxo?= =?utf-8?B?RW5uVWxUbEpEQ0pyNmZxSUppYTRxbEN3dEVQaDloY05nS0NJWEtMbFJGRzVU?= =?utf-8?B?UTNZSGQ3YWxsejVDWEhPWDZoT25pWXIva3dnWHgwZmt0ZHNDbmJYOHF3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fad78b0d-f0dc-4e86-3b7d-08dc781d7ce8 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2024 16:05:22.7017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0591 Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Helps: CID1548380 Uninitialized scalar variable > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/rv34.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c > index 23a570bb807..4ce0cc58d05 100644 > --- a/libavcodec/rv34.c > +++ b/libavcodec/rv34.c > @@ -98,6 +98,8 @@ static av_cold void rv34_gen_vlc_ext(const uint8_t *bits, int size, VLC *vlc, > uint16_t cw[MAX_VLC_SIZE]; > int maxbits; > > + av_assert0(size > 0); > + > for (int i = 0; i < size; i++) > counts[bits[i]]++; > An av_assert0 just because of Coverity? Why not av_assert1? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".