From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 69DED48BB2 for ; Tue, 6 Feb 2024 09:12:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 10BEA68D13F; Tue, 6 Feb 2024 11:12:42 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2090.outbound.protection.outlook.com [40.92.75.90]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E8FE468CA50 for ; Tue, 6 Feb 2024 11:12:35 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cyQ8B6rXbUX9eqGMZxo+9eyM066fcIXePx4+s12kBQRp7183QL0wvUuKEXnWTCLsoreG36pvdQwI3700OuWeRm7Nye3ZqpxjsCK2sZd0QyheRz6RiPb6O6a2PcRdxfCwsp0yoRPHhjtDaCbjb/GWA86VdYR/p3PSrnaxBdbIGYcOt3F51AfC9KidR9JMR0BG+mempqmt2xfs1U7vWRsqsQDi9wCRLLIKBh53DKuRtQGKFLMV4FGoShrnSX5CBCHg22wiZaMEDsKvPMEVhd5foTyh6ZTIoYPacW4np/MkWcuAQm6TUl4IUpKicMux1hRHL+psewWTAUBNKntgHSwbhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+zwcA1w1OutRzCMXGooXbq+JxsfIwia0zLW/YTmlT0w=; b=Eu3nFzKJk2qixzARuzfp7Sy1d8GWTHASmLMfmzNmUE6Fy0ReUhj3feF22khWSwwgvetve2/dytI16hU2fzf4AyCiuuuz2uBTl7FgH04N9sHJEZCykny0T83znnw38EwXQjIrDP9yxAYH5P/hn9vHeY/DKVfiNiuBrw6I7idhZ+OJ4+ryoG8vVkTxdTan+KMSoIJvCWMpGWbrvULlF7vauD0yQqhtw6/fohP5cmPjPmpoQEMgU4okQYIGHcPPQJgk80E1QyHXmotFG/CFnyvhPgL251p+pv85wFqd8I1/+rjBWZp75eBeTq4ezpG2V1wvUrSkB+pdXumJRi+gL9BOCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+zwcA1w1OutRzCMXGooXbq+JxsfIwia0zLW/YTmlT0w=; b=ecM7xdR/fPAc/1ScFeye3z41loZ33W/8mh1TtB6HvKeQGC3ISJmjiaH4vZRi7hrnEd0byJBrf3qssWN3gd9AZ46tqu7XVPmlRjsngw2+Cpz7RXZgp2PsBKrF8zK0gf2J5j6QibIlWqlg3VFGefpQLj34cP3VtZ+7imnjmTpnfxVH3FPLA14P33oyKGpNdjn89xTdvIwDkvISIrZOt8UmRxQCR802VDbzrcGcoafJ5eQKsbh+Yfd+KOQRDtJLFHmT0uPwcxpWEs/3dtUK8KjCuT+vgyGaYOS2FRD2PVoKF1YmKKq8BJ4O1cXAwJTsAAtLfh6uvRgUU+ltgR2V9jp8OQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0239.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:278::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 08:57:50 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7249.032; Tue, 6 Feb 2024 08:57:50 +0000 Message-ID: Date: Tue, 6 Feb 2024 09:59:43 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [Vj0lw9rrAkKFLX++wYBpJXFgdd5a/M1/rbsQKKkaMuw=] X-ClientProxiedBy: ZR0P278CA0171.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <2f35cc1d-7fb1-4cc9-bab2-eb0073faa5fd@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0239:EE_ X-MS-Office365-Filtering-Correlation-Id: ecf4ed4b-e0b8-4e6f-2219-08dc26f1b247 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqmcPDF1KAd/mmqN5uWR7ypV14L9K/gGU4yOpPx2od5wN0ogxjdSLDztYDifvaHCSuFOC7uPVc+SCop86BzPXZ75tcInl76mgCCiLI9BI5cl84uwLuDXPuqjYJcA+d48szcAsUsc8ObmZAdshOUpxnaStcUJeixuau7QnbNn8Ga8O6v81y1Z/22UqT0pXBGGmLm7a/XBTweOqmJe9b5VfSbqzFHpmE5thkD3z6Qq+0pI4SvOcRkdu7dcezUU420pDMq8NJ5HxRH0urp6rvhsp4Za3mZ31EJCY5TbfKetcAe9FqUCZOdNobzSKvRM1qf8BAr6EP5OEtxHrgCnzuHbER9IJZDpWayuEkU/pXdUhvnn0kdMuR1l3UdCu91gB7h4t3wuZ/W0iuMFT4MoJwpv/XXaqbZ848UtOR9Egi9VQY7x13AXZsQxNZuGY+rnULHvZa6pAPbjn0NXHEmvGuJ0QlixzwPp7z6O8QZZXN7SAKG1qr8JUhcSm5EpCKgYXNe92N1MnX8YTI/DEmWlVEPRXLtnUIvaL5/uE7Ji3bo+cnLoV3rjupC9XYQQV+/r6ETp8Qzx5xqmiglrij7Lt6bN/iFmp61cAVPP/QQlwdu5G/irVvi3DEv5PKtMOJWOQvzMWbe56PunZCMXQuLopzgfl5ICE82J/2mxhRGHGKe3LfeiyKvqoZY5psAj1drU4dUW47sozRzNIH/f6eHekJmOx8Fq8YUWDIO9rfJvaJ8ajLaya96RQcFnGXi04bxG/9Wn4E= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zDdPIlFlfl5ZZZ0UGZVdSG8kSjdUZTWl8vm5PLEob2i8Y+5/IVN4Eq8RzWz8d9UXZLa4201F93KQCWbqiLyU3xpAlvQuDk8SKiPsB96otwXTYcqMISNpFgdLO4gPA82uod+68bpnuhUex1c8aPgANUkzW0w4K5VDttpGaODxid0ARFSiky+wa3J8kSqCxXjnkob/j0G23yBSsTp2lul9IZdJxbPP3R/D5DNFqznKDYiFavyadgAde74KU+66fyVe9vwzqW4mXzcutJOxsDOOHTttKu2yetBcc954qemcFbbeDNcGa11r10fv51BuIlD3Q8+X5ToXWWr8G9uKz549F2ykzqlsRVeutwBAue12ET1LmiEjvVJz6y7O3Ab1C2gyIo1mOdOvhejpp30B9wTQWmOQFGNgqzlaTfPG4bIujZXasND7brPPGu5x5Vyhp+g3N3yDYO3ByLpHvumRm93/Txr0Fs3l9WIMhMsPWVWyoUB87PcmoykT+SEEs9yNYQj24hUFVyMbO03AqAMsU9TWKWKBmvo6u/d3dequVi/349dBAu1g+niFx8QMe0E5x+sx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDFiT1JUU1dGeHM0SVB4dzh3aVYzdlZMWmR3NUVqZjNsZnk3cVV1TUZLKzF0?= =?utf-8?B?V2VnbXFOVmFtYUlKSkN5emx6cktDcEVGK3BYUGo5UXRFbG40aXF1R0ZEQmVp?= =?utf-8?B?eWNScE9tYy9yaU9rMEl4ZkgvTC9rcG43M3VPWTJQaWk0MHpuU0orZFhVSmtx?= =?utf-8?B?VEJJa3hHSC9Oa0VUTDBxSENISGxQMGJwTC9lR3pTQ3g2RzR4WnhqaVpHdDJW?= =?utf-8?B?VUE0SFZ2Q0o0ajhIRks1Y0xUNlNnQ1M1UUl6dVVhaURlNXBxZlQ0ekZuUlc3?= =?utf-8?B?cUI0MVhGV0FNdlpaKy9xb01SQTZSMDhiS1YrTElnVnBNbkRtMVlkbVdQT1h5?= =?utf-8?B?b21mS1U0NHU0R1Z5TTE1YzY3dFBnblBML0NqQ0xQdEFNUUN5V1VnblFBdTJr?= =?utf-8?B?RHhvYmZOVXEyREZpTmFrZVFGbkdJb0huV3JaSlducmFhY1FaSTY0UXQ3OFFG?= =?utf-8?B?NENKMDdNbGE3TmFUQ0FwaU1WT3d5M1NhZDhxd2M4ek9mL3lXcExJSmdqb000?= =?utf-8?B?cFlUdDk3elM0VUlwcUdIUS92WnJzcnEvTEJ5QmNHVEEzc3Y2TlcxOHBTNm5B?= =?utf-8?B?cjI0TVdRUXF3MUhXdGppVWNkOHNKVXA0Z0ZCL1I3TUdVMUdiUEwwSjJ6YUpx?= =?utf-8?B?eGRUVElndEhKV1V0VzBpSWVIdC9LQUprTmJTem54UnhKaVE3c0dReXlQRnhv?= =?utf-8?B?N1REczJ1SWR4TDBWNHdubmhVeTZaNDYxVE40cGdEalAvUHZhWU1KUmg3dWQ3?= =?utf-8?B?TjExcitaUGczVFNZdm9zRTlpcXNKdklYN1JmN284YWNYaEFCVVZSM2JrQzY3?= =?utf-8?B?UGt0ckhJOU1EMnNlL2dmblRZVmJxVURTRUY4dzhjRlZLa3d3VW5Va1dqREl0?= =?utf-8?B?N05UUGlqUEd5ajMrQjBxV29QbnVnYVB1Ym13UHJyNzUrcmEwbVFCaW5nNFJp?= =?utf-8?B?ajZHWlFhMnU4dENRaVJVQ0h0MVhjSm1TeStlWjdzVy9MTGVUQU1FZ00xdXFI?= =?utf-8?B?dkdKbmJrdEVZaFJxNlIzcEdTSHh3NXJycXZVNjZoYkdQVFU5KzhoMGtHQks0?= =?utf-8?B?SDBHdHlOYmJRNWZEa0xuWWFJc0Z3OVIzajRpTUc1WHFiNXVUODE4d1VRV2Zu?= =?utf-8?B?VmxqMnB1eVBVQUlnWWR1cWZ6SUdKajdTM1gyTUh1Z0g1d1M5aXhURGEyZGI3?= =?utf-8?B?UnFPdGdRUFBaTkF2M2FJNmEzd0c4a2FzRlpYb1ZaTUk5TTB1QWVJMHV4WkZR?= =?utf-8?B?cHowcmh5eHFOZ3VpM3FvZC9NWlo1MWVhNmkydTJNM01maVRCenRzTVhWcEVE?= =?utf-8?B?L1MyclVDS1JtM3JTWnIwd0xlSmV6a200SlJpSXZaNW1HakhiQ2o2SGJvb0dO?= =?utf-8?B?NGwranRzbllFM2s2dFZob3pTWUhKNWlPNzFpMytMWTdhOEVLcGdnbTdVVXdL?= =?utf-8?B?dzA0T2ZJS1A2TU5XQXhLaEM1ZHJ0Q3kwRGpnNGM2Ly9wUHFCZ1ZObUg1a0w5?= =?utf-8?B?ekRaZUowcnFkQUNYVDl1UnErbFBuNTd3QTUvMWZRMEdSN0tDN3NMbWRFWUNP?= =?utf-8?B?QllnT0dhUE1hZjhxYUJPMWpVbGthWWJSdGxXRnVLMnJodjRjZmhWMzdDbjRr?= =?utf-8?B?SUdVU3B6QTliUyszS1hEVkFGVFNoQXI4UmYwRmordk5tTDZzQjBGNUlkQlAx?= =?utf-8?Q?rsFoCWPr1iyPkBzq+tT9?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecf4ed4b-e0b8-4e6f-2219-08dc26f1b247 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 08:57:50.1415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0239 Subject: Re: [FFmpeg-devel] [PATCH] avutil/opt: Fix AV_OPT_TYPE_CONST default value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It uses the int64_t instead of the double member. > > (This code can currently not be reached: av_opt_get() calls > av_opt_find2() with NULL as unit in which case AV_OPT_TYPE_CONST > options are never returned, leading av_opt_get() to always > return AVERROR_OPTION_NOT_FOUND when searching for AV_OPT_TYPE_CONST*. > For the same reason the code read_number() will never be called > from get_number() when searching for an option of type > AV_OPT_TYPE_CONST. The other callers of read_number() also only > call it with types other than AV_OPT_TYPE_CONST.) > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/opt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 0908751752..d13b1ab504 100644 > --- a/libavutil/opt.c > +++ b/libavutil/opt.c > @@ -93,7 +93,7 @@ FF_ENABLE_DEPRECATION_WARNINGS > *den = ((AVRational *)dst)->den; > return 0; > case AV_OPT_TYPE_CONST: > - *num = o->default_val.dbl; > + *intnum = o->default_val.i64; > return 0; > } > return AVERROR(EINVAL); > @@ -878,7 +878,7 @@ int av_opt_get(void *obj, const char *name, int search_flags, uint8_t **out_val) > ret = snprintf(buf, sizeof(buf), "%d/%d", ((AVRational *)dst)->num, ((AVRational *)dst)->den); > break; > case AV_OPT_TYPE_CONST: > - ret = snprintf(buf, sizeof(buf), "%f", o->default_val.dbl); > + ret = snprintf(buf, sizeof(buf), "%"PRId64, o->default_val.i64); > break; > case AV_OPT_TYPE_STRING: > if (*(uint8_t **)dst) { Will apply tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".