From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7265B47208 for ; Thu, 31 Aug 2023 16:50:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1391168C79E; Thu, 31 Aug 2023 19:50:46 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2076.outbound.protection.outlook.com [40.92.58.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6BA2668C6E1 for ; Thu, 31 Aug 2023 19:50:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHApeLa2PXqo87KHBiIYOuemYIqVU9PHJ7y12r1hXD0Ku80km2ZMNjL75bBv++Kv9LUVss9Fj10ouQReBZZqv/edv1XwI/TYkfHm6hy0LtQ/N0UhY83hOGbAH+MKmS95piygLD9A457suTckfclqb2rHqCYxga8OgkpyuVOOZo5hJdY6ekuD/QoVW3q3MoEWyXoolO+WXe5/a5992RK6uJM4wulAEIQ6vv/7bXG0bSgzGzjOKhko/9bQyt6gkVtQOKG7kPpSM+nlL/6unOqdAFV+Q2h9NzOkCRyxqHQbCWD5kQVSo8T353ZRJd7YFZQcRTEu67S6jEukhgmHQvUcFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RkqtD6Q2OEGY3+iHDxA4wXxdrrhqTkbpED9yWcVw7P4=; b=S0mfC/0l3dhCEE+DRJ3y7LqC6j3fIzGJ+L2emKBn12/HkDeiYUb1Co3Rcl/QfWZEBBAQbSiAkZIi5CaPd6DmchSx4rmUD1gY3NEycyPI2tfX1I26cGtClDjKNRe+AJvWgnFpO6CtsOXpdqtiXPgjOWbTZGiCV9lEK0Ogp0mJYYQsraOAS772aSVbGqB5MfxxvggQRDa8D/BqfUWh0lmeGH6jrfzR089QT+9Dd2tFFwwpoXMOlq0x4A9QJ+JPy4bHgQDZHLmKSSCFCM9O3V9IaQV6yAaC/6hllFiu9svtuAJN1cEZUg5zwK3F+q80/M3M4h9HCydtxiId4cU/IhFACQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkqtD6Q2OEGY3+iHDxA4wXxdrrhqTkbpED9yWcVw7P4=; b=GGttJYRBbEKUCcZBtOIMVu9Pg06waXbTdCrcWnJ4S1U31CMhhzA/zpbYKC1jubrXO7KW3eg4CFPgavxQhJmSXv/9W1UZECqioo97ltoWOqaBJ4Np5DqcgZ+klmcH7MIvP7rmBaV9K4DdYhvzF8A9aFNOs1VyjInfXMz7M1ejb6BpGDKSyWaYyffK6EYdW0/J2ohC7J0wVVWaIc1ndGIBoO1NteFaUpLajOClutZkowWNmnV5ys/iu64YzwiymauzZbxvjpvxnrVPkhMQd/4d1ETT78M9g1TAo/a+nh3F3SUJd0rGtmIrH2WKpc1bqEKUxMTFBxQUxAFOOt/Nak2bcA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0046.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:2b7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20; Thu, 31 Aug 2023 16:50:36 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6699.034; Thu, 31 Aug 2023 16:50:35 +0000 Message-ID: Date: Thu, 31 Aug 2023 18:51:52 +0200 To: ffmpeg-devel@ffmpeg.org References: <20230826122328.95416-1-stefasab@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [X2oPEFOuOkIZbfayl/989EG14LZBZH2ozomPENfXrX8=] X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <31cd19b7-7b1d-193b-3e57-a7aa2ddd84a4@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0046:EE_ X-MS-Office365-Filtering-Correlation-Id: 7284569e-9a13-4e4a-ae3f-08dbaa4265c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7NR4KUv1GuRBbKawAV9mRHnY8Wrf2wefbbsXI02+4UiuEAYProP0UMWA1mprKmoje+W1HHMcDix9NXfEmjzjJ7AiWjBxpf8dRIWjzfmynphISVinF3XQ2fvuV7jjGpOiVJgTz1v9YpQOcNcJA1T3yrR4YvhtYda7s+z6iT19B+HYm01GKHBUagGs6HIbrkVKmThVlH16rIlWd5S6XdYCJMpXNmymGJqi7+icfo3/DYixXJfr5DTBTaIBFRyCo/qzzL4yWT7181ynqWYnGio7IwUh7pN+tSMzvf9JFIAjYZuMKcoaFFn558luE9kmvmAIDdUh/G5VCGoVKpdePe5ThOgmpGl36/AabBV64FXbLPVWorAO/hcn/PWvmlZtXc80I2SMEKq2XZRxGdPmcP8UjEGuVCpBpNsaVp4MFGuvqr7jos1qxSikGA7Gu8uedDAjx6YTn34QJV1s5x75nR8pG+PzCGM1GwYFCpATjTgBe5kjFymutGZU33MjMc8FmPMJa+gkxphXoNMuR+9LroRqNmzeEgq7pZC39SeGOSqBe/8muoiWy4E2xOzhp1g9KY8i X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVVVNkJxRkxPZFU0NWl4YTI0QnNSMmZyeFRwK1U4QmhCTHlUV1dIRXRvdXlB?= =?utf-8?B?SHpGbHhobnhqTHBmL0x6M1RwY1VOSjBkZzB5ZnY5TTFYejhRL1NRVnAyMlpn?= =?utf-8?B?U2E4NWpSNVA0QkMvNjFUNzB5OE5tUThGOUlhQnh1VHVmMkdGbW9pc2l3ck9a?= =?utf-8?B?S0JBZDV6UnZQMDd5b01iczlnLy8vcytBUWJsTEhtNUlCQk4rTW5DZWhjejJq?= =?utf-8?B?dVRzc3diM3ZzSjN6c3lsakk2VTVwaE9yWE1iYnBvUFJiQnA2a2JCZURKSFo3?= =?utf-8?B?THV1TUhzeWtBNWNPL1kxbmJ6ZWREQk1XZXZZc08waU5ERWhVK2NvTHB1QUsz?= =?utf-8?B?V1dtRXB5U3VibkdWZ2UzRTRBNmdKM003ZDJOS2dkbkhuNCs0TVE1NlFwa3pm?= =?utf-8?B?bjM5Ym5keWUyRnpxMkZ5K0djcVNpRkhqSTMvSS9zVXNvd1ozWmZGcmljSFJ5?= =?utf-8?B?UEtwQ24wTmJ1ZU52TncxQ2U2WHIrVXBXc3pJOThxUVRtc0cxU1hXdzJqN1Qz?= =?utf-8?B?Ui9nMUh4alJtdWR0bDRQaGZQZTBycm5PR05FUHYyOTFMZlFhZHNKOFlVVFJC?= =?utf-8?B?MzZhZnE5WnhuRGV0NkpYV1hrOHdySUxXQmQ2bHZDMDA2NjMxSERrWEhubjlj?= =?utf-8?B?VG93bTBWeElpeTZwVU9Lcm5RWisvTk1BUDhuS0M5NjNzbnpIVGJMWlZrVG1W?= =?utf-8?B?ZEhCNm9DaHNKM2s4bnQxakNFTkVoVSs0U005aHJOSnVUZHpWdFVWaDRMNThY?= =?utf-8?B?cmptbVdFbGlqWHZyR0lBY253WDhQRytoVWw5RmVqcVA4b2czcTI3cmN1UEI1?= =?utf-8?B?MzFFN0tsRDc0bnBSMEZWVVFnMi9WWlBZeUltUmFhaTgybk5wQzZEVWpRekxK?= =?utf-8?B?Z2JZc1ZWc2dlNEdTbzJrRVRieGJyZG9QeW0vZ1UyQ1B0T2NXRzN6MURWdnZm?= =?utf-8?B?QjUwYk5QL1c4TEpJbllzaWNNcUtzcEZHdjlKNWZzRi9HYkRtbEZGdEFjbjJX?= =?utf-8?B?VlgvdDVSME9hQ2hpNWc0dksrbC9EQ2JleU5DVlJoZnk0enFRejdOTlhsd1hH?= =?utf-8?B?V1daa1RvZ1YrQW52eHdDVUpVOENKNTJpNHhNOFpWTW9JVGhuZFZXTmRNaElw?= =?utf-8?B?ZGh4YUNka3gyOTA2MkJFQ2tNMWxpVmFXV1FPcW5ES2Q3VmlqY0VBVVlWTStR?= =?utf-8?B?SUVQZWtNRm5pOElhQVdoZkJjb1RpR1gyMWxtKzRrOEkvTTBhUmhqT3ArbHZW?= =?utf-8?B?cHMwU2JsRHJzNWhVb2IzWGx6Q1NobS9EcFhQQXRvTk1SU0FUTlhXRGhUd3RY?= =?utf-8?B?YmR0R2pKOXcyaFRLa3ROQVZWc2VxWGxDREhvN3g2N0h1Nit2ZC9lRnlOU1pI?= =?utf-8?B?SG9DaTQxbVAzUmU5akxHZTNaRlVzZ0tTVjJkbHZCY1lFMFFuaGpMK1llN1VR?= =?utf-8?B?anc3V1VmSGtNdFY4UWtXeE1IdEJOUnFCZlVLeWZjQzA3M2hHQlB6Y2R4ZGx4?= =?utf-8?B?djRnM1RsUjlXWEFCaDNYK3VYbk5oekp6RjJ5bE4xNjR5K3lCY2Ztd2lKbnZo?= =?utf-8?B?WnlaU3hkdmlaejhSSmM4VTMvclk1TG9GTnM4c2RBM3VHb0xEM29uWDZENGh6?= =?utf-8?B?WFQ2eENYQmhIaDVNRDdzeVo1Y3N3K2Zuc1hMem1iS0Ivamdhcm82VVIrNnhj?= =?utf-8?Q?RapFtMOnQebYr8eMylFm?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7284569e-9a13-4e4a-ae3f-08dbaa4265c5 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 16:50:35.8100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0046 Subject: Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Stefano Sabatini: > +int sws_get_gaussian_vec(SwsVector **vecp, > + AVClass *log_ctx, > + double standard_deviation, double quality); > Seriously? A pointer to an AVClass as log_ctx? It is actually AVClass** (the logcontext must have a pointer to an AVClass as its first member), but we always use NULL. Apart from that: I am not really convinced that the improvement is worth the hassle. > > + if (standard_deviation < 0 || quality < 0) { > + av_log(NULL, AV_LOG_ERROR, > + "Invalid negative standard deviation %f or quality %f provided as input to the sws_get_gaussian_vec function\n", > + standard_deviation, quality); Here you are not even using the logctx. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".