From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 59AFA4AC6E for ; Sat, 18 May 2024 06:02:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B27BC68D239; Sat, 18 May 2024 09:02:39 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2065.outbound.protection.outlook.com [40.92.58.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 723A468D02A for ; Sat, 18 May 2024 09:02:33 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Amda55OMvYu0yDm8LEB5xvhUvlJDEAnyo4aizX+n71VG4gDsh0duh4yDYPi0lUNwRxqITLQX5YkR0S3Jwn85fFqnrl3P5oUXCvm3aIcnT/M+w3HEf4I+1mtT2K+PNixhlfaIO9M2r9mTeJIWMxjUi/SDZapcxc/3l+BnSGWNOPMx2ELoCpsquURsVv0BWBoUYWW023MfsvlG1/BsXyjKWYpyNQdBPR8lRkoxY3gLYO/QN7UyMXffxrMrq8BM3Pw5NCZeDyeVGWHI+gZL3Y15MZJ2y5q0id3q4LJgD4Qofqy9ICqGx2yREEKmH4GocpLckWhd7WrcjH1ijRvNxZsRjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BKuET0JoSvCKuzUnegB0u0CmnCjS/1Euq9L2yIS/jEw=; b=nlqNTSDZ/IVdFYjIFG4D/Zi6bP0uz0vy3E9CiGQ1Fon7GGzo16KkXmNNBVgoOWB7OCcunQpAF2gTswX0rAH/9yxaWwoeBSHpmY4oPYO6C2MZW9SG8wIm4i+a7y0nY2ltRNp9FWlCWoFqaqvmkZdXLmYscYthVLHdMJXLwM2Ua+1JiAJO8Nml4m/po4cB7lKEzJoG2G9zw5fkLhUv1jx8qvfcJgsOXhIHaVqDD7VOWI+HcxlqkPO77+wOKZuwQErtgOMGnINmhsdC3OUKJZeusbJ6/9ns3h/aVy4IVeYkyKPE/gXW4g+nDBplNJ2sSqX+hSvDPRWELi5pPCzKkHM9Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BKuET0JoSvCKuzUnegB0u0CmnCjS/1Euq9L2yIS/jEw=; b=j9YL0aeUVY4CCgc3RWAB0vXwkukuEWym0Gy3Nk7Z1IAwJ3/zBe4GrpEics8bylmelq7vx12q84TxV3/wdfyGoITrhtkaxn21dqQZVYlJbw9Fs3OqO12pvOQt2AjqxiT06idmd6I2BHniIDrlFY9ntuUdB97wRc1+HszH7yl6J2G8f7eL71PJUgwsWoE89rDn151cv8+oCEnlTpyG7rZYGaT5kJtLMZNUNCZrR0mtPeFrWD9Q97nFhe7BUxaLcupgFrDmEL1xKfe25iHkNIurfIoovotleLfP0rtY1jKtRp7TIHlnFAWYz7AiDnK+j6SeCNLWm4h5KuuBMsroLNsBrw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS1P250MB0504.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4a2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27; Sat, 18 May 2024 06:02:30 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Sat, 18 May 2024 06:02:30 +0000 Message-ID: Date: Sat, 18 May 2024 08:02:28 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240518035743.766552-1-michael@niedermayer.cc> <20240518035743.766552-2-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240518035743.766552-2-michael@niedermayer.cc> X-TMN: [EZrRX0fQJvCwmBEv1pvIkpREmG1JKnrUrfMgRwlnYMc=] X-ClientProxiedBy: FR4P281CA0394.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cf::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS1P250MB0504:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b487cdb-c3bb-4b33-17cb-08dc77001a30 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: sr+HWGECwm/4GtlZAFPGi6T9YHOXM4853DxMEDkjyvR5PzXjD4R1d01q23Cbtc3lRAtin5ojm2uraGhX0iy5N2FjrCVvioLM536540RC/9DF1ivO2OYMzBNvYTk/bw1HxFh87gzBmZ0tbl5UBRHgemLboWZ+m4Xbf97dzyGZ4aXOuqzpsI+DWBkKCBv25VF7PyqYT8lOJf/63vAyuFrlrmXcsJEUN3TJo/HEqP6qwMDw1/W+x7cFSfjNCWRfeHYg+IrbKX34sMGyLnXBNvMnOft25sztgQ0AadX6J9keY4y6lzzmVx2TEVFpSdLmUxVkQ99Lx+asceucQb7z2BgP9h8U7ZGpPKrcNgyfb1t78LNG9p/BAYuRj1FpmhrYx2KDZUBipBlvs6LevZUw8aSREKNYzraVPFtL5I6UVrsfcVykVgQWh/HUG1/q05ogMDBiZRPPAG/B6IS3oXO3U5Xq9P9vslf6/lcAlPRXrcp8YrILC+1QfOMeFaRKPC20HcSQAQk+Q5neP/GAtRgo02WCVZM0mQyHdM+yOBVX/YVkxOt+MAcMtGzLoU/q1SHXoy2m X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHI5WWVuY21QN204WEFzdEJuaHd4MnpnaHVucmRrUWZRVXFQMWN3S2hkcFRz?= =?utf-8?B?Q2NyckY2M2o3ZjdhdklXMmthNjdINEZ5RjhKb0FSSWsvajRsVkhrZTQzSVgx?= =?utf-8?B?WnpUMHBiVUR4bGMwNlA1NTg0cHlwTWJJME9JWUFJRmNuUUNMejJGTHRVSTUv?= =?utf-8?B?ZjkrT0VIOUxrRUR0Uzh3TDAvajByODJyZjJGT0JrazZjU2NkL2ZCTXdNVTJN?= =?utf-8?B?ZW5Hcjk3Qk0wQjRwL0VWMUFEQ3JIMXB5TmhYYzNuL0lwdnFWclJ3a1pWWDlZ?= =?utf-8?B?SFpPcTVvekJtMFNIVVVveldycm9nSDRBa0hya0luYTZQZy80QkdGeGR1NnJV?= =?utf-8?B?aXRNc0hHSFAwL2ZhNzU0QXRNMmtNTERFVklZZ1U5bmlJamhMSTh0U1ZQOGpv?= =?utf-8?B?SWYwS0p5Y2FnUXpnc29SSWpwRlk1M0QyT2cvdFc2aFZaVTRNN1J4MlVFMVBK?= =?utf-8?B?SzJCNTVBMTRhdzVjQXdJNmJPdFcwSU1HQXkwOGY4S0VTMHR1dklWcFplS01D?= =?utf-8?B?YmdqeXROazhOSG1LVVd3eVFlMm5kQWdZTEQrYWxDSDE2OG9kSXhWaWpYT0xU?= =?utf-8?B?WkVvQlBQWXVmU2VDSFJTYWRJVmhwaUVab3lPQ1cwNXlkYTh0eHI3YmFxdG9K?= =?utf-8?B?VTdLSW5tZjU2SmsxTm9PZ3JNVFMrM29jcWFDSXRyVi9mRGZ0OUFvb3hZREpx?= =?utf-8?B?eDF1VDJkeWdSUlQ0MkFOQ0V4a2FETllJcmJGbytWRkFKM0luRm1IZG5PU2NR?= =?utf-8?B?QWdGTUJSV1FWMldoZlNuejdqSWdBZStURUFkYVQvLzFXUW1qSnFqaTF5TFMy?= =?utf-8?B?NnlXTWNONHl6QkpDWFZzNG1FZmxKamozMnpQVStEaS90aExYR0hmTVF5UWIy?= =?utf-8?B?Z1UrVHFZaU9xVUVUUjBaUCtacis2ZWg2Ti83cVh2Y0NCRHhEVHdsSmw5eVF5?= =?utf-8?B?TmlOaW9RRkZURjNhS016cnRmTkhlSTFmdUIwWDVTVmFaWHJzckhSYk1BUzJZ?= =?utf-8?B?R3EvSGlKUEVLdlpkR2YxMEtXL3RzNjJQTzUvQlVhS0ZOZGIveWhZaEhCN0p1?= =?utf-8?B?dlB4Y2VHQnNpRzhldVF4akVRMTc3dVQxQUhuYlVOM0JlMlMrMmFQQjhvZlJH?= =?utf-8?B?bzQ4c25KK0oxUTlicVREN2pldG9yclI4TmZ3dzZJd1JZVVVERHYyeTBPR1hF?= =?utf-8?B?R2xTRTRpL3NxRlNQTHloZUhKY25kWEoxcnRxc1ByMWJYdm5UMTdINGtJemR6?= =?utf-8?B?SHdjcU5DVjZIV1grelBzVFZ0ZDEwS09DQXJLaHpDS09oOTBqQUlDVmg3QWZy?= =?utf-8?B?WktPZFY3SVFhcFFQY2I4VmhZYU5yNnJOYUpwL1dWeU84ZU5NOTMyUndTbHJQ?= =?utf-8?B?Ny85N08ydjJmS0pJU2ZSL2xDcklyZ1ZUclV0NGlwS3lMV2tWTDZYcG9TOHM1?= =?utf-8?B?bDcwOGEvSFNPc3RXRkpMQlVpMFJGSDJHR2pNRHZkZHYwTGc5RkpuenRvbENM?= =?utf-8?B?cFZEbUl5c29QeWx3UW1mV1dGSDVuZGh5ZlJSY2lGN0p3KzBrVnVwZzlFUW85?= =?utf-8?B?SW50NWVCdVBxM0g3L0czQyt3Z3NWdmRQRzEzWXhJUkRiemdIUDZMYitGVDJ3?= =?utf-8?B?ZFBVL1lYWW5IWVBMc2EzYURZaTVvVFhma3Mzd21aVWhCWEUvSll4SzhJajVo?= =?utf-8?B?SmFkd1BYZGUrdk5oRzVnbGVxeE1nbVBWdkJobUhzaGZOM01ldXlsTlR3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b487cdb-c3bb-4b33-17cb-08dc77001a30 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2024 06:02:30.5010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0504 Subject: Re: [FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Helps: CID1441939 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/tiff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > index ca7e9f6aba9..31de6ad7308 100644 > --- a/libavcodec/tiff.c > +++ b/libavcodec/tiff.c > @@ -457,7 +457,8 @@ static void unpack_gray(TiffContext *s, AVFrame *p, > GetBitContext gb; > uint16_t *dst = (uint16_t *)(p->data[0] + lnum * p->linesize[0]); > > - init_get_bits8(&gb, src, width); > + int ret = init_get_bits8(&gb, src, width); > + av_assert1(ret >= 0); > > for (int i = 0; i < s->width; i++) { > dst[i] = get_bits(&gb, bpp); What guarantees that this is not triggered? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".