Re: [FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray()

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray()
Date: Sat, 18 May 2024 08:02:28 +0200
Message-ID: <AS8P250MB07442F4DB6CD4098E3E920658FEF2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240518035743.766552-2-michael@niedermayer.cc>

Michael Niedermayer:
> Helps: CID1441939 Unchecked return value
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/tiff.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index ca7e9f6aba9..31de6ad7308 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -457,7 +457,8 @@ static void unpack_gray(TiffContext *s, AVFrame *p,
>      GetBitContext gb;
>      uint16_t *dst = (uint16_t *)(p->data[0] + lnum * p->linesize[0]);
>  
> -    init_get_bits8(&gb, src, width);
> +    int ret = init_get_bits8(&gb, src, width);
> +    av_assert1(ret >= 0);
>  
>      for (int i = 0; i < s->width; i++) {
>          dst[i] = get_bits(&gb, bpp);

What guarantees that this is not triggered?

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".