From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C2D24AC9D for ; Sun, 19 May 2024 09:20:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A1E3968CADA; Sun, 19 May 2024 12:20:15 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2097.outbound.protection.outlook.com [40.92.90.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 61FC168BF7E for ; Sun, 19 May 2024 12:20:08 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yswh764bZYLWzws85nsSo+hpc/82eO1aeGNkBRMMvi92H+HfR+iaQXnDKjr11JWK5//8Y5Nk71jnoSLSozENPMw/DodTvLP1H6y4WJnMPFo6R/GAx4Bx9LunvIn+rUtOb6rs0rfWqLRE8MhQXor+GL1fA2kpQ9lK81ZB0FCrWMPHGEcLB/UDJS2qsYEmGXzsWqMfLg7RO6bCDJxiC7Mj9ly8K31X0UO0vPp6Z4R/MtQV5cwYW3NWXbdytKzEhLDmt/HCz/O20UkzXp68e6yZ56t0sVZTnOW7YBDSuBKUzyuQ+XqL/gtzXdtdOenYCiCJKpAXvQc0nqquou6tPrOImw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bq7f6KNyZITrKaycXiDxwL/X+F9bKKllOB2NX/WOatQ=; b=UzpqnbhvVELiDcAuwc+kY84wbmlfSr+raUv1wddn792JjaQ77R7f4MK+iuxujZ1bBlTzg6wCe0I8wpxVOBe7IfTQ5MFlDFZrrDEkBqtVfzb/hnOF76nalJIHhHJbEvMX9RPU2D7d8qnDcPjT7Sn/VGxdjaLICdgneBEzGFOH6QZoO8jtbRZT/jZ2vt+Q9roDIAR2uppqtQjAP5iqY4gzfgSySg7IoOXJgDjiKeeSZJUsIdlr4BT45JbpjxIHHgBiWstW2F1SsbIBFoBp4pxNNKAodxjYWUCH1F9j+A4eFjfFyKbeh2EVuJFjT1svjuP0toRCb/TEiLh+pgHP4iU+Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bq7f6KNyZITrKaycXiDxwL/X+F9bKKllOB2NX/WOatQ=; b=avFcUrdbqZBloDq0vjK9U/jzOKPsTfsk4JEK8Qa9boIyhoGZl6A82uB3FL+4BnJz7Wuy4g3d+0u1fSN/4iOfWmXG1tWfiU6YP92/KGeROmO9G9OH6ytOu8fsXN047RTMGo9Z+4c5Ri9dLHrSSBY+3pMPmCcLmZAzpHi2dORB8KHhT/VNVkZOoIQRzVpumPaoAbAdYEohRuYAeif35AfbzrzZrBtkroZqiAyy7HJMEBBhVn9QxbkeB1U4TJIKSwGiL9G0f+7CmxU/WUUl30FlVqc6uPQ0+hu1nHmhFDj8a0hA2gPusBxKLJRRkxje/etHYCP4TQ8CcobZLqNvoGABbA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0237.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:276::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.34; Sun, 19 May 2024 09:20:06 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Sun, 19 May 2024 09:20:06 +0000 Message-ID: Date: Sun, 19 May 2024 11:20:05 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [OA3+h5LQOcMS4hOeaVz8invPKu1L0+kuSm6HrkTufR4=] X-ClientProxiedBy: FR0P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <8d4028d6-cea5-4fbc-bc6a-b7c3ac1d739a@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0237:EE_ X-MS-Office365-Filtering-Correlation-Id: 19eef075-44c1-46b4-8511-08dc77e4df2b X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: l5z+MRrqvI9a+ZQMSBs2VVzuw3ICXy2wnJB1xtCBVwcmjTgPMl/nOXPPTRxVRiOKh3pkPK6OrndDEQGDu9AFiLK/KE3wFLHqKLz/PMZb2Wr0I9fYx/iwmE6Ub8V8SPEBr3oV1jwXP6zOvVEqVJYvI2WASi7lwT0iz3kJiUNaaqmuCv86G+Df83xf5OyBlfws4IODKKK9G0lewIBSLAXBi1EVZLOfTGDdUpyo1fZWfRkEuAauhkTk2b8bXWaH5OAK0khniu5N+O4L7C/rpaGvIPlahuamjnRvOdxM1QLoHn+HFj6WEXTsOPhtDvtlTseqKk1RXlH5ISQ4wTF2nyk/lpbYSPqSMy4urqG31HUs13tEcRKUBjgXRDsnBkPXkg9UwIfCnCJY4ZTKsnD7IBXAt2QUn0euTGRlQYBe4F8P/J4SgASGROeYudZ9mXvTayjT+5vmsQlzzW0Y/4LoDwIGzQLoNqORd/bp4tasHPsYyPCI5UkQ87U4xGJpXGhtrbhmIpMrIpLrrnGLX/z+0FXoMjWXY0psOwY/28Xdl282d/HmpPs6xfqtAb+h6BC6P64b X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTJwUkQ1T21yM2daRjFKVEt6NzJXNEZCaEk0NjZyMURuVy9aVGlBRmJCQzUz?= =?utf-8?B?YzllNUMxeE9mSkppTUpYVGd2QlluWUp5N3p4NzZxejUwQ0ZKT20rTmQzUzdO?= =?utf-8?B?aVFaK29DeC9aNjJ2bGliTnlUMUw5RitGY0MrRHJiSFB5SzBIbHhURTJzYS8y?= =?utf-8?B?S2hGYVVPeGhFR0xNVnkySVJ0WEZUaEJCSms3bEZWK04zcVo5R2wydlBwR051?= =?utf-8?B?TGRKUXJMQU5TM0M4cHZYTEV3RFRrV3A3ZDRCaDhnNFhmUS9oZE1Rc0pHcEw5?= =?utf-8?B?WjhkM21kS2VaUVdoeXZSWEVVRW5qM1B2aFlSS2NNS0pjaUdQd28yNXdIbkNF?= =?utf-8?B?dkdYNnAwak5XT09pSFdXTEI2M3Q2MmhKcXVMNHdrS253MldPMWV1Q0hibDBq?= =?utf-8?B?eTFMTFROVGtzZWMrQldyYlBteWxYdHdIS3YvSzFPV1hHZ242VkloWVVSa05r?= =?utf-8?B?N2RTTU1sVnl3ZDlTemx2KzVnbmk1NGNDMmxaRDhSdEhsakd3b0tMVzVEVFNQ?= =?utf-8?B?K3o0Z2pSNmZ5bTJwVFRobC9wekRNVStJcFFSRUtPVWtaSmg3VUI3N2t5R2ov?= =?utf-8?B?eU5XZlBWZmdmZ2g3aEpGNnlEb1ZFM01uOWgvQ0RKQ0ppSFJWdGxscmw3ZWhF?= =?utf-8?B?Y1JhM0owOWJhQVJheUEvN0phc1E5bmlSQkROOXdXVEJOU0N1dE04QlRGL3RZ?= =?utf-8?B?eTcwVHQwcjlLcWhMMkVTbXk5d0FXbWpiSVdXQ3hRK0tZclY1UGpONEJraEF1?= =?utf-8?B?dkZpcDFDdG9pL3k3U3NpWHZ3NldzVk1UMHU5TXc3SFNkcEI2T0lmLzZUVWVH?= =?utf-8?B?MnBvNWtRSittRHdGVTlaWmR1STRuN3RzbndqTHdFa0d5VE1zZFlZSnhPTzFu?= =?utf-8?B?Q0lPWWNseWt6eERYVXlxQWhVUEZNY0lWSExjRlN3RkdrVDEzaVBhaHNkOU9l?= =?utf-8?B?b2YrQm5wWEJvVzkvQXJlamxjaTAwK21FM29kOVdkMkgzMXRRYVBmQmhNbGEr?= =?utf-8?B?SzMzcGp0TElqaWJPK2xESElyRlJlVkhITWYyT2dPMzhoUjJTbmpnQ0RvU01J?= =?utf-8?B?QmxDM1FnREJxMUM2dXRzRFZBeVR2ZDNIYnZwckZzR0RvWXdZczVMUERBL1Qv?= =?utf-8?B?TlI1SDA2MDd3Z21CMFBZTjVBMWNoLy94M0JJQkZaTXkvS0F1YUxVRXJIZExV?= =?utf-8?B?Zkk4QWRNWDZJaXBZQTJqNDBnRkhlVVlQWktOTEE4WFNyMXl6Ym5jYXdKWkkx?= =?utf-8?B?REtvTGdoa1NWQStGMGUxUm93UExsMFFwWXZ3M25XbU1wOTZpeWZuRWZaYjFn?= =?utf-8?B?TlllSkdLd1dBd0ttNXRJR0QyZm5LVlVxYzZ0N2RrNVErR1BPMlBMdUpneFA0?= =?utf-8?B?RVVoVDdjVHdoK016bmpOajZNWUVtcndESmMzUGhjMHJPOHpHNTFKTERRaU94?= =?utf-8?B?aE1PaG1TTXFUQUI3NmFnVU9Yb2o0dkt5V0xEZmRMN0ptdGp3WVRBbm5PUmtG?= =?utf-8?B?K0h2YlNsSkV4MEU4bTNUWUlad2txQ1ExVlB2M1BFUk1MNnBjYXlydmVwVmRK?= =?utf-8?B?anNkeHltTktyY1F0MTF0NUM4U2xLWklqRk4yb3ArTi84SWhMc0VmUW5SWGVO?= =?utf-8?B?QStUcGhUZkNDRTBGMGFVeThicDZMU2lWZ2dVZUVweWd0WUphSGN3dW1adzRz?= =?utf-8?B?Y1B3Y25vQmVXakZ0SkkwMnBwV2pCNi8rWk5FUC96SktuWEt2T3FDQ3B3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19eef075-44c1-46b4-8511-08dc77e4df2b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2024 09:20:06.2546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0237 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: Fix leak on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Do this by attaching the FilterGraph directly to more permanent > storage from which it will be automatically freed. > Fixes Coverity issue #1596533. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c > index 382d0f75b1..12cca684b4 100644 > --- a/fftools/ffmpeg_filter.c > +++ b/fftools/ffmpeg_filter.c > @@ -1198,10 +1198,10 @@ int init_simple_filtergraph(InputStream *ist, OutputStream *ost, > FilterGraphPriv *fgp; > int ret; > > - ret = fg_create(&fg, graph_desc, sch); > + ret = fg_create(&ost->fg_simple, graph_desc, sch); > if (ret < 0) > return ret; > - ost->fg_simple = fg; > + fg = ost->fg_simple; > fgp = fgp_from_fg(fg); > > fgp->is_simple = 1; Will apply this patch tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".