From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C8F8C440EA for ; Sun, 25 Sep 2022 12:34:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF5D768BA50; Sun, 25 Sep 2022 15:34:41 +0300 (EEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069057.outbound.protection.outlook.com [40.92.69.57]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71D6968B8EF for ; Sun, 25 Sep 2022 15:34:35 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wh48TXOWo5KOVK9zSq77iRGoJYgomjEXf3/KzJYISRG+F4dGdSi3N09iX1tiaS6yLmN962SKZ+f9uPxzPHE6suETrcJEUI5TYeqjNxoIGPomtCU3fkncnRhVCSjNd02Yg8+NL6BUqcOC4Pk060Yejp4aT1gwU59GbJiKBCMu0djcX1e6L0S6W4LMuXj7AlDE+/mcZFKcB0pU/p7rn03Yc1nMrDC8Ochl0POIsApCXAFtCWZx8/Lfv2pBZoECM/s2iOoBoWciPkfFBsrllvLSfZwXmxK5fbk4MZxf/UNq7WrHgEYZeWchPjWH8OwuCUiMzI7kOi6nD+iUn1KsevhkPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kk+bfoWpC1cE49kF+4pl7wOMQy97t8TiKy5d2k5stTo=; b=C+9QMRTTNCiXnqYkVZNvIaYWAmw5UYZilsZkx8UHfl/YPJ0+ynYue8W0uCBWrOFaX9PzUePQDruEW8dIXGFTj2AeHQTswPQoY3fjCEy/4RPbC4sj7fbDbPxb8EUV6sDkC6vLbU5ovCtoxa3jspEyu9UPgD4yp/LvCieygVjSbE9KbcIVJZMFPalnLMlmAtxvbkTUA/ctqYWeSpgrlIyOabPJGfbumcnOdRwE0mZ5QCJs/4IHf7JeZF+yI/IA7h61zQTLc3wNEDZbfflcSa3xjWqqIM1BxoghKIchtlKXFY+K10QR+eWov8wrY5lQsatMxyJkENY71W/1IXMXofIEJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kk+bfoWpC1cE49kF+4pl7wOMQy97t8TiKy5d2k5stTo=; b=piotBQAYPMNPqJuPo1+QWP2PE6uBp6yshCUYGn3hTJ4lpfygp8tTEPSWd7Isj+fnyjQUw7Ry5QgFCwsNDlc1XPCFgUQOVHtFY43XNoS20CSFCnYLOU05zXarvLw6Nmw4Hq9xAc71Ab65Ppxz+FSyacJJwYaty5ajZce1c0FuLvmrzcUHr+PD2ZQYQAFvc21GPMs4lEBIk52waVhR31ko85HA6pMHTB+cNZj78159YJVrwlIjgDha/xpX9V7zV5Dr8ypCCnzfqN2VoEb8Hpp7sr1Ec31vCjmkQkf+/BQxoRia5WjqF+6WUzFA3rX12v6gBLgKxbSUNSG7TNc9P/nqUg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0336.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.24; Sun, 25 Sep 2022 12:34:33 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::85ac:1b92:90f:dc18%4]) with mapi id 15.20.5654.016; Sun, 25 Sep 2022 12:34:33 +0000 Message-ID: Date: Sun, 25 Sep 2022 14:34:38 +0200 To: ffmpeg-devel@ffmpeg.org References: <37cff64-511b-518d-769-f02c1fc7e49f@martin.st> <38345618-1535-1c53-6c28-52d0796e217@martin.st> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [Z/OZT55qvbb0XIdSQnPyfmRreCr4BL8rrejTVoTk7TQ=] X-ClientProxiedBy: ZR0P278CA0183.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0336:EE_ X-MS-Office365-Filtering-Correlation-Id: 91dd6ea0-4b95-43a1-8633-08da9ef24c91 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ho8qaTabc1/oAT/Q9KviB8FpSUdYA4M9I49kl9wH2deMoGNS0dZJm+BPhxHAHsXS49wr9p1+UAnajvsImpQeTOYKrx3Erdr1CNcOg8ckUw2RmK50QbIvOvB9Yd/2KTTQ69R8KG68q/4SAMIBOckHFuomlO6LkOcErtyhBR4al7VMHYzt11D4sBMDQBsbBuabrUwHjZxyTM/aIP2Mc5TvSAmxcJAWqYGxKfnGq/Oun4QIWxUmQ+uJm7AtzyDg6A/CSVQeb2SuOyPzQ39JpKpuw5VoPdPXjPmFFJScTCnY1Sl6hFK32dz/Pdat56St2z2iyk2A/oE6AQRBb/ARRfkDt9ek5ZEEjIc3io3DAysvrM7nAJUwniiPm8Kd1+/nRmXt0nocwwypMDeMPNV0frf3XuLjQdzHcvGutDCpFKwcRNpRzaxOegFdtgu9MU31lE6IaKxFdGZJ95xjNoFYZcibHM7T9fAAfePZ3DNStl4/wJSWfzFyUYLt3eZRsWGFnYu/P3vUOiQQn+c9oG62EpUhTfLdLY5qOVw1Wi4RCCVSU2/CEBv2He341QWGPk1rL5TG1m6K6PAhiPRDb5q84kQGwv1t9zG8DFe67p4ePzmDRFmbMGS+xengR0QRyHTaLpgwiUZDzlp6XCxw4DBwgdQQTzj6OQZe0/iIRYwwRGd6dqsWhoxLHQinXlaeVJ3lv5fJ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0locUJTNjRqbXFaa3FrUlloTjdOZ1FrbjM3bzBwN3ZlK3JJZnNRWVlKVTFl?= =?utf-8?B?dGZzNW9DaXphMjBXdUNNVkFKUklzZ0FzOXVMYU0wNDNXaVIwVEtHcE9RcnQ1?= =?utf-8?B?Qmkvdi90cGp6Mi9oN3dGdk0wQ0hnRG9Qb0JIWnFWOWlFRWNOS3gxVXdXcTZO?= =?utf-8?B?c2prdWZQanU3aGlRQU4yWlY5c04rZlFaRjdoR0VCNFk5QW9xL3JRRnlMQmxi?= =?utf-8?B?WVRnL2k0MG5BK2VGTkZEbjJsTThxRm1FWks5NUV6L1VTSUNUNkJpYkI3MXoy?= =?utf-8?B?MWRHUTdaeTlycVl4d1JjTkpUejgwR1RlQWdIak5FbmZqRFAxR0VLdE04elFo?= =?utf-8?B?Y1p0bHlvdHQxQy9heTAyVUJhRGlpUjN5ZkVXa2dDa2dybERPU00xUjR0Mk53?= =?utf-8?B?VDY3M0FobGhVUUl3U1NWWnQ1bzNsZi9ZWGg0bXZUeEIwRHZDWndkdFgvazE3?= =?utf-8?B?U25xUVRSNk9peUlNWVVUYkZnY0d0YlllUVdSN3VsaUJOWitDMEFpQ09SUmpB?= =?utf-8?B?TE1CZXpsUUN0bHE5TXdiZ0p0dFFZNDEyZlJPU0lLUUkzei9ScUF6U2N3ZkJ2?= =?utf-8?B?SHNXNkZoeWlXaHZKZVA5bTlLQTE4c1FKOW1TZGNidjBldCtNdlBVT0VHUS9k?= =?utf-8?B?QUpWY1pHWmRReFp5MitnU3pLZC9iY3ppL2xVVDVzc0ltdkViQ2xYNkZydXA0?= =?utf-8?B?Zk91Q2k3QVRvVFR4YXFRMzlIMlY4a2NUcjNGVkJKMWF6d3VUTy9NamdQcnI1?= =?utf-8?B?N0pPcURzZEZNaUN1ZlFNaSthZFZIT3A0N3JzajhoeHFJSkM3SExaU005TFAx?= =?utf-8?B?ZzhQYjR1QklrbElDNGxiZTJ1V1B1dHlZU1kvdEtzMlNEdDloOER1cVVNODE2?= =?utf-8?B?eVlkWEdBOU9jY1gwQTdOMFFSSVVubWI2TmNNUzlXbEFkM0Flem5SVVJ2bDYy?= =?utf-8?B?YTErM1AvaTEvSlZTeGJxWVN2RmV5MVFjV3RKVDBsSWNoUndNQm9ZbmE1SGpK?= =?utf-8?B?UWxMaVF0RXF3bk1GdisxT1RhMHA2Wld3VGVLNHRQeWZtT1duM2ZmMnFtczdp?= =?utf-8?B?bEpFZURTVE9YNmVTM1NnOFRZVnU2RzgySjZWaE1VVU81MEJ1ZU1qYTBGK0F3?= =?utf-8?B?dVlrT1BiYUJGZkpJdmt2Q2ROY0pJd2JmaHN2Q0p6UWc5VzVSbU9KZTZMb0Vm?= =?utf-8?B?TXBWTHZjRndqUnRTaGYrcGxPbjZRTmlIUmNiMTMyMHA0a1BQVWlTQzdnaVVY?= =?utf-8?B?K3czV2NiQnJxbUZtWnpNRCtzRklaQVNBWENhQ2Q2NGdwclU5NDZzT1JadjVs?= =?utf-8?B?cWIxeXJpWEtEL3hoUkVSSUhLajNhM2xBWmp5bllyVWw4TGFnMTg1c21lbWtT?= =?utf-8?B?QitxOCtiNlQ0NGRRb3NMN1RjRG14MS93ZDRqUUVHMXJTTmdTL2Yrc2prUWYz?= =?utf-8?B?TVhLM1U5bjMrVzBmZEE1aXVuMkFiNkROekd0NmhvNThiQVB1cTZvS2tzMDhL?= =?utf-8?B?cUhyZUlpV1VkVkY3MWo4YnJxWTIxbkpKaTFCbkh4YmxRZ0xwNVV0eE92UnBS?= =?utf-8?B?bzlicUl1VlZ3YmpPWWlTMGw1WGR3SkRFcTBkbFp2RnJyTHR1OTF0NVpQRUd2?= =?utf-8?B?SGhzU0diS0EzaHk1UjdmcmsyMXp1MG5QeTE5aEFsMnVzd0RURHlMeEtjT000?= =?utf-8?B?cW5IY2ZnZEZBRmdjQ2lyclp6ZWZVVzh5N3Q0N1lIeHNjd0c1QXpQQ1ZmOGNs?= =?utf-8?Q?/OhNripNUJVV1GHXHX329CS8gosNh1ShBTJ/ZYL?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91dd6ea0-4b95-43a1-8633-08da9ef24c91 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2022 12:34:33.2725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0336 Subject: Re: [FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > Sep 24, 2022, 23:57 by dev@lynne.ee: > >> Sep 24, 2022, 21:40 by martin@martin.st: >> >>> What about ac3dsp then - that one seems like it's fairly optimized for arm? >>> >> Haven't touched them, they're still being used. Unfortunately, for AC3, >> the full MDCT optimizations in lavc do make a difference and the overall >> decoder becomes 15% slower with this patch on for aarch64 with lavu/tx's >> asm disabled and 7% slower with lavu/tx's asm enabled. I do plan to write >> an aarch64 MDCT NEON SIMD code in a month or so, unless someone is faster, >> which should make the decoder at least 10% faster with lavu/tx. >> > > I'd just like to add this was for the float version of the ac3 decoder. The fixed-point > version is a few percent faster with the patch on an A53, and quite a bit > more accurate. > The lavc fixed-point FFT code also has some weird large spikes in #cycles > for some transform sizes, so the figure above is an average, but the dips > went from 117x realtime to 78x realtime, which on a slower CPU may > be the difference between stuttering and realtime playback. > On this CPU, the fixed-point version is 23% slower than the float version, > but on a CPU with slower float ops, it would make more sense to pick that > decoder up than the float version. > The 2 decoders produce nearly identical results, minus a few rounding > errors, since AC3 is inherently a fixed-point codec. The only difference > are the transforms themselves, and the extra ops needed to convert > the 25bit ints to floats in the float decoder. 1. You forgot to remove mdct15 requirements from configure in this whole patchset. 2. You forgot to update the FATE references for several tests; e.g. when only applying the ac3 patch, then I get this: TEST ac3-4.0 stddev: 7.60 PSNR: 78.71 MAXDIFF: 867 bytes: 761856/ 761856 MAXDIFF: |867 - 0| >= 1 Test ac3-4.0 failed. Look at tests/data/fate/ac3-4.0.err for details. make: *** [src/tests/Makefile:307: fate-ac3-4.0] Error 1 TEST ac3-2.0 stddev: 2.57 PSNR: 88.10 MAXDIFF: 414 bytes: 804864/ 804864 MAXDIFF: |414 - 0| >= 1 Test ac3-2.0 failed. Look at tests/data/fate/ac3-2.0.err for details. make: *** [src/tests/Makefile:307: fate-ac3-2.0] Error 1 TEST ac3-4.0-downmix-stereo stddev: 2.99 PSNR: 86.81 MAXDIFF: 198 bytes: 380928/ 380928 MAXDIFF: |198 - 0| >= 1 Test ac3-4.0-downmix-stereo failed. Look at tests/data/fate/ac3-4.0-downmix-stereo.err for details. make: *** [src/tests/Makefile:307: fate-ac3-4.0-downmix-stereo] Error 1 TEST ac3-4.0-downmix-mono stddev: 4.11 PSNR: 84.05 MAXDIFF: 281 bytes: 190464/ 190464 MAXDIFF: |281 - 0| >= 1 Test ac3-4.0-downmix-mono failed. Look at tests/data/fate/ac3-4.0-downmix-mono.err for details. make: *** [src/tests/Makefile:307: fate-ac3-4.0-downmix-mono] Error 1 TEST ac3-fixed-2.0 stddev: 382.35 PSNR: 44.68 MAXDIFF:32866 bytes: 804864/ 804864 MAXDIFF: |32866 - 0| >= 1 Test ac3-fixed-2.0 failed. Look at tests/data/fate/ac3-fixed-2.0.err for details. make: *** [src/tests/Makefile:307: fate-ac3-fixed-2.0] Error 1 TEST ac3-fixed-4.0-downmix-mono stddev: 1140.81 PSNR: 35.18 MAXDIFF:34416 bytes: 190464/ 190464 MAXDIFF: |34416 - 0| >= 1 Test ac3-fixed-4.0-downmix-mono failed. Look at tests/data/fate/ac3-fixed-4.0-downmix-mono.err for details. make: *** [src/tests/Makefile:307: fate-ac3-fixed-4.0-downmix-mono] Error 1 TEST ac3-fixed-encode --- - 2022-09-25 14:22:45.695390813 +0200 +++ tests/data/fate/ac3-fixed-encode 2022-09-25 14:22:45.687999547 +0200 @@ -1 +1 @@ -1f548175e11a95e62ce20e442fcc8d08 +e9d78bca187b4bbafc4512bcea8efd3e Test ac3-fixed-encode failed. Look at tests/data/fate/ac3-fixed-encode.err for details. make: *** [src/tests/Makefile:307: fate-ac3-fixed-encode] Error 1 (Additionally, checksums in unknown_layout-ac3, lavf-rm, shortest, copy-shortest1 and copy-shortest2 need to be updated.) As the above shows, the difference between the reference files and the decoded output becomes larger in several tests, i.e. the reference files won't be usable lateron. If the new float and fixed-point decoders produce indeed produce nearly identical output, then one could write tests that decode the same file with both the floating point and the fixed point decoder, check that both are nearly identical and print a checksum of the output of the fixed point decoder. Also note that there is currently no test that directly verifies your claims of greater accuracy. One could write such a test by encoding a file with ac3-fixed and decoding it again (with the fixed point decoder) and printing the psnr of input and output. No encoding tests does this at the moment. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".