From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 1/2] avfilter/ccfifo: Inline trivial functions Date: Sat, 3 Feb 2024 14:37:35 +0100 Message-ID: <AS8P250MB07442A3A37AE671CED533EF78F412@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) Besides being extremly simple this also avoids including ff_ccfifo_ccdetected() unnecessarily (it is only used by decklink). This is possible because this is not avpriv, but duplicated into lavd if necessary. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavfilter/ccfifo.c | 11 ----------- libavfilter/ccfifo.h | 13 +++++++++++-- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/libavfilter/ccfifo.c b/libavfilter/ccfifo.c index 6ae61a4b15..29108822be 100644 --- a/libavfilter/ccfifo.c +++ b/libavfilter/ccfifo.c @@ -24,7 +24,6 @@ #include "ccfifo.h" #define MAX_CC_ELEMENTS 128 -#define CC_BYTES_PER_ENTRY 3 struct cc_lookup { int num; @@ -89,16 +88,6 @@ error: return AVERROR(ENOMEM); } -int ff_ccfifo_getoutputsize(const CCFifo *ccf) -{ - return ccf->expected_cc_count * CC_BYTES_PER_ENTRY; -} - -int ff_ccfifo_ccdetected(const CCFifo *ccf) -{ - return ccf->cc_detected; -} - int ff_ccfifo_injectbytes(CCFifo *ccf, uint8_t *cc_data, size_t len) { int cc_608_tuples = 0; diff --git a/libavfilter/ccfifo.h b/libavfilter/ccfifo.h index a3c302b6b2..565a837a00 100644 --- a/libavfilter/ccfifo.h +++ b/libavfilter/ccfifo.h @@ -33,6 +33,8 @@ #include "libavutil/frame.h" #include "libavutil/fifo.h" +#define CC_BYTES_PER_ENTRY 3 + typedef struct CCFifo { AVFifo *cc_608_fifo; AVFifo *cc_708_fifo; @@ -88,7 +90,11 @@ int ff_ccfifo_extractbytes(CCFifo *ccf, uint8_t *data, size_t len); * an appropriately sized buffer and pass it to ff_ccfifo_injectbytes() * */ -int ff_ccfifo_getoutputsize(const CCFifo *ccf); +static inline int ff_ccfifo_getoutputsize(const CCFifo *ccf) +{ + return ccf->expected_cc_count * CC_BYTES_PER_ENTRY; +} + /** * Insert CC data from the FIFO into an AVFrame (as side data) @@ -113,6 +119,9 @@ int ff_ccfifo_injectbytes(CCFifo *ccf, uint8_t *data, size_t len); * Returns 1 if captions have been found as a prior call * to ff_ccfifo_extract() or ff_ccfifo_extractbytes() */ -int ff_ccfifo_ccdetected(const CCFifo *ccf); +static inline int ff_ccfifo_ccdetected(const CCFifo *ccf) +{ + return ccf->cc_detected; +} #endif /* AVFILTER_CCFIFO_H */ -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2024-02-03 13:35 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-03 13:37 Andreas Rheinhardt [this message] 2024-02-03 13:38 ` [FFmpeg-devel] [PATCH 2/2] avfilter/ccfifo: Improve included headers Andreas Rheinhardt 2024-02-06 8:57 ` [FFmpeg-devel] [PATCH 1/2] avfilter/ccfifo: Inline trivial functions Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB07442A3A37AE671CED533EF78F412@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git