From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DBBF64C562 for ; Fri, 7 Feb 2025 11:56:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6DBE68BDB3; Fri, 7 Feb 2025 13:56:27 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2041.outbound.protection.outlook.com [40.92.91.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E38868B7B0 for ; Fri, 7 Feb 2025 13:56:21 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wnX6IgvngFlpLZzqZJ7AeLyFUZQtt+Kt1mQUinlxR1REq/2sWKce8YCKiIK8PdeD+BbI5fpF7KlKAD+fD/v/8AxC3tnw2L6gf47yAwdjBkTutwRn31LKefH+85e7wUwIxFlV2jTky+9QP6+AJ16bpiMGVl5720yu+y9hqa4Y0Qwcqako9ZfxaMcquphedCwFakQ7HECx9RV+zhZqSjS1sd/AI18k9sZaTfbyclhg9O318Il/hQKp0IubhgAX6iNOd9Byh6dEsC4ypA1WHSCIdO6Uutj8LSmn5XrPj+S42U6J/xdOJES9OGxxzM6gFRmmqh+xCX2qFZCcPZM4sxUCsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UvvD1ubX4g7DEesezuQ7VHKIfryrByif0+vrS1Mknjc=; b=JN9PZZSQ/zag83esjG47XHs06dibTCLj+Fig9ml2gfFf5px9SfvNNJcn1EwmIUALx/W1SCnq73cmDIR6qdhVbzwoRyNSx0bcNWJhJMTioWml5VQlhrF3jXj/fs56gF+FYySrpDmZ8op4z4LtSZoyPQWaXt12kSP4VGCBOAqqM9qYJ7sY4YlNZxirs2paMEsGjEM7WL1PbpJdjprLx3rYWx3SVS1P9LVWO2bNVFfpWm4/Go4fmC5y7vaqJAGQb5sHroWV+OSMjkkg+js+oSrdBdu498xcXLWbUQ2K1OizRFg8KMnj1DgYeCsoBz7PkK09kF/K2ANeXtbD8dduYdapDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvvD1ubX4g7DEesezuQ7VHKIfryrByif0+vrS1Mknjc=; b=SbPUNFbnuRsrjx8PGl9pMq2ykkNdz+J2cxJo6qOdam8tLW0C2POm/q6SeiU3AN5qAU4cnas0XMPrO65MtaiO8mwHJVRdgxaYGQC3NJS1OchJO/CpkMsxlx8COsZ/JmM46sFA9L1PVIxzPQNOw5Z1jY7bs0DFOnn4U9YsWFFLkaHtiaQ38ntSHnGpr9iCKasUdNWsCSyue7xduwpWKDcUcYPZUEvq97agBVkRtWL34MxfRH9sHlWsMG7vH2Mkh6rbnWCLoQAaMwYsZpTgu5jROB+cwVi/BYJErN4fArHzkrDhVnYnABuGzK/LJAVp6oX3/fwBsRxExoHx6GrRbNV8TQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DB9P250MB0596.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:333::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.11; Fri, 7 Feb 2025 11:56:18 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.8422.009; Fri, 7 Feb 2025 11:56:18 +0000 Message-ID: Date: Fri, 7 Feb 2025 12:56:16 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250204111521.48785-1-romain.beauxis@gmail.com> <20250204111521.48785-2-romain.beauxis@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250204111521.48785-2-romain.beauxis@gmail.com> X-ClientProxiedBy: ZR0P278CA0184.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <3e7a680b-afd2-4a0a-9c97-0ff46314fbeb@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DB9P250MB0596:EE_ X-MS-Office365-Filtering-Correlation-Id: b4eb1aec-066d-447b-e50b-08dd476e6e1b X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|19110799003|6090799003|7092599003|15080799006|461199028|3412199025|440099028|19061999003|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eStwSEZCNFY3dFBRNGV3SmZpaVdGR2lxN3QyNk4ybjVJSnYxcVNVRStNb0Q5?= =?utf-8?B?WXJzbDhmRThCVHU5c0tnNGVnRXk0ZVYwSWM4V2ZocVVsWHh6eFNqMzRrYkt6?= =?utf-8?B?UTdzTHpqYjBhRjVZcFBKaDhGZkNNNHBGQUhtM0d6SUNwTElWVnZwbUtNRHFY?= =?utf-8?B?Z2JIYTJzWGhVSjJyQ0NuMDZOa1lzMXZDMWdIWUVmakc5ajVWTEQrekJBSWFz?= =?utf-8?B?ZUpyQWIyRzNpL3hsclhQL09vS3MzWlVXMHBvN2Q5SmJjSXJYNjBZdjIrYlBU?= =?utf-8?B?d3VKOS8yR2VGdFVNejhaUjIvVmpxd1ZYZ2pacFRSV3dDVHVvQlYvUTdZVVBh?= =?utf-8?B?djl3THhSalJrSmRyUHZwYXBrTXZXd0xaL0JIWVdNK3BKU3dtMHpaaFZUSFlP?= =?utf-8?B?cVhxWkVjTDhuN0w4WEpPZDJDNVNoTzJRakdyMlUvTU9oQVJvSDd3UUlxMTdo?= =?utf-8?B?YUowV1JnZHFTcEFTQjdudDVDNE1OTDFWdlZLMWVBT0JiWnhBQjRQSU5BTzJD?= =?utf-8?B?YzNyNGtBMlprZlB4YkY2UTJkZjJOYTNnSjExNTdKQzVlZzRidG5IbFp4anA5?= =?utf-8?B?NUFXTlBPKzQ1eWd0b2ZwcHlMUGIwa1FSMXlnVWc4VG96bzV6VDhQRWtJdmYv?= =?utf-8?B?WFI3Rmthb1duREJjUUFDM1dRcEtJTFgxOTFUVytmZGJOTWpSRDJzYnZGaUt3?= =?utf-8?B?dVpxZWhtaVo4Ti9WY0h3ZE5MckdvWFJEcE5XcldLTjhYODllYWdXbldBajVw?= =?utf-8?B?R3NRdmdETms5eG5BeEt5SWQ2Ull1NDUveGdIRkQwWnVMMGdyV2IrK25RMHpz?= =?utf-8?B?NlVTZ01NUit4Z3JCUW1ZV2ZwQ3ZMSktnY0J5U1FZTThTQWRjdWhvWnpoTDFh?= =?utf-8?B?UFRIRmFLQUh4aDN5Q3FXR2psUnNac2RPZUdNTGdMWFRiRG9Rbk1QVVB6eVlh?= =?utf-8?B?MUpZbnJETHRXNmhzYXNvbk5paVB5dkZxV2ZNNjBNaUJNUWRsRnRJNFYxYzRv?= =?utf-8?B?b3d3d1pKK2wrMk1KWHRBZ0RzcHVsbDFhUjBtNEJESlpiRnlkZGxHcjg5eFBC?= =?utf-8?B?ZmNjaUNQTGU4UlQvZlI2VnNuVjg5bFIxQlRXSTJ3N2QzZzR2ZUFwcG1XQzZz?= =?utf-8?B?SnJIdVNobkg1WCs4WDA3UE9ScGY1Q2NYMmUwMTlpVGdJa2I1Y005NmhpL005?= =?utf-8?B?TWZPZUN2aXFoZy8rSWgzYWZOc0kyclducitrWU5UUEJFZE10Uy9ER1FHVE1O?= =?utf-8?B?NXJHTEhIckFqWk1XNGZyc1lIV1BKTk9QTWhhTzYvZW43ekF4dWdkUTRCa3h4?= =?utf-8?B?cjgvZjVISjIzU203NTlNNlBMalFrVlZMM2NPVVprTmVoeWV4bmFuekgyQUo1?= =?utf-8?B?RzFKK1NHbGdZSjFGclpuR1ROcWJRZ1JpdzhKdVVtZFNvSjNlcTFoTWFyc3k5?= =?utf-8?B?dDRCcXdoYXBzSkRrbEdlT2gwdVQzbFVJVjA5elVpZy9yc21CTXR3bzdlbUVB?= =?utf-8?B?NStmM1g1R0wwenRQdENnd29YbU9TdVJ0SGk4di8yM2JoRzk4aGZQbWVlNk1l?= =?utf-8?Q?6f5Mi4B/HQ2tlKciMzIo8BY/w=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkNKT29vWmRqbFhlVk9GbTN5eHZxRmdkQy9HM3c3TTFHWWtRVnRQcWE1VW1T?= =?utf-8?B?ZVVwQkZTSENBajJNRnlRTzhpb1pkYjZQWGpnM1RPMnh2VFdSQnhOYThsbXIr?= =?utf-8?B?ZEtNNndNN0d0cEs1eDZ1dEp3WS9DU2ZwRDBaM3VUSTBZUzlWekxxVkRSS2ZQ?= =?utf-8?B?K0tZRjVIU08zVnRpaGhwM3RjWHg2RDJFOTAySWFKeUNQTFIycmE3eFdLQ2s2?= =?utf-8?B?VWY4UWxuNTNiUEc3Q0hVVzVLZUxkWFlLMmU0VEk5NFFnN2g0L3RnNzNkTlZZ?= =?utf-8?B?MUNjZHluMXFmUGJsVDNLdnh0WGlaVytSZmZEVXkwRGZsdHVXM0N6SFNkUEpF?= =?utf-8?B?dDNCYmx3a1AvOHlXUjNsVW94RzBrdXdPZVBhbWNvc09JUG9Wa25yZ0k5dC95?= =?utf-8?B?ZlBWNFZKL3BhQXhPeFpxN2I2THRTZ05GV3QxRjM4aFoyaWxjb1FzNUxKd0M5?= =?utf-8?B?bGkrenI0UE52VmQ1SG9QUXJxUVJUTDJpMFdPbER6Q3F3blVoWGk0NUFDNEFE?= =?utf-8?B?Tk42RzZuQjRVQXZsSlRWeUFsc2g5K0RvSVUwZEl1NmFiSktIZ0d6MGlWb2c3?= =?utf-8?B?OVZ5T1VZOFRNQkoyM3BVajQ2eHJHWVVWNlFRRlQ4S0tHN2tQcmVyV0ttUGty?= =?utf-8?B?enJpVnpDRGJ1Q01qU0haMXQwdU1GQkx2OW5oUFpYL0IrUjFZN3NMRWJJc0lL?= =?utf-8?B?TTlEY3MyNjhnWTl6eXcvSUd0UHp5L29peVdUSVgvZkl4UHVRcDdSTmlUR3Vi?= =?utf-8?B?a3ZKWTBsRFNFa2U4WmZUc0hnOHlHOW5MZWVYMVFPbkxxam04Z3RrMWg5NDFi?= =?utf-8?B?bFNGZFFDNThJYmErLzVPUGpGUWo4SVhNdi95ODhGWUh6MCtibS9OMFFxcGNs?= =?utf-8?B?OS9ITUllSTVoUlYrL2REaGIybGZrcGFWL09RRmV3dmhNOTB5TGl2MHFIRlpD?= =?utf-8?B?MmovVklKT2VqL3c0ZHNlQUtXT2sxaFJmVjhwRXlySy9GTHdyRDRwTllObkpJ?= =?utf-8?B?WS90Z0pHVzYyK2tHMWI5UTNodGlwMW9YbkZjbGJPQ3UycTZqNTlCWi9PMlcv?= =?utf-8?B?Tzl4UlRwZWdxNE1kaWlKOTFiVW1CbGV1N0tOeHI1SXplZ3VYRVBnTysyYUlR?= =?utf-8?B?NTFucDBqT21ONElJeDhBeE9tTUI0RURreTEzR3dxZTVNL25LcnZOdlJidUtK?= =?utf-8?B?SVhGMHdPczYxZkpqeWlob1lDc0FZU2ZaY0ZRQ2xlNTFVaWoyYXBHMHF6TDBE?= =?utf-8?B?Mmk2Y2oyWnlYY3BIVkVteDJRTFhmWHVvTUlZUjNEQjBna1NkY051c205UEFG?= =?utf-8?B?SWFtNzkzYWw0NmFoN002WVczem55Q3hLZENPY1dsZzVGVnZ6Qkl3YTd5bHFF?= =?utf-8?B?ck0yZ1FJWjRBS1NOVGw4cmtwZUxIY0hDV0d3TEczRUFWcUM3djNPelJHRjlV?= =?utf-8?B?ZXU2eXJqS3o4ZVp3OVBvRFo0RWRHWXZuRjRyOFZKZDN4MWorWUhJbFpna0VC?= =?utf-8?B?V2tlblVBSXRvMFozWnk5ZElJRjhRcitOZFB5M2p3Y05HbGVsOGFUZVFDSHhi?= =?utf-8?B?TXgyS0JKNjFkY3FoOGo5ejVXNHU1ak1YRElrNk5CcS9qSmV1blAwNUJOTUg3?= =?utf-8?B?MlByeVJSUFkrR3o1dnJhamhkSVpaMEpmMHVIZGJQL0o1dG1nMUlYalQzdkJS?= =?utf-8?B?cFY2b083dHIxYSs5QndBUnM0aUgzWGtFVTBXcFRaaXhTUmVjUXUxUEhnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4eb1aec-066d-447b-e50b-08dd476e6e1b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2025 11:56:17.7921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0596 Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] libavformat/oggdec: Allow first parameter in ff_vorbis_comment to be a generic AVClass struct X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Romain Beauxis: > Firt argument in these function is only used to pass to av_log. This > makes it possible to re-use them with any type of AVClass struct. > > --- > libavformat/oggdec.h | 5 ++++- > libavformat/oggparsevorbis.c | 4 ++-- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavformat/oggdec.h b/libavformat/oggdec.h > index 43df23f4cb..6177254fd2 100644 > --- a/libavformat/oggdec.h > +++ b/libavformat/oggdec.h > @@ -136,8 +136,11 @@ extern const struct ogg_codec ff_vp8_codec; > * so it needs to be writable. Furthermore it must be padded > * by a single byte (not counted in size). > * All changes will have been reverted upon return. > + * > + * @param avcl A pointer to an arbitrary struct of which the first field is a > + * pointer to an AVClass struct. > */ > -int ff_vorbis_comment(AVFormatContext *ms, AVDictionary **m, > +int ff_vorbis_comment(void *avcl, AVDictionary **m, > const uint8_t *buf, int size, int parse_picture); > > /** > diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c > index 9f50ab9ffc..62eb8bbf70 100644 > --- a/libavformat/oggparsevorbis.c > +++ b/libavformat/oggparsevorbis.c > @@ -88,7 +88,7 @@ int ff_vorbis_stream_comment(AVFormatContext *as, AVStream *st, > * and reverts its changes before return. The input buffer needs to have > * at least one byte of padding. > */ > -static int vorbis_parse_single_comment(AVFormatContext *as, AVDictionary **m, > +static int vorbis_parse_single_comment(void *as, AVDictionary **m, > const uint8_t *buf, uint32_t size, > int *updates, int parse_picture) > { > @@ -146,7 +146,7 @@ end: > return 0; > } > > -int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m, > +int ff_vorbis_comment(void *as, AVDictionary **m, > const uint8_t *buf, int size, > int parse_picture) > { This is wrong: ff_vorbis_comment() really requires an AVFormatContext* (see e.g. ogm_chapter() or ff_flac_parse_picture()). Anyway: Your comment could simply say "a logcontext". And the variable could be renamed to logctx. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".