From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 2/6] lavc/av1: Add common code and unit test for level handling
Date: Mon, 7 Aug 2023 17:45:00 +0200
Message-ID: <AS8P250MB074429051CA4D69F2E3E7CAE8F0CA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <35b888e3-6e1d-1b43-428c-23a002720139@gmail.com>
James Almer:
> On 8/3/2023 3:01 AM, fei.w.wang-at-intel.com@ffmpeg.org wrote:
>> From: Fei Wang<fei.w.wang@intel.com>
>>
>> Signed-off-by: Fei Wang<fei.w.wang@intel.com>
>> ---
>> update:
>> 1. Rename libavcodec/av1_levels*.
>> 2. Use array instead of handle for AV1LevelDescriptor.name.
>> 3. Compile libavcodec/av1_levels* only when enable vaapi av1 encoder.
>>
>> libavcodec/Makefile | 1 +
>> libavcodec/av1_levels.c | 92 +++++++++++++++++++++++++
>> libavcodec/av1_levels.h | 58 ++++++++++++++++
>> libavcodec/tests/.gitignore | 1 +
>> libavcodec/tests/av1_levels.c | 124 ++++++++++++++++++++++++++++++++++
>> tests/fate/libavcodec.mak | 5 ++
>> 6 files changed, 281 insertions(+)
>> create mode 100644 libavcodec/av1_levels.c
>> create mode 100644 libavcodec/av1_levels.h
>> create mode 100644 libavcodec/tests/av1_levels.c
>>
>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
>> index 3c16b51462..a6b2ecbb22 100644
>> --- a/libavcodec/Makefile
>> +++ b/libavcodec/Makefile
>> @@ -1319,6 +1319,7 @@ TESTPROGS =
>> avcodec \
>>
>> jpeg2000dwt \
>>
>> mathops \
>> +TESTPROGS-$(CONFIG_AV1_VAAPI_ENCODER) += av1_levels
>
> This encoder does not exist at the point this patch would be applied.
> It's introduced in patch 6/6.
>
> Squash libavcodec/av1_levels.c into patch 6/6 (Its first user), and then
> add the test in a new patch 7.
Alternatively, add the file, but without the Makefile parts, which are
then to be added 6/6.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-08-07 15:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 6:01 [FFmpeg-devel] [PATCH v3 1/6] avcodec/cbs_av1: Add tx mode enum values fei.w.wang-at-intel.com
2023-08-03 6:01 ` [FFmpeg-devel] [PATCH v3 2/6] lavc/av1: Add common code and unit test for level handling fei.w.wang-at-intel.com
2023-08-07 12:40 ` James Almer
2023-08-07 15:45 ` Andreas Rheinhardt [this message]
2023-08-03 6:01 ` [FFmpeg-devel] [PATCH v3 3/6] lavc/vaapi_encode: Init pic at the beginning of API fei.w.wang-at-intel.com
2023-08-03 6:01 ` [FFmpeg-devel] [PATCH v3 4/6] lavc/vaapi_encode: Extract set output pkt timestamp function fei.w.wang-at-intel.com
2023-08-07 20:22 ` Mark Thompson
2023-08-03 6:01 ` [FFmpeg-devel] [PATCH v3 5/6] lavc/vaapi_encode: Separate reference frame into previous/future list fei.w.wang-at-intel.com
2023-08-07 20:28 ` Mark Thompson
2023-08-03 6:01 ` [FFmpeg-devel] [PATCH v3 6/6] lavc/vaapi_encode: Add VAAPI AV1 encoder fei.w.wang-at-intel.com
2023-08-07 21:21 ` Mark Thompson
2023-08-10 2:54 ` Wang, Fei W
2023-08-13 21:43 ` Mark Thompson
2023-08-16 7:54 ` Wang, Fei W
2023-08-16 20:45 ` Mark Thompson
2023-08-15 13:59 ` Dong, Ruijing
2023-08-15 16:49 ` Neal Gompa
2023-08-07 7:51 ` [FFmpeg-devel] [PATCH v3 1/6] avcodec/cbs_av1: Add tx mode enum values Xiang, Haihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB074429051CA4D69F2E3E7CAE8F0CA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git