Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v7 3/7] avcodec/webp_parser: parse each frame into one packet
Date: Thu, 7 Dec 2023 18:42:58 +0100
Message-ID: <AS8P250MB0744273A3F1FD08503DE97198F8BA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20231206013505.57654-4-thilo.borgmann@mail.de>

Thilo Borgmann via ffmpeg-devel:
> ---
>  libavcodec/webp_parser.c | 130 +++++++++++++++++++++++++++------------
>  1 file changed, 89 insertions(+), 41 deletions(-)
> 

According to
https://developers.google.com/speed/webp/docs/riff_container#extended_file_format
metadata chunks are stored after the image data; if you split the data
into packets, then the metadata while only become available for the very
last frame, although it pertains to all of them. This makes your
approach unworkable.

Additionally, the WebP muxer expects animations to be contained in a
single packet, hence the warnings from Michael.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-12-07 17:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06  1:34 [FFmpeg-devel] [PATCH v7 0/7] webp: add support for animated WebP decoding Thilo Borgmann via ffmpeg-devel
2023-12-06  1:34 ` [FFmpeg-devel] [PATCH v7 1/7] avcodec/webp: move definitions into header Thilo Borgmann via ffmpeg-devel
2023-12-07 16:09   ` Anton Khirnov
2023-12-06  1:35 ` [FFmpeg-devel] [PATCH v7 2/7] avcodec/webp: remove unused definitions Thilo Borgmann via ffmpeg-devel
2023-12-06  1:35 ` [FFmpeg-devel] [PATCH v7 3/7] avcodec/webp_parser: parse each frame into one packet Thilo Borgmann via ffmpeg-devel
2023-12-07 17:42   ` Andreas Rheinhardt [this message]
     [not found]     ` <53478080-5F0E-489B-828D-9EF1F22F3D4F@cosmin.at>
2023-12-08  2:02       ` Cosmin Stejerean via ffmpeg-devel
2023-12-12 12:14         ` Thilo Borgmann via ffmpeg-devel
2023-12-06  1:35 ` [FFmpeg-devel] [PATCH v7 4/7] libavcodec/webp: add support for animated WebP decoding Thilo Borgmann via ffmpeg-devel
2023-12-06  1:35 ` [FFmpeg-devel] [PATCH v7 5/7] avcodec/webp: make init_canvas_frame static Thilo Borgmann via ffmpeg-devel
2023-12-06  1:35 ` [FFmpeg-devel] [PATCH v7 6/7] libavformat/webp: add WebP demuxer Thilo Borgmann via ffmpeg-devel
2023-12-06  1:35 ` [FFmpeg-devel] [PATCH v7 7/7] fate: add test for animated WebP Thilo Borgmann via ffmpeg-devel
2023-12-06 22:01 ` [FFmpeg-devel] [PATCH v7 0/7] webp: add support for animated WebP decoding Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB0744273A3F1FD08503DE97198F8BA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git