From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4007147440 for ; Sun, 8 Oct 2023 19:05:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 02D1D68C9B3; Sun, 8 Oct 2023 22:05:15 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2108.outbound.protection.outlook.com [40.92.73.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 257B368C862 for ; Sun, 8 Oct 2023 22:05:08 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HKBuJeC9lfuGCKM7PFijbUHwNljBsqtPeO6XBNOUQNIvO1efKSZKCaGlZx5gdL9YjfkVpgAQNjeJXClEywSIGl4Xa/DCnnqJxKPZFRkLlvTgVxfM0yxNI2r24idtKR2RUgfu4VjyXnIAxDX0FT38eeFZjq7unIfjAOgAKfes5BwTHIZ+A5T497UzNECxPL9ZSt5Upbbc5nPyUnoHndOWVGcBkF0oEoP/v2intBPYfVVCDsx3jhpGMi8eWD1AwAfveoeZLFhwthP7pF2ZS9Fa54BCb+RtlAIBbuX+mGJuHvHaODZBYo2uYPw8X7snwlfcPY70er4Ft9NO2gVT1dYoBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t/HG0sdf4V/tLXdUg6kZREJCPgIFf3BqORXluwRxK78=; b=RV0vNhWymAt/ey8ZlwsuD8qKhbGC+L5e8BJWZfilyQKlb0sSTD20c0SNCUdvDWMwsXygxRsPc4ehfgk+bTdJ61s33/9AF22n9c8ANshMYT68QEIN1Hj4Zp8EOojOXvuwSfdKQ3U/9jY8gl1C+VLSZMDIVk06wRriGlVcaCoqp7BmCJc+uzqTmd3JaLRReQBuSu98T4aCPKux0yyTHb+zvxjhqJgS5zJYnf8tetFfDwob5VX8l6sWTIoHvYsCsWTenx/MtkpLorJvOCh8zwdZrCZif+v14++lCE/xzWwY+XNUeTtrCQFBygTgPbwXbwLbEpmjFxmtK0xBcVZ1PqODXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t/HG0sdf4V/tLXdUg6kZREJCPgIFf3BqORXluwRxK78=; b=rWS/qCMQYz+pFvWTLFpXGoSNukpn4yOKcyojGcobLZk5rit8ILtADuUVapobFVMg65ulv/R43+9vx2+nvBUkDLDqogCotISrXJblWNk9aSV79zcvQipCNSFRI5+3EX2XB3vJM2g/QDWFQ/WiQZPwS25thf8p6mGucBlf64LYCeAGOBLVWV1o1Hanhu7uEaelxZmEdlalsLCpPhUm1xfAAG8bjCw2AYT3XVychIJNtPMZp/hiVyBpY8yWEtPvBj7xGlQXBBoTRAO2IPkWT9uneHAEu0nGxbHcAkbuNaNq+4GcS47I4iIGSPLWnDSRcrnlEwq44eBNt5uMnWIX+Y5iKw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0176.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:275::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.36; Sun, 8 Oct 2023 19:05:05 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::3126:4823:194e:6f86]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::3126:4823:194e:6f86%4]) with mapi id 15.20.6838.040; Sun, 8 Oct 2023 19:05:05 +0000 Message-ID: Date: Sun, 8 Oct 2023 21:06:19 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231008163648.GT3543730@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20231008163648.GT3543730@pb2> X-TMN: [6XvOI1MxELAgkO1s4/u0tbcXonzmrJrv] X-ClientProxiedBy: ZR2P278CA0055.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0176:EE_ X-MS-Office365-Filtering-Correlation-Id: fa031440-68b7-4ae1-f976-08dbc8317b0e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N2Qd4Qexhx7+5CNOwhqxP30OH259ddAEzNQwGAuG/mCL0Yz4X1pox/q5em4n7WORbWbgj3vE9ucILsuxOjY3lvswI7u7K3Kl1BDLFfd8hxQdPqgkCYSOa7tiJc1Wfv2YM+0rX24HBWetV7zCQB+jXGGPxYlvNvKdzJe9W6pIfRNVTUlFaVy/s0e5tLIdN7cerOeR8VD1wsWd5FA8nLOB6d9fYcMDdGyt1AOhVIboFhfJ2OO9rjokCgUXynGz4+MBCa31CHEfG2R2W92mscBcqZ+xyF4OjnJCJ5DBd91DIzxF/I4crVjuHmMu43O5kqGiaydPXT//TMkqr9PD2Pwq1HnUJy7jvzA06J2bvUn+i0yczoxCWWnFfVxiwy4eLiZsvRsqcbcMvbuJgGl3ffCznvbmXPg+OISiluXpY+VfxlRoE+Tw/+ElY3BnCDvsH8IBoP0qWHHKYwKNqBYPvx7LzQLR9vOwtATHDc6EzVhmskAlNb1jg9OpiYMFLqaO607rDQheEbcIx8QM/grSyadaVXHNoHUql01mihyp34rlPdG17bOTLasPmAK89nFXjn0JjRQE1nIPp0UoVoGcVuk+Ta+w63u0ZOuTCeDt3lKlxb8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEhxdCtzdEpPbWUyYWl6b3phMnExbG52VlpuaWUzK29CRWNXSkVhVlpuaTFl?= =?utf-8?B?QloyNm9hRG1hemNLTENXWkl3VHRuZG9kQ0xsRjgrSkFNWXR2b09kZXhPR1JZ?= =?utf-8?B?TVhCdDVIdC9zblNkcGY0ZXdxNy9wV2R5bnVGY1RGNXlteWs3MU5DRi9KWmZa?= =?utf-8?B?NjJqT1dPcmNBdHNmaW1tN2pydXcvZHRyZ3dDVUZ3YXMyN2dyNWs1WUxCcFV2?= =?utf-8?B?Rk9sQUdlbHJGZmV2RW4vK1JEUjlLMWlaNTducXJyYnhiWU9JVWc1TzBiTzFQ?= =?utf-8?B?bHM4eHpBUmw1amgyQzFqV2tDSnZXTXA3YWFVS0tCWXJoeTZKT3NvRFpoYW5h?= =?utf-8?B?SXg5MEJJREw2Z3FuZGNnOFUxZUFKY3hWUGFWT1l0NUk1bXB4dmlLQ1ljNTJX?= =?utf-8?B?TlVjb0Y1cFhtM3E3R2JJbjhIY0dsL1ZFdElldUpUNnE3ZWNqdTJRNmFROG5R?= =?utf-8?B?ZHUya3p6bTJ6UGdSVGJ6NFBDeUdCc0UyOUdDSFArNU9ieVF1Y0tlRE9icDVM?= =?utf-8?B?ZUdQd05VblZyUnJLOTJGSXF6OGI1cENPS2ZiT2VsbkpJUGFib2pUZVZoTDBi?= =?utf-8?B?NDErWXRObEhzY3NvUExlQWFMK2VMSTBvSnl6N2Q0cGZnSGhaWmFFc3FQQkdI?= =?utf-8?B?V0QwL1c1dng2eGtZUFZsRmU5Z2xxS0c0V0hvTklhcUFFMTdjOXZ6cFIyQ3g4?= =?utf-8?B?N3RXVGF6d3B0WXRXMjJqWkRoWnpFMWVBRm9vSVNtSzBkYjVkMEovZ1dmRml5?= =?utf-8?B?SHgwMXFLNllmM2pxZDFxVHpSdEtJNDR6ZVFUMUR6TnlNYXZFVzRPZkpKa3N6?= =?utf-8?B?RG8rUUYzTXl0OHFCdURqaTM1b1pncEpUT0V6eXlYS2h1T1lnTGwyS2JzbXFF?= =?utf-8?B?SlZlK1M1Uzk1ZjdaeEc2KzJyckJJekFnblNkajE4MENQU2JibUliMXZrc0VB?= =?utf-8?B?NXNiRDV1OVhHSnBXSHM3UzhuaDZhUHIxSE5NQUh5c0xpRE5hSVVrMktOQyta?= =?utf-8?B?SUxONjVvWlRhOGRLRWE2cmdGRGNYb0c5YzJVYlhQOGsyaXBYbklVTDE1VTFM?= =?utf-8?B?eWsyQ21kZklZcmJOemxRa3VYUEwxTDlIYWswYmRDSlY1eG9CY2MxeXlMZzUz?= =?utf-8?B?eVVvZVAvV0NkNjhxZCsyUEZCbm55VktVdlBLVFpQTklEYkN0Z3ZKeDZGMUJn?= =?utf-8?B?VTRaTWdhQU15MnJLRit2cnNOeEdIR3YyWk1NNHF0ekthTFp3Y2hOUTcxRG9R?= =?utf-8?B?czdsZlJNcU9FK25VUUx6QWVyWlM5WWhFbTcraXNBQ0VtVk9NY2dJYmV3bjBo?= =?utf-8?B?ZWxYVDlSVFhPRkpXbjVYaEVkSzFkUU5tRnJrODZPeWsvR0RBc0R6VzcxWWpC?= =?utf-8?B?ak5aeHBiSkk3REJ2K28xQnlZK3EyUi8zSk1lY3pJeHd4dlNjZUFqVEFVN3B1?= =?utf-8?B?d1UzUThWcHBXRW5NWkVPcVlKcHhGNjBtYVBOY2J0bFlKVjY5Y25XdWROSzlt?= =?utf-8?B?OWYxUU1YWXZFdklseUx5WHQ1U2hPcGZzWXVmSmRmRnNGTmNmMGF0aGgxbHVl?= =?utf-8?B?ZlZjYVRERDFET3lkczh1L3puMjBnc1RTT2dIb3A3YVZTVWYyYUx0cHNFc2wv?= =?utf-8?B?L21jU2pFOTYwKzNJYzVRRWFYQisrTTRzb0tzcDNIMExab2RpdFlIVHpnRDdo?= =?utf-8?Q?qkaJBUtCTHgT/bGWn5Qp?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa031440-68b7-4ae1-f976-08dbc8317b0e X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2023 19:05:05.7591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0176 Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Output palette as stream side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Thu, Oct 05, 2023 at 02:36:52PM +0200, Andreas Rheinhardt wrote: >> This is simpler implementation-wise (it avoids an almost-always-false >> check in read_packet and decreases sizeof(MatroskaTrack) by about 2/3) >> and makes the side-data available directly after read_header. >> >> It also fixes the Matroska analog of ticket #10602: If a Matroska track >> has a palette, said palette will be attached as side-data to the >> first packet of said track and most likely, this is one read during >> avformat_find_stream_info(). Yet if this packet is discarded because >> of a seek performed immediately after avformat_find_stream_info(), >> the information about the global palette will never reach the user. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> Ticket #10602 can unfortunately not be fixed in this way, >> because avi allows to update the palette mid-stream, >> so that the palette contained in extradata must not be >> exported via global side data due to the semantics of the latter. >> >> libavformat/matroskadec.c | 39 ++++++++++++--------------------------- >> 1 file changed, 12 insertions(+), 27 deletions(-) > > breaks: > aletrek.mkv > > probably here: > https://trac.ffmpeg.org/attachment/ticket/5071/aletrek.mkv > This is actually expected due to the recent changes with respect to side data: Basically every piece of code currently only looks for palette side data in packets, not in stream side data and if the latter is not injected into packets, then it is available, but unused. This is the reason I opposed deprecating avformat_inject_global_side_data(); see my reply to James latest iteration of his patchset. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".