From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40F6546765 for ; Sat, 17 Jun 2023 01:41:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C513768C357; Sat, 17 Jun 2023 04:41:32 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2015.outbound.protection.outlook.com [40.92.65.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0ED4068BE41 for ; Sat, 17 Jun 2023 04:41:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QnCUqex32vvKmog5kVSUg0LDG20OUmxJYDJNx67Ovx6ALkBfKk3oeYO6+YyBJl5c9DU4U+lLBA5xv4WhMhxRbtscWuaWubJKaraxMWTNgUVo0cMCK7DNVGTS262iHfSFqJrCMv+e0jp5OG4+O5MS2+sZlv6kNrKUScIbm3FzrCNMTISfDWSkylHXDQyBkF4WrxN9Vcq37Cdh9h5nar8fWnpmoA8nKgrdvX/jjKUYO715MvpQ+nbxEwgiWcDNOcPLSrb+Ruc05oaAI2/pV2c4jYClhP5F5kkgkxQWN8NxV7AmOw8z83XHmx8IirMWcGGOaBAtp9QHWYXXmrIGcOABjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tph0IWE8PDahcnz6PMfwa5fGJQUk0GSTPmAEvf2Is/I=; b=lRsLJ2Lyu6oG7dkbVPlZjHMtqjfusB9DAkmtw+i0laCKngi7qr5tHP/ee0136JRwRzx16Wuh88yXNrukCsdkiFWcG2mPUVT4ouzIlKzGJrg95exVm31+hlBwwoCuyAqjSZhzDLliK2lRsJgemDaz9m7p2mZyr7OgWczDYjNsRIW4I0vWqoi7FsMP3TyqYDlIcVa8ibJCFkRh5OyEONqSi0e6vCTmYWAU4q3DYzMt2eKdMiId1H7r32X4kYu8noedriIrxk82yQPrDoPM6/ZqXm7PLfAjlqDiKzkoCfTuAGsHr/53TBtNbNYkc9OMUmTEe6B5dUpXdh/NjXzNJ662ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tph0IWE8PDahcnz6PMfwa5fGJQUk0GSTPmAEvf2Is/I=; b=adeoyHYO1w/OKINGojwdg9Zv9IElpWb+GhKtC5UtlrVptVxCcxP2MAuttJyQnD2BgKhJTMrZ404Vt93dFII8gUlTzNtAOB547oKi2Ow201NESUy+z6R7W8DMB5noo8gDnANvWEmvNgkh8qB0Rew0IyK4LB/ohEbT2rqL1PGhu3kx+6vFYTQG1UtaT4g547mOuNHWFO6yvajefPpowc1XUMkBD74AwoRvFyEPa6e+MQu6bcu3D4vMGaE3ZgNsDMdB5HJF4ThBQAEcMIZNQYstETXLpRHon3aRCSZg51mpcPZVdFU+LYSH1ulipbch6ViHARqonMhVb24k+nAgbFFYUg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0279.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.41; Sat, 17 Jun 2023 01:41:24 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::a38:e93f:c7e0:f473]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::a38:e93f:c7e0:f473%7]) with mapi id 15.20.6477.037; Sat, 17 Jun 2023 01:41:24 +0000 Message-ID: Date: Sat, 17 Jun 2023 03:42:12 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [UlB0hsTGCsZufViJSvHnox2uvHWBpBUy] X-ClientProxiedBy: ZR0P278CA0182.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <06942abc-cd55-1e0c-020f-77a6e3a31d8b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0279:EE_ X-MS-Office365-Filtering-Correlation-Id: fc38022d-4ad2-4143-317d-08db6ed3f59c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8bsrXnmm2rgJHbvvbZN2D1kCk3cZ56MM+F3hpHmZB8bY3Ed6wY/pVXbGbS/VMUkLzCOq0RVh2HTMDWgLRmA0CbM9nHewDRNUrxynyFBQIyWeAWTCetj2a7wFB+Negbvf5upwmTUbqbZ0fLrotMWfwYnSJUdEW5l06vENsfsbMhT8y0LSc1ddsXb0yvofV9DveagA3Cfbws93woi9W8GGcYUYPnqOznf6tFaV+6zRn/DA1SerADF6GiNygHG9l+TN+jkF9DtmHYbZi7c66OZo7EP2VWxMDD5OYELniI4J7NehsbrcGRvYXDwDZWRJkqqWam5NG87hMpjPEjBnU1HgdX3O+J/z9f/oxuVdeIH7Ib3yW/qg+R601HePnXe7YFxkGMiv6ag0U8gPr+tQnjL1UJ/M4z9khQW1oaW+y/BflHMkFDaqVoJCTPPkUJGxGkIWcTbcleaUbzAmMXnNzfP7D2IAM2rnePGYQj8UpAmST4B6GdKBzjhbwp+Y6VA8/1Jaxa+2eqdP9wMWJwVqtqoYI4kKXQMtH5M5ZDG/y/jllGnI8l/+DtDlF0NkCZReKBNCYgjvzGNiOy/hJmJmqlWagYptddaDQdOU0jfHwbmkic4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVB4YzRack1TejR5MmsrMHFkRURmRnpJR3BqNFNtZlNBS1hOY0w3RUZibjJm?= =?utf-8?B?Q255R0hTQXVvWjdRcTJYRHkvZGhNYWlVM2d6Sy9JaU5ZY3FLNGNtbWpJNHY1?= =?utf-8?B?WXM0UFcyemNDWm03RVMwcDJjQ216L20xQThNcmpWUWMwNXZUZkkwR0IzcGh1?= =?utf-8?B?cDRxZDkwTUowMWF3bTRMYUQwaEhHN0FlSTB1RW42N2NWSlFhc2RkVGtrcVNj?= =?utf-8?B?b1BsRExyVGFyMmVlOEo4czVXT0lMWUNVTXB5eUhzRWozZDhIQWZ2c0VBYlE1?= =?utf-8?B?Z2hsWmdpQnZOUWE0bFBwRU9oZlZoSElBOC9uMVhBNkFXNHRzcUtEY0RFdG1W?= =?utf-8?B?bWx1NXp6K1A0bHcydEFsV0U2c2g0VGczRHhvWXJhRFg1eEo5RE9XcG1lMDB0?= =?utf-8?B?dmZIVU5BNjRJMzJselpMMzNuSHJWdDI3cDJ0eG84b2ZuSFZ3Z0JlaFpjWmtL?= =?utf-8?B?THgrVW5UWUhFN0o3SlI3dW03MEFNZDlFTFFuK2lMS0N6d3VZQzAweU9iV1Qz?= =?utf-8?B?djBITjdlcmZ2VkR0bWtQL0VmQUZCNUpPNjU4RGFDTCtVZUJVZ3QvZ1JwQnZs?= =?utf-8?B?SURJbWZUUkp6OXU3WmRZdEc1NW96a2tWTVhIYVJnNDVsdTExNXBjaENUQWtU?= =?utf-8?B?SWR1aG41QkVTTzU5OHdSaC9BaVhKME5EbVpWSk5QV2lwR0lGL1VMcHJCaHds?= =?utf-8?B?YllSWHpWdS9Yc3hha1l3d0tpYlhEUHV2NzhPWEdPZThnTzVhUW5QZlVQMTdF?= =?utf-8?B?TXJ4T1RTb2ZRUVg3SWw4V1dueFRENzdtQzZhYjlBR3VacTBaMDU0eUdkMC83?= =?utf-8?B?WWZFcjc1Yko2RE9mb3pPSzloeVhTL3ozMHZwMjUrNC9mWXAzdXdIQWQ0c1Zn?= =?utf-8?B?Wi9oWWFlSmlJaXVjUkhRNEJNcjc1NWdIdXhmUG8wOXdLWlBSSlpJSW1vMU9E?= =?utf-8?B?aVJGWUxGeVhzWmVEN3NKZGhqMUVwallDY295RzhhbHhLMlF3dUNhM0xLVE1J?= =?utf-8?B?MVkzdXdrK3F2TlgyRUppL3BBWGtQMm91SzErdGpTSGc0bWhCNWhLMFJmZUYx?= =?utf-8?B?aTZqcWFRcUVTbGdybURKZktIVEdWYVhHRnpHLzhQYWRORWdZQ3N3MnR2Ritn?= =?utf-8?B?Uy9HMUQ3N0QvMCsvNU50Tk1GVXRDTW1Od29aTjd5TWpnQ3BaM01sck5HY2RC?= =?utf-8?B?MTRzTmhhWDlsRURXdmtGU0FuOWRMK0N6aTVKS2VZSmNuSVdJT2xBaEdBcGd3?= =?utf-8?B?ZFhBTi84SHVqb1ZGSVU0a1FweWRpNUVScmJEbXV3bjRVQXQxdm5GaEZ5eklm?= =?utf-8?B?WW5IRFRPWXlmMmtMQ05RTWYwdVJFTE84R0RGZ3pSVVV0aHlsZVlSNFcrbWJ5?= =?utf-8?B?T0JBZVpnQmZ1TFRqekIweDNnWkhtUzNkMVZGT0RkdlVvY3ZadXpkYVlrT0Fx?= =?utf-8?B?MWVEd0l0a0k0djV1ZTRMZDQwSGtHeWVlYzllaUluR1JNSDBESUhUNGVWYW1l?= =?utf-8?B?bi9MV1FQcUNOUzU4bGVPcVZTdlkzUjVpSXgwL1k1YzF0ZExoNXJOQTUyTEY1?= =?utf-8?B?aXNsbklDQlNjS3c1cHBxbTNoU01xYThnUjRrd2NQekxVek9NRndKcUswK2VK?= =?utf-8?B?QUlMUW1ocWJ1SDRsZU90Q3ltUmJsVWRoNXZQdmFUbnFMWXhlTjdKTzVsR3dq?= =?utf-8?Q?U+sskI2bFE/SZTQ04j8I?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc38022d-4ad2-4143-317d-08db6ed3f59c X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2023 01:41:24.3150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0279 Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: asivery: > Hello, apologies for bothering you all with this, but if anyone could take a look at this patch it would be great. The only other container that supports ATRAC1 is AEA, and it's not that good of a format since it has no magic number, and therefore is easily detected incorrectly. > > Thank you in advance. Sorry for having missed this. I will look at it tomorrow. - Andreas > > ------- Original Message ------- > On Monday, April 17th, 2023 at 2:27 AM, asivery wrote: > > >> I'd appreciate it if someone took a look at this. >> If there's anything I need to change to make this patch viable for merging, please let me know. >> >> Best regards, >> asivery >> ------- Original Message ------- >> On Monday, March 6th, 2023 at 7:51 PM, asivery asivery@protonmail.com wrote: >> >> >> >>> It's been added recently. Here's the definition: https://github.com/ietf-wg-cellar/matroska-specification/blob/master/codec_specs.md#a_atracat1 >>> >>> ------- Original Message ------- >>> On Monday, March 6th, 2023 at 7:39 PM, Paul B Mahol onemda@gmail.com wrote: >>> >>>> On 3/6/23, asivery asivery@protonmail.com wrote: >>>> >>>>> Signed-off-by: asivery asivery@protonmail.com >>>>> --- >>>>> libavformat/matroska.c | 1 + >>>>> libavformat/matroskadec.c | 2 ++ >>>>> 2 files changed, 3 insertions(+) >>>> >>>> where is this defined? >>>> >>>>> diff --git a/libavformat/matroska.c b/libavformat/matroska.c >>>>> index 90d94b65bf..37305a523c 100644 >>>>> --- a/libavformat/matroska.c >>>>> +++ b/libavformat/matroska.c >>>>> @@ -55,6 +55,7 @@ const CodecTags ff_mkv_codec_tags[]={ >>>>> {"A_REAL/ATRC" , AV_CODEC_ID_ATRAC3}, >>>>> {"A_REAL/COOK" , AV_CODEC_ID_COOK}, >>>>> {"A_REAL/SIPR" , AV_CODEC_ID_SIPR}, >>>>> + {"A_ATRAC/AT1" , AV_CODEC_ID_ATRAC1}, >>>>> {"A_TRUEHD" , AV_CODEC_ID_TRUEHD}, >>>>> {"A_TTA1" , AV_CODEC_ID_TTA}, >>>>> {"A_VORBIS" , AV_CODEC_ID_VORBIS}, >>>>> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c >>>>> index d582f566a2..0aa8e6f3b3 100644 >>>>> --- a/libavformat/matroskadec.c >>>>> +++ b/libavformat/matroskadec.c >>>>> @@ -2795,6 +2795,8 @@ static int matroska_parse_tracks(AVFormatContext s) >>>>> track->audio.frame_size); >>>>> if (!track->audio.buf) >>>>> return AVERROR(ENOMEM); >>>>> + } else if (codec_id == AV_CODEC_ID_ATRAC1) { >>>>> + st->codecpar->block_align = track->audio.channels * 212; / Constant ATRAC >>>>> frame size */ >>>>> } else if (codec_id == AV_CODEC_ID_FLAC && track->codec_priv.size) { >>>>> ret = matroska_parse_flac(s, track, &extradata_offset); >>>>> if (ret < 0) >>>>> -- >>>>> 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".