* [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist
@ 2025-06-30 2:56 Scott Theisen
2025-07-03 16:28 ` Andreas Rheinhardt
0 siblings, 1 reply; 4+ messages in thread
From: Scott Theisen @ 2025-06-30 2:56 UTC (permalink / raw)
To: ffmpeg-devel
This matches how the other libraries define their exported symbols.
---
libavformat/libavformat.v | 5 ++++-
libavutil/libavutil.v | 4 +++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
index 47d5ddcdb1..39aa185309 100644
--- a/libavformat/libavformat.v
+++ b/libavformat/libavformat.v
@@ -1,6 +1,9 @@
LIBAVFORMAT_MAJOR {
global:
- av*;
+ av_*;
+ avformat_*;
+ avio_*;
+ avpriv_*;
local:
*;
};
diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v
index fb17058df5..e1aab84554 100644
--- a/libavutil/libavutil.v
+++ b/libavutil/libavutil.v
@@ -1,6 +1,8 @@
LIBAVUTIL_MAJOR {
global:
- av*;
+ av_*;
+ avutil_*;
+ avpriv_*;
local:
*;
};
--
2.50.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist
2025-06-30 2:56 [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist Scott Theisen
@ 2025-07-03 16:28 ` Andreas Rheinhardt
2025-07-03 16:32 ` James Almer
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Rheinhardt @ 2025-07-03 16:28 UTC (permalink / raw)
To: ffmpeg-devel
Scott Theisen:
> This matches how the other libraries define their exported symbols.
> ---
> libavformat/libavformat.v | 5 ++++-
> libavutil/libavutil.v | 4 +++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
> index 47d5ddcdb1..39aa185309 100644
> --- a/libavformat/libavformat.v
> +++ b/libavformat/libavformat.v
> @@ -1,6 +1,9 @@
> LIBAVFORMAT_MAJOR {
> global:
> - av*;
> + av_*;
> + avformat_*;
> + avio_*;
> + avpriv_*;
> local:
> *;
> };
> diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v
> index fb17058df5..e1aab84554 100644
> --- a/libavutil/libavutil.v
> +++ b/libavutil/libavutil.v
> @@ -1,6 +1,8 @@
> LIBAVUTIL_MAJOR {
> global:
> - av*;
> + av_*;
> + avutil_*;
> + avpriv_*;
> local:
> *;
> };
Is there a problem with the current lists?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist
2025-07-03 16:28 ` Andreas Rheinhardt
@ 2025-07-03 16:32 ` James Almer
2025-07-03 21:05 ` Scott Theisen
0 siblings, 1 reply; 4+ messages in thread
From: James Almer @ 2025-07-03 16:32 UTC (permalink / raw)
To: ffmpeg-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 1187 bytes --]
On 7/3/2025 1:28 PM, Andreas Rheinhardt wrote:
> Scott Theisen:
>> This matches how the other libraries define their exported symbols.
>> ---
>> libavformat/libavformat.v | 5 ++++-
>> libavutil/libavutil.v | 4 +++-
>> 2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
>> index 47d5ddcdb1..39aa185309 100644
>> --- a/libavformat/libavformat.v
>> +++ b/libavformat/libavformat.v
>> @@ -1,6 +1,9 @@
>> LIBAVFORMAT_MAJOR {
>> global:
>> - av*;
>> + av_*;
>> + avformat_*;
>> + avio_*;
>> + avpriv_*;
>> local:
>> *;
>> };
>> diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v
>> index fb17058df5..e1aab84554 100644
>> --- a/libavutil/libavutil.v
>> +++ b/libavutil/libavutil.v
>> @@ -1,6 +1,8 @@
>> LIBAVUTIL_MAJOR {
>> global:
>> - av*;
>> + av_*;
>> + avutil_*;
>> + avpriv_*;
>> local:
>> *;
>> };
>
> Is there a problem with the current lists?
Don't think so, but this ensures no symbol is unintentionally exported,
so IMO it's fine.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist
2025-07-03 16:32 ` James Almer
@ 2025-07-03 21:05 ` Scott Theisen
0 siblings, 0 replies; 4+ messages in thread
From: Scott Theisen @ 2025-07-03 21:05 UTC (permalink / raw)
To: ffmpeg-devel
On 2025/07/03 12:32, James Almer wrote:
> On 7/3/2025 1:28 PM, Andreas Rheinhardt wrote:
>> Scott Theisen:
>>> This matches how the other libraries define their exported symbols.
>>> ---
>>> libavformat/libavformat.v | 5 ++++-
>>> libavutil/libavutil.v | 4 +++-
>>> 2 files changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
>>> index 47d5ddcdb1..39aa185309 100644
>>> --- a/libavformat/libavformat.v
>>> +++ b/libavformat/libavformat.v
>>> @@ -1,6 +1,9 @@
>>> LIBAVFORMAT_MAJOR {
>>> global:
>>> - av*;
>>> + av_*;
>>> + avformat_*;
>>> + avio_*;
>>> + avpriv_*;
>>> local:
>>> *;
>>> };
>>> diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v
>>> index fb17058df5..e1aab84554 100644
>>> --- a/libavutil/libavutil.v
>>> +++ b/libavutil/libavutil.v
>>> @@ -1,6 +1,8 @@
>>> LIBAVUTIL_MAJOR {
>>> global:
>>> - av*;
>>> + av_*;
>>> + avutil_*;
>>> + avpriv_*;
>>> local:
>>> *;
>>> };
>>
>> Is there a problem with the current lists?
>
> Don't think so, but this ensures no symbol is unintentionally
> exported, so IMO it's fine.
The main idea was to make searching for uses of the exported symbols (in
another codebase) easier since searching for "av" produces a lot of
false positives.
It also makes it clearer what symbols are exported and that libavformat
has additional exports starting with avio_ (i.e. not av_, av(library
name)_, or avpriv_).
I did not see any symbols that were exported under av* that are not
exported using the more specific rules.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-03 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-30 2:56 [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist Scott Theisen
2025-07-03 16:28 ` Andreas Rheinhardt
2025-07-03 16:32 ` James Almer
2025-07-03 21:05 ` Scott Theisen
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git