From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 739F34895F for ; Thu, 21 Dec 2023 22:17:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC90568D137; Fri, 22 Dec 2023 00:17:16 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2097.outbound.protection.outlook.com [40.92.91.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC2EB68CE3E for ; Fri, 22 Dec 2023 00:17:09 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JqggcEIxZJ8cshERdlQuERFRMIG+imBHqm033rAmIPHGOWIc+5eQQHGjuuBgh6KZ/5OO6Y6sJ9LrG/AvlKuPuTld95gWGd35/hTJg0h3CpMDUJa3BfKUjGljYIwwgHYQzKzz/g3QLhP+AB3x6VqTgGKfqTdsFFgLisziPPplg+1Rx4IC6w5Y0FClOfMJ75JG6hnGN8inxjYSw++xM/++HmNkPd8kT+79nsAIEpCqYUJrN9as2yL0e0f0qPIXCNa4MseuOg5DKKkWYQaR88f6SbbDP1kq/7KH4BJLsleZWE27rZmIQzjNCWZE3qKAzyvaOi45tRPo3qBuYiNvdEZULQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bx6NT/8u9X29KzYltxJ0BbfTF1ea3V5QiSjMPW4rjvo=; b=cKggDvppYvSCC/Or4HG7oiKrfzqdIrG3ig2quyt+zw7z7n+KYJuA3lK8w58wE8hL40lOaPx8MHm3Eqvez6/4q0deN6uysNLPxgxK2bq7CmuD5+I03kztI4r3oYYoxGGnsNBYVx2ar9T8RtINxnwrAIwFxmmZyCB7o7Kbr26wpIW19+M5C0RfnTHC1wnOkebVe4CvJPVnTok0GZfwIgLKQaA2ECHqcMWP+UdLo+2bRlsrt0KlmE/uvxTJa4GZ+PVj/1Pn1cfpfGNwcNUFgM6lgLenGhP1uYeNYAoEr2le8LMRtVn/XDeobJG2Emm8c2by/r3Au9Mhw/cptf81pDSJwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bx6NT/8u9X29KzYltxJ0BbfTF1ea3V5QiSjMPW4rjvo=; b=MbHSf4ZdkZz8vQQxeKDkHZLlRdzs3wj+3mSJJHhGNiQmAY8HVtEh10UeQx1sDZGvL5laIBdYp51NopCKUwBsHfII4/hkFWF+6ispQY3R26VWcMAdJn9KTtyNDp0CY+uTWSdc6kccwEtOeJoGL5CYBe7W0uWpxq+QvSvU2Byux/0cDHzZE7Zh9AgT2unBVqw3xsdrEreN0vf9XctSa7vodxiy2oekBMsSL38yzXYcnfegmV5YhH981dLuglyB6zORXFIRYl0QyulAGmKzyMrTneWk5BRCRLwl2n5qDKARlec33pAKR8xUQt+lxVgvq+smIEMzDhc4YPJcx3OXz9fEyQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0222.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:277::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Thu, 21 Dec 2023 22:17:08 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde%3]) with mapi id 15.20.7113.016; Thu, 21 Dec 2023 22:17:08 +0000 Message-ID: Date: Thu, 21 Dec 2023 23:18:40 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231215195917.91300-1-thilo.borgmann@mail.de> <20231215195917.91300-3-thilo.borgmann@mail.de> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20231215195917.91300-3-thilo.borgmann@mail.de> X-TMN: [iH1kwPPeZh4elrACxtn/BVWjAfEkUa52PgLeTgykeb8=] X-ClientProxiedBy: ZR0P278CA0085.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0222:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d4cf91e-78b2-43be-8110-08dc0272920f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sWkyP6NWQNt8qW7JuYH9gztTjPFMXSXci8i9SOKXkANM+27Ynl62mrDSDyZJttOwpYfwFN4ECoP8II9zp7E7OkVYtpsjAzZIgsIw3VAeBtCjbpNSIjewVksDrwi2lWOoqEBxNGXgm9UxE7GtXdaVgp7FE4Jat/0rooypp+Vo5+wlea9hDOp/iiRg56aJJ0cZy3PCi9g6pCs81tg3iajaI4CendLCPKqrATAPqO37eb/okFLgE+xHlFF7fXLeGZR4lkDFgM2cGzuUPs2v4e3WcDogQ7sEda2HUifLXMid5BMGb7pazHGBPdquo8nOl27wM5HmjrTezmFQny5/kQbeu5sd2EhF3BgunmKbP/zp/gR3kzPuLl+ThVvIU7dC6Dix6Up0gACEInR4BCFyPbFA9QgkDyvib72oqelUM3IFByp/o4jbwoe+EFO+CsaCXxEPvQuIa7Xs3T/08774nkaP/W10A3YqK9mL/OunwSgWTM57rmgEx9PirQMcE97PKfudmUxUeHga0zF18lEcYv9GTMijBt3S+qbUslFSRaodNEY3VZ6YmmAP7yjp6GDaZ8PtqHlBIfSrLo2PjKgK48GNEKfIAAajg7gVIf+Rinx10Ms= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnFzekFXQ2dua0t4NUovRkZMUUl3T3ZMazY3Mi81S1ljOXdXRHVtS3VtN0M1?= =?utf-8?B?bjRyTCtSVERkYmJrZkpTcUpFWU42cUM5THk0Yy9zV3ord3JxMUtzbExOWndi?= =?utf-8?B?QTBOdytxYlI1cU1CaTFuUzZtZm5BNXhOcnd0bFVzOEswZjdZU2wvOWVlK204?= =?utf-8?B?MmN0NWQzVzduWjV4dXZjK1p6ODE0aWZtZ3dzdDlsZCtGT2s1RDIyemRTaU1u?= =?utf-8?B?M1V4TXN2dXRiL0puZE5lZFdxYXp3WU9lRE9ZaHlvdjNRSWJlN2JjeE9wUlBk?= =?utf-8?B?bzd3eVRFOWdoM0RVTDdEUERpaFhYTFJJbG9ZRTVpSHM1WTl2YVErL2cyTytN?= =?utf-8?B?RmxseGJQMUtUbjczZ1UzUXhRYnpnbElmNzZmK2xNbEpoOTNQZFdUNURKZHk0?= =?utf-8?B?SUFiWWlyWmhsRDhjeTdYeVMzZ2JKSWF0YnMwaWJucW51a0ozZVRSWTMzV2Nw?= =?utf-8?B?ejJPNzRhblUrWVFQQWxIM1pZZjUzTFA1aEhxSlA0eWd5akwwZzBTS1NaR3I4?= =?utf-8?B?QWJzamsrT0FTVjJSMXRnNXZkRGdNSXBEbFF0NnZFODlHMTIySDR5WGhpbjJp?= =?utf-8?B?OTNtblJRWmhBd1pYWVNQWTFzWlNMbHM4K0FQKytLM0lJbFRkOGtiNWFaZzk5?= =?utf-8?B?SmxBSkZ5YUUwSHp3WXNibE96bCthWGd2YklVWDBDVTRFTzBWTUsxLzNxZ1p6?= =?utf-8?B?NTh5MWFnYWhkVXhaYUovZExiZjRTbDJwZk5KSXpoVUZvcm1RRGJORENEMWYx?= =?utf-8?B?ZGR4N0xsbFpQL1V2MGZ2MysrNENGcDYybHAzMGM2dmU3cVhPM0ZVVGVvRHBi?= =?utf-8?B?MFdpL2dWZ0hISzF6a05tdnh3OXRXWHAyalMvWUsvdG9LcCszWllldUI1aGJu?= =?utf-8?B?VFh5UTJocmM3YzFXUFYrK3pCVkVzT3dkbHAwOXMvbjArYlRrdUZwSUNsTUp0?= =?utf-8?B?c04wbUhSQWtWenFmTWpMR21ZNmNwWHljeENWQkp5dUpiNmlUaTY0Wk43U3Av?= =?utf-8?B?cTBpRkwxTFJvTTl3RnQ3OVd6K0lVaTVESTQ2SG5ENHVXbGtBQTEwbFZKMjhO?= =?utf-8?B?eFNHREVNaUhDZEQ0RW5jR0hpaXhHT3BTVlowRGN1LzRNaExxOTlwcUNqRHIz?= =?utf-8?B?bFNUQ0N3VHpQMUNmSWNVUkE3L1lmNkQya25mc3VVemQvd2pBSFdUalhxc0Jn?= =?utf-8?B?cGFMaVNKRHNjeU10RkdKVEZCdjk1K3pzUFZzQStBR2lhS29yVFNBb0RvYzZ1?= =?utf-8?B?bDNoY29SY3pnVjBpb0xwT2ZRZ0tXZmRoWjRIbzJVTmUvbGZUU000S25MZ2ZG?= =?utf-8?B?cTR1SG45bTV2RE92anJlRGZhNm9DYlNIM0NQamg0QlF4ajlkNFNIRmh4bWdq?= =?utf-8?B?b3ZJbENZSG1SRTZsSmJNQlUrb1ZrZm0yYjJEKzJtWForZUdvTnUrT2I2UjFG?= =?utf-8?B?MTV5bkpQaGphM2RPOHl0Q0xpdk8xY3pvQU53Y1dYUVdvaWdTM2RkWmxzTHda?= =?utf-8?B?M3FEaEM2RzhLRytvMDlHL090R0VkYjRhTkhQdE5DOXlxK3NEd0lJRzVFQ2NE?= =?utf-8?B?ZXdoVFVCTjcvSmw3VDNBMGlReFJZRE91WENWMGpFb2dZRE5CMFdmUXpNRUlN?= =?utf-8?B?cG5OdmlJT3lxSGErbDZJbFlhc0JtMnR5K3ZiN2lnS2RjRHVNWnJlRzF6L1N4?= =?utf-8?Q?ndju+i33+7lqD2eOljMf?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d4cf91e-78b2-43be-8110-08dc0272920f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 22:17:08.2451 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0222 Subject: Re: [FFmpeg-devel] [PATCH v8 2/5] libavcodec/webp: add support for animated WebP decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thilo Borgmann via ffmpeg-devel: > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: > https://developers.google.com/speed/webp/docs/riff_container#animation > The frames of the animation may be smaller than the image canvas. > Therefore, the frame is decoded to a temporary frame, > then it is blended into the canvas, the canvas is copied to the output frame, > and finally the frame is disposed from the canvas. > > The output to AV_PIX_FMT_YUVA420P/AV_PIX_FMT_YUV420P is still supported. > The background color is specified only as BGRA in the WebP file > so it is converted to YUVA if YUV formats are output. > > Signed-off-by: Josef Zlomek > --- > Changelog | 1 + > libavcodec/codec_desc.c | 3 +- > libavcodec/version.h | 2 +- > libavcodec/webp.c | 754 ++++++++++++++++++++++++++++++++++++---- > 4 files changed, 696 insertions(+), 64 deletions(-) > > @@ -1298,12 +1326,12 @@ static int vp8_lossy_decode_frame(AVCodecContext *avctx, AVFrame *p, > int ret; > > if (!s->initialized) { > - ff_vp8_decode_init(avctx); > + VP8Context *s_vp8 = s->avctx_vp8->priv_data; > + s_vp8->actually_webp = 1; > s->initialized = 1; > - s->v.actually_webp = 1; > } > avctx->pix_fmt = s->has_alpha ? AV_PIX_FMT_YUVA420P : AV_PIX_FMT_YUV420P; > - s->lossless = 0; > + s->avctx_vp8->pix_fmt = avctx->pix_fmt; > Separating webp.c from vp8.c should be done in commit of its own. And you did not really separate them, because you are overwriting internals of the VP8 decoder. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".