From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH 1/3] avformat/iamf_writer: Avoid using dynamic buffer Date: Wed, 31 Jan 2024 10:31:52 +0100 Message-ID: <AS8P250MB074419C53DD4BB1A704BD5C08F7C2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavformat/iamf_writer.c | 28 ++++++---------------------- 1 file changed, 6 insertions(+), 22 deletions(-) diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c index 99602ae204..f665f45b7a 100644 --- a/libavformat/iamf_writer.c +++ b/libavformat/iamf_writer.c @@ -807,31 +807,15 @@ static int iamf_write_mixing_presentation(const IAMFContext *iamf, int ff_iamf_write_descriptors(const IAMFContext *iamf, AVIOContext *pb, void *log_ctx) { - uint8_t header[MAX_IAMF_OBU_HEADER_SIZE]; - PutBitContext pbc; - AVIOContext *dyn_bc; - uint8_t *dyn_buf = NULL; - int dyn_size; - - int ret = avio_open_dyn_buf(&dyn_bc); - if (ret < 0) - return ret; + int ret; // Sequence Header - init_put_bits(&pbc, header, sizeof(header)); - put_bits(&pbc, 5, IAMF_OBU_IA_SEQUENCE_HEADER); - put_bits(&pbc, 3, 0); - flush_put_bits(&pbc); + avio_w8(pb, IAMF_OBU_IA_SEQUENCE_HEADER << 3); - avio_write(dyn_bc, header, put_bytes_count(&pbc, 1)); - ffio_write_leb(dyn_bc, 6); - avio_wb32(dyn_bc, MKBETAG('i','a','m','f')); - avio_w8(dyn_bc, iamf->nb_audio_elements > 1); // primary_profile - avio_w8(dyn_bc, iamf->nb_audio_elements > 1); // additional_profile - - dyn_size = avio_close_dyn_buf(dyn_bc, &dyn_buf); - avio_write(pb, dyn_buf, dyn_size); - av_free(dyn_buf); + ffio_write_leb(pb, 6); + avio_wb32(pb, MKBETAG('i','a','m','f')); + avio_w8(pb, iamf->nb_audio_elements > 1); // primary_profile + avio_w8(pb, iamf->nb_audio_elements > 1); // additional_profile for (int i = 0; i < iamf->nb_codec_configs; i++) { ret = iamf_write_codec_config(iamf, iamf->codec_configs[i], pb); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2024-01-31 9:30 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-31 9:31 Andreas Rheinhardt [this message] 2024-01-31 9:32 ` [FFmpeg-devel] [PATCH 2/3] avformat/iamf_writer, iamfenc: Avoid allocations when using dyn buffers Andreas Rheinhardt 2024-01-31 9:32 ` [FFmpeg-devel] [PATCH 3/3] avformat/iamf*: Improve included headers Andreas Rheinhardt 2024-02-02 11:30 ` [FFmpeg-devel] [PATCH 1/3] avformat/iamf_writer: Avoid using dynamic buffer Andreas Rheinhardt 2024-02-02 12:32 ` James Almer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB074419C53DD4BB1A704BD5C08F7C2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git