From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6BA2A45A6D for ; Tue, 14 Mar 2023 03:36:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5928D68BE09; Tue, 14 Mar 2023 05:36:49 +0200 (EET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2105.outbound.protection.outlook.com [40.92.90.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3308C68AEB3 for ; Tue, 14 Mar 2023 05:36:43 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBZe9xqxu3x1XNYR4lJRwnPoBeKko+EIk3Y8gmejkixJ+7ytbqNq61XJZ9xkSmRQR1rtef7PwC8mCPE4IQix8M4mjkgjUgvMMwnjcvW+Q0W6p3BtZP9o3e8o2QE6HJncltnruZikyWXXGjKqtR3chqAqJNCdraALzgluXz7vc1iAnPACyjwMb/V8qtB82Y7wPP0Qsitv7rb8QQcH+nPmeVel81i+NbtGkkUF3VbqsQm1Z36jfJFe7bpqeCn3aro6ActtT9WRLbkGmTop9ajKYo3vpastI/eQs1V/JU55sv9wKYl3VpWLEL+wQfASy5ealrFLFGMTO0AwPyUCXF20Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWLJ1KZ3pqH72/CFwz9gg++tK6xteMlvnbRHD4cWlpQ=; b=CcMvi+CY2W43S9kV/G7CW9zXXZVLcTcNzCGzMgsFA8cJ4BH/hkk07J2+c7s1QgdzJPsy37f13tQF341P5NzaEyNMOathKpIRn2kRJe+pKXr7ViaRxU649P7c167MpVNqugKqXVWivyQaCYw0snv3cqID72WEMUHBglWhdAKrR8uqGB/wHuLQkY2OoRyaMtrtzShW74JQI1pib6z8ZTsoMcda8YaYUPkjyuQKG5lZlvcUqCKZqFT9qDQbA0Uc5x6fpWR7RjexSrCdfj0R1BnYadCUEByvO5UJuAxk9WqmDMFwwp94J8GzwS9i0D6HXEWfbnpRB5UTeIaFMqv3UsN8EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aWLJ1KZ3pqH72/CFwz9gg++tK6xteMlvnbRHD4cWlpQ=; b=RdSKEFi23H2FCVk0WKJs2EoFBQ1q3QQ0ueJwFUS8rv48D1mEsu+mdTSBnRukMwzMib7EAxdKC9zUicWY93IAhnRxvK6de7C6wXNBIOXvs/DQrKgrxb8RLB6LSjj7nYyblqGiVKrKy1HG5t3KiihntohpQ6g+m7AnzLa3/VS8zSvYHFSDaHVuTN3S2vW5ky4fhqdpH8uGO9fVi5IqAjUD3akPINMiP3G2L95moD1rIGYtjBUlHtCuSzHKlqfMP+YqMK+Ra9k9QsdIj6oaqYpzzJJ++V4lCjqSUTzXtfmbvthHlZw2veXpa77rHuVcL9Gv6TDiEKYZ39ELBN+OM5t4dA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0344.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Tue, 14 Mar 2023 03:36:41 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::73a:bd4b:26f3:cc2b]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::73a:bd4b:26f3:cc2b%3]) with mapi id 15.20.6178.015; Tue, 14 Mar 2023 03:36:41 +0000 Message-ID: Date: Tue, 14 Mar 2023 04:37:17 +0100 To: ffmpeg-devel@ffmpeg.org References: <20230308202431.608732-1-gwymor@tilde.club> <20230314032557.945590-1-gwymor@tilde.club> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20230314032557.945590-1-gwymor@tilde.club> X-TMN: [wfTxbF+X0Gtm3DCZmnKDGJ2yE8djOm7v/0i/pjzZGTg=] X-ClientProxiedBy: ZR2P278CA0041.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::10) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <2a2f1ce6-f397-1627-6267-84282edb96f0@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0344:EE_ X-MS-Office365-Filtering-Correlation-Id: 3981946a-23c3-4c65-9452-08db243d5328 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yB5hzPnToodW4mV7zyr52er/zJqR6hsralud/Z8p2GkeHDkcMZNf3JHeYfoDnV8Y06NdsGzfWI3EY9YcgxCyq01ib1I3dHbkgFoFmI8aOmWktMwzJSEZHreJ97lLqk/rT1Eohs2JIwrGsc27SiYMTsaM/yY3hhv4iCaArnXIRvKqQBtb834cwm7+N8/RU0paIU5ugr3KcEFWnL/BwR/HIO3afUQB/2Ecp35j4DzlQYeoADhsqdQqP1+mVH9yWvE0CY1iBaOTXc8XVzJpMx3pqqwa7icnwndkgPcTZLD8AMDOUaNNaaY+knD/KBMl/wAADxjzlqrY8rxSYUMgIBDNs66mhTUSpuw+b4MISJ3zxTpsU+Pv1hih3UMLuT47POWevo/+pJWVROOlqEJJ50PPGUd01Ffai75io8Ouq+pOUuW/ikRxjW0iYIfnFp/WwJhyWwHUAPYu/WRAvRc4tJQd/2zPpkr60us5n6Fjbo8t+CnX4JPvHPApo1MwzN9Xbf0mdwkUUl81h9C3Vh8WvIgtUW1aftmsukHFvjll0VioNMPtiLqOgbN/gxERewGMr1vn93jPJa5kItQixC6A/xY5HziF8LqiGKUqoBVCUkLeyFfpr8ZmR/biw2IkwWKmMRoojmWm3rj7jLeDj/zU4Xx10g== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXY5b0lMcVp3WnFwdzY4VDVJeS93eFg5UkM2ZE5zRi91N1VITU50NDFCK2pk?= =?utf-8?B?ckgxQzgraExDKys0WGF2dmFBVzI1OVI5NDdYblpsQlhhNVhSZnhGQTBFbmVL?= =?utf-8?B?TEdieWhtR0ovZ3JLa1JFeURoZlVKOVZUekVLYVppZ2JGRk9JazZ0MkpRbEJQ?= =?utf-8?B?TTN5OGptYkwxK1c3VUtYMllRMklDb3E3L0gvUjBlT2VydHlHSmdpMkwxbzVu?= =?utf-8?B?UFZUUUltUHJTSnowRm9Hbm9LZDhwV2h4bzdra1FqKzFvUHRyeWlPRWFPYm5X?= =?utf-8?B?SnBCTng1cGJIeHhsVWxIejMydkJrelNTT3lZNjNtT2Z2c0hIOTFMblFvZVQ3?= =?utf-8?B?SE9zTUlrdUdHb3VkbjdrbUptcUJZbVZOeUpIYVg2Y3pJV0FxODdJaUMwa1ZH?= =?utf-8?B?SmdXV3hUcVhMREJJVVFUb0Y1TVNNRWcwNVU0empnd20xb0JFd2luNlpic05X?= =?utf-8?B?SEREbzFIRUVEeWtyRnJTSkl6U20xVzNtMFFMN0VWNjlOTzhreUJheWk2TXhU?= =?utf-8?B?ZHA1T0dMek1HKzZQY2UrbERXQkVTSWhkZnpqS3cxRkR1di8veVRycGExVFB1?= =?utf-8?B?OHF6Ri82VWw1SzhvOXV2NFY4b0dhWjBNQ0tJY0JzU3NaWS80MTlvcmFXMWxv?= =?utf-8?B?RG5UWG5WU1VkdHVHejMySEtlRitsWFVMYzNrKzRuSjRRRDZwOG9seG1waHNB?= =?utf-8?B?bHQwN1BVUXVTMlExK1BkeTZ6TjdQN3pnNDY4Q2NNMUFERG5LR0dnMU5sYmQ1?= =?utf-8?B?WWxOMlppT0h6MkR1WTFQVjZZK0pkQ3hSckdDQW16ckZrMDUrK3JQUFhWeE1l?= =?utf-8?B?MThsSDAwVVRUaEo4VVJ4YTNLaGd2Sm1WZ1dqVXAycWRydDFxaDZmNWtCREhq?= =?utf-8?B?ekU3UStqREUvSGR1dHRYQjljRUZya3ZSZTRJWXFxVUhubXBhbHhaY2lvRXdu?= =?utf-8?B?NHpvWVlrdDBicWxEMGFoS1FKTkNGYjQ3WGljR1grTFo2SmN5dS9udUhtT2lx?= =?utf-8?B?Qytwd1R6UkRPWkRCK1VVenZSVDdhZnhhUi9uOXlPZmVFK1ljMWV3c3FNSG9B?= =?utf-8?B?SkZZWkZ1QmIxMVluY3hWbWFrT0ZlWDZxZXFnSkw2c1dBM1Z0M3lNcUpodDhr?= =?utf-8?B?L1N2bExoRTRlQ1NoTW1XWUJMbkptK1FGWTB3U2J3dGFocXBKbzJDSWR4TWt4?= =?utf-8?B?Wm4vZzVsZ0pvQit0OHJNUjZibDI4WjVqSDMwendWeGhydkRQNUdDU0p0NVhQ?= =?utf-8?B?dUNIZTNuSkpxNzU3elJ5OTJ4OE1ZSjNjdHI4WUtrSUJYN0E4RFRkYWZJb20r?= =?utf-8?B?N3Q2dmFkQ1NNZDFGTnM0Tm5IVnpqY1ppeWQzR3JlbmpvbnNjNCtZbFY2c2tK?= =?utf-8?B?cm1vQ1M2OHU2dFM5WXI2d1BxTDlEM3hJQzJxaTN4dENxT0xmZTgrM2lUM0FT?= =?utf-8?B?SnlZZHVtc1dwdCsrcVBOcjhCdllJVWkwclkxRkdjU3QrYlk4ZHpuUjhIRHBi?= =?utf-8?B?b1VLcHVrc2ROSkFlNzJHOUF1VDVrS0RnSGhxM2RzY2gvZGVFOFdmT2ZpR2JP?= =?utf-8?B?blkwWnh0M2ZCTk1xc1RNbUkwbjZHMkRidGpLaHBvOVp3TlowblBmWjlkTXYz?= =?utf-8?B?T09vZFpsQ2JmOVB6aVF1M0w0NTlJeEVFaE5ZL3FwNWtUNTVHSjdtQ3ZrWW9y?= =?utf-8?B?S09KeVBXWTk2b0Y4aTl4SVdsZXlEdzZnTHlsY1BqUDNmc1hkS05WSDVQTWRM?= =?utf-8?Q?W75mtS8gEH84doqZBc=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3981946a-23c3-4c65-9452-08db243d5328 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 03:36:41.1861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0344 Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/matroska: Write WebVTT subtitles according to MKV specs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Gwyneth Morgan: > When writing WebMs, FFmpeg muxes WebVTT subtitles with the D_WEBVTT/* > codec tags from the WebM specs [1]. However, it does the same when > muxing MKV files, and the Matroska specifications instead use > S_TEXT/WEBVTT tags for WebVTT subtitles [2], which FFmpeg currently > doesn't understand. Support reading MKVs using either tag, write regular > MKVs with S_TEXT/WEBVTT, and write WebMs with the D_WEBVTT/* tags we > already use. > > [1]: https://www.webmproject.org/docs/container/ > [2]: https://matroska.org/technical/codec_specs.html#s_textwebvtt > > Signed-off-by: Gwyneth Morgan > Fixes: https://trac.ffmpeg.org/ticket/5641 > --- > v2: Rebase as later changes in ffmpeg.git conflicted with this patch. > > libavformat/matroska.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > index 79b2d09..d9e5ff9 100644 > --- a/libavformat/matroska.c > +++ b/libavformat/matroska.c > @@ -60,16 +60,12 @@ const CodecTags ff_mkv_codec_tags[]={ > {"A_VORBIS" , AV_CODEC_ID_VORBIS}, > {"A_WAVPACK4" , AV_CODEC_ID_WAVPACK}, > > - {"D_WEBVTT/SUBTITLES" , AV_CODEC_ID_WEBVTT}, > - {"D_WEBVTT/CAPTIONS" , AV_CODEC_ID_WEBVTT}, > - {"D_WEBVTT/DESCRIPTIONS", AV_CODEC_ID_WEBVTT}, > - {"D_WEBVTT/METADATA" , AV_CODEC_ID_WEBVTT}, > - > {"S_TEXT/UTF8" , AV_CODEC_ID_SUBRIP}, > {"S_TEXT/UTF8" , AV_CODEC_ID_TEXT}, > {"S_TEXT/ASCII" , AV_CODEC_ID_TEXT}, > {"S_TEXT/ASS" , AV_CODEC_ID_ASS}, > {"S_TEXT/SSA" , AV_CODEC_ID_ASS}, > + {"S_TEXT/WEBVTT" , AV_CODEC_ID_WEBVTT}, > {"S_ASS" , AV_CODEC_ID_ASS}, > {"S_SSA" , AV_CODEC_ID_ASS}, > {"S_VOBSUB" , AV_CODEC_ID_DVD_SUBTITLE}, > @@ -78,6 +74,11 @@ const CodecTags ff_mkv_codec_tags[]={ > {"S_HDMV/TEXTST" , AV_CODEC_ID_HDMV_TEXT_SUBTITLE}, > {"S_ARIBSUB" , AV_CODEC_ID_ARIB_CAPTION}, > > + {"D_WEBVTT/SUBTITLES" , AV_CODEC_ID_WEBVTT}, > + {"D_WEBVTT/CAPTIONS" , AV_CODEC_ID_WEBVTT}, > + {"D_WEBVTT/DESCRIPTIONS", AV_CODEC_ID_WEBVTT}, > + {"D_WEBVTT/METADATA" , AV_CODEC_ID_WEBVTT}, > + > {"V_AV1" , AV_CODEC_ID_AV1}, > {"V_AVS2" , AV_CODEC_ID_AVS2}, > {"V_AVS3" , AV_CODEC_ID_AVS3}, The reason we write it the way we do is that webvtt is muxed differently in Matroska than WebM. This needs to be fixed, too, before S_TEXT/WEBVTT can be used for Matroska. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".