From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9E6F54F041 for ; Fri, 16 May 2025 01:15:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9AA8A68C5BF; Fri, 16 May 2025 04:15:36 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2072.outbound.protection.outlook.com [40.92.48.72]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B93FA68C4D1 for ; Fri, 16 May 2025 04:15:29 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UP/EOuWxjcTXXMc/DeKJXNw6UuctWPKRUPKP2cwAeEHRPD/rGlDxhq2PpMDAV9b8UpNWFRrI56CXdDmsEiOr10BAvhnCNtBaawJg/Crzwudype+JP9nq3VjdKuRfk+JbygpB4fuTFixgk+Gjxoiy64q7oLY5Cm9ouvambt8/+1NzvltogWESWxc22GXBbdg8Im5v8HQXzj6L4UfL3d8pbl1hItX4bdMyeKyXsDYW3kVyZSQeFqo2m1UrTFsc14wnj1ZpwOX5S0MH9V3WaHOa6+4h0wfg5x2zbC/G/QCLwtufBh5BSU9GJbflnikhjUHG1myhfGBnnOoRM6fNwqcvPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gtc5Z8Yj23L+NlxkcQ451NW35q+ytJqFFXBVst2Q2yc=; b=a6ivK2uE2Z7wMN2EOTFnW26F9bprIMjn6bvdA4PnXXAPfhBrhUamnn2kEGGIkRCUjMrdsLR8uJLUQ/HdObaxsIOaGj3poR+nB3oMNrZbQRS7d1mU7mvcIVGZaPbGEUEYT7Ay3SqyHSaOGPYZSDXet8iZ8B1yfNA6wDHvAF4Yz+i1I5MfdtIc0rTZLz7zb4B6C8Kzv00MXMJTquCyENsBnmDM9ioH5DqqJDswqgnPR82VD9wlVN2dsI6/NeVNARGaLzMwdQKWgCp3kN5JoOg6pmzjsMSk3F4KqF3Wb7F1jW02GDu0KoauZtphMsxgMwTAlaB9L2Yezbp2aZ3nle5NWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gtc5Z8Yj23L+NlxkcQ451NW35q+ytJqFFXBVst2Q2yc=; b=h9XoiSHZMfQr8r3qxY+7STPZosWlC22Mp/n5l7nn7dKD+LmaO0gq3rqnaBYsHWQwnzk/UbbHg72pHoU6PraWlCndYtd2b8/5hz2udUnT57koSerE4pdkdEB2Ys/q5R/ttYEsrWBNVqsowS0H+cjWONQ7wDE2qgMx3NKSaVo/Z3qv2j2P/vhUC8dxSDnH+kpg0+da7uEZJy+ZdIwOWxIRLTvDho6vT5D6Oz9RigV6auKXWoaVZ5XwSgyU3ZvAXtms9oXuHs+hkT/mVoZOqSkcxy7Z3YeNjTRp3CVhdRLEu3RwayuPXcPAoCVAnOlMGSd0pDRq7XQGVSQEiyv24Bh8Eg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS2P250MB0992.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:598::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.31; Fri, 16 May 2025 01:15:10 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.8722.027; Fri, 16 May 2025 01:15:10 +0000 Message-ID: Date: Fri, 16 May 2025 03:15:09 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250516010538.886453-1-programmerjake@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250516010538.886453-1-programmerjake@gmail.com> X-ClientProxiedBy: FR2P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <811c0bbe-1d20-473e-a0a0-34009d29b442@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS2P250MB0992:EE_ X-MS-Office365-Filtering-Correlation-Id: b016a62b-5646-43b1-1821-08dd941719e5 X-MS-Exchange-SLBlob-MailProps: ZILSnhm0P3mDoogZiIYtj6aHx7ik50F0rHv1oUCT0Q2JaEIwvmujeNA4j+VDI8Obwed5OZQf1xKFVsjT3WHn4jTg6wdMkb9wAsy+Fq7Flp7IJRhLsR5+SQ99zfnPLppJlvQ3B9VExVCCRg83xcc8lJjN79rq1cmB90RrZcuECknn3NRL413VVFcJirsMNZGW9R3eg9e06j0XozWHR7L7GOWIcfpCYN7wTCKhw2bCmodk560Mbt3TC6h+3PV8uzYUu/m4QxrWFbh/xuA/mMqcpFbwtHCGEVx94s9CXXa3hh80p/cspXWEP8fWGppSHHuvxli4IHUQp1lnLwSgRPOP9BzuHFy/ycbJizQUSq6IcwxWlrEAw3Y2D+4R3/o3ayE6hUAQqO0jnsYvqZHfkwl0LsHq/gCqCnBXpI55DZpYbieKwyQ3Ej6ak4uUYOC6nHk1zOS+TiCq0hY4H34xaK9cWi5BANBKroheXQtrToZIW25Ku1Y1tG46StgYxQ7pylzMVYugBLeLaQIqehljKVDXmc/nceC4QFIcWukw6J26KlohoYbeHqdLyGS3nNNDi3ZS44LEoF9GIp8XmiIQRA9PuoyGiDjwkJby9IUMg5OpofildiXJ2IZUqHiNNaKrX1GWmPjP+hQOCjqdhfcPAnnewB5ACkPgQ7xS43pOJQ+4IEHlBs/B9AlrnGkomf/VQ5LoH6Yr2Cb8vQMd209O8p0CyTT3s/pQ3pE/fV/W+GQt8dwoufwdkb7p+7U12n3C02V+pphhOVLRspyoZM9eYgJdSpRERBmEu5lV X-Microsoft-Antispam: BCL:0; ARA:14566002|7092599006|15080799009|8060799009|19110799006|6090799003|5072599009|461199028|4302099013|440099028|3412199025|10035399007|1602099012; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UkIxbzRLOFphQ2FIMFY2Q1EzRjM3TXlxamtuMjBPeXUyN09aNENTbGs3VE8y?= =?utf-8?B?OXB5SUxKYXlGVTBWZ1BTNHd0M2tnek4rcjczeTlrRjhSSFVmQk1mdFFWM3FW?= =?utf-8?B?UUZMZlVtaWdqKzNWL0JscHZacWdONldXREVFOVl3dXl0Y1hud1BrbEpSNC9z?= =?utf-8?B?MTVNekx1SVdzdlpjZ2ppU1IyMk9PMTZocWJnWXluK1F2b2VMNzUzYk9NQlBW?= =?utf-8?B?SU5ra2VhYm42WnAzYUNUZjZ5WWJ0d0hTVmVoQWwvUW5LUEcyTjN2MjVyZ3RQ?= =?utf-8?B?cnBKOHcyb3ZUcDZ3OXg0bGttV0duVWVNdWRucGdIRHdHcmRaWUtuWXlXNEJG?= =?utf-8?B?SVNiL1g0RjdzbzdEeXFNVWh5TXo0RUJmbUszUmE4U2d3TnFQekx3c1AzK2hQ?= =?utf-8?B?VVU3QzJXS2ZvL3VtM3RGcFh1T3g1Nk1rY2lqQllOVnF5Wjd3LzVCbDRlcmVs?= =?utf-8?B?S3BKckxSSzE1WThWVmpiTXJ1aC80c3NIekNzU0tYWW5hbUoxM0g5NWlCdC9D?= =?utf-8?B?WWE4ZGNoVzFXNEVjRGFXUWRqUktCTUg5NE9XK2xweVhXT1dIWXJVaS82NjNB?= =?utf-8?B?aVdJWWU4VytNdCtkbWJVd1RSbVZNdFlnV1RFQVZzV0RoTGM0ajZIc3VuaW02?= =?utf-8?B?Tk90UG41aWptSms3bEFmdTl0bEt3UC85VmxsUHUweVlVaWN2czM3VHl6ZEp2?= =?utf-8?B?c1AzV2QrVVJaOGViZFVpQU9LSXoxVEI5clFneXMyb2hkaUpFcVBEaWZEMEd5?= =?utf-8?B?dlplLzVscnkydjNsSEVrdklzQm52Q2FXOHRHTlBySUFySXZmLzRuTFJicVFQ?= =?utf-8?B?OTlDN2xwaHBrNXFHY1pySStvK3BGc3FiZk44VTltZGVGY1ZTSnladEdPeUhw?= =?utf-8?B?OU0zSjJjQm90VjAvdU9VSjJGUC9wRUNITkN2ejRhVUNWUVJBS09jK2p4N3lH?= =?utf-8?B?MkJPMm1vY092NlMvemxUQlJKdnNPUlFMNktQR0xBWkhRZmdiekw0NnBoaGhJ?= =?utf-8?B?b012c0t4NjdFTzI2SGxZNGgxbWQwM2RIRCtzYnRUQ2NtR09idVdyZ043VGpL?= =?utf-8?B?N3RMemFzS28wS2k3a1R1T0pVaWZpWDk3aDNjdjkzZG1QSkxxbzM1WDB4VnJI?= =?utf-8?B?S1NEWERIbUgxdjkyS256WEIybGxXK0g4ckxhd2lseUNvaFdNeFpQbnNFR0dw?= =?utf-8?B?T2x3RnpKUFFXYTV0OXJBSXoyem12M055NGhXSVpKQWIwdlRjU1o5RTFEck13?= =?utf-8?B?MDBkUmUrcDdtV2kzekxrRXdsSGYvSnpEeElaT3IydEdYamhBWk52RXlTVWNk?= =?utf-8?B?Z0I4bDVOaVF4c3VITC9qRnpmZXhKVmtzSVBkOTVDVG5OdTEybXAxVFQ0RkI2?= =?utf-8?B?Mlp1K3o2TUE3TEZieElMY0xmTUt1aUFPMk1JU1ZKZXVaQkZ6NTJjcUFIeUxT?= =?utf-8?B?bDB1aktldnNsZkpTek9lc1R4NnNZS1ZuM1EybzVHaGtXRFp1RURGU3BDa0dO?= =?utf-8?B?NzZ5Z0M3THdaYlIyVnJmc2hIVHVvVElHQThwVWlBb0JMQ2M0TUNVNVZjeFBZ?= =?utf-8?B?OFRXb2NkN0NGaXVzK1FKN2JLSEhqbTVBSUtIMkRUUElpSUlBTURLd3BCaU9R?= =?utf-8?B?OENDaGQyekZleXUxdGZJYy9NcFFGZUo5UXk2NnpCanRpN2NSZGp3TXd3dVgx?= =?utf-8?Q?jVPPZVPO6V68YFXYPPVo?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlMxMGFidHNiSEVCT2N3bmRzdmNwZGdORzFoT2xxL3dJODNNbElQV0crWGF5?= =?utf-8?B?a1VHWkd3bTFjWk9zRGpwM0V3MTlEU05PUVNCa1hKaDNnMWV5cjgyaDVYZ2Z1?= =?utf-8?B?TDhGVlNDY3ZXVk0vc3cwaElrVjhWYkVEcWRxb2lOZlQwY0dVd2svV2YzNS9C?= =?utf-8?B?ZWdZVllzOTRoVDljM3EwRm14ejFnVkZUN1FNbzkvdmxudjU5QnkvaXlxbWoy?= =?utf-8?B?Rzd1U1ErdjNITWNIL1ViODJGV1ZBQ1pPRXgwMC9xblA1WHNjcTArbjhMRWw2?= =?utf-8?B?SlpqSTBGKzVjMWlKZUhRQjZCTTRRY2t4RXRBMmVYc3d5ZC9DQk8ybUZUUmZk?= =?utf-8?B?V0N3U0hWby8vVUlGT3VzaEloQVdoaWNaTG5adlE4WVNRVUplVkNKekN5MmZI?= =?utf-8?B?cUFvWWNEQ2tsWU1pWDQxdDMzVGczTW9yNnFuMnRTMCtlanpueUxoM09Gaita?= =?utf-8?B?eDUxMmhwZVlxT2NSeEZiR2R0bExlQk1iZjV0dnkyMzBGUE1XU1BJUlBTMUxT?= =?utf-8?B?M1ArTUVOYUlCTjZtZjVHd3lUQ1ZHb1Z6UitBeEtmMkpwdnF4WFg5Mm9XZlU1?= =?utf-8?B?anRZR0paUEFzQlB1b215QWlLU3lobWkyS0x0cDdnR2hPMXZ4dzNaOUg4TUtw?= =?utf-8?B?cWxvWmFVc0IyVUhxVi9UWTZxWTFaQkpWMndGTGVnS29sdkNTTFJzeURIblVm?= =?utf-8?B?TU1wd3dsZWpWM3E3dDVQbDgrTUNEbGk0RHhrQjlad0hZMnBFbGlEYkV3Z3dS?= =?utf-8?B?WWQvUEZqRzN1dDgzcEtYKzh4MmVONHl4QmQyejFrOHdUOFZhZEpUNUcwSTl4?= =?utf-8?B?UW8vdG5hdnJieHpxWmlKeHZSWkpYYUZpZ01vYjVLeWRtSHJUdkhzeVYrUjNG?= =?utf-8?B?YUZYSVhhYk1tSmJFdTVBMWxZeHJlZUt4VU1MamJHSXViTWd2bVBONFU0Z2FG?= =?utf-8?B?Z254cm0rWFVxNVhsNUxsZXpkYnVyY3RSNzBPazZhMy9xdGRvdERreGNwR3NU?= =?utf-8?B?TS9XY0FmMkowa0k3VUE1M1c2Q0hjQlZuOUppNFZWV3FFRFdRSHRtV2VQYytr?= =?utf-8?B?YndHVkZpRTQ0ZUpnVkRRVE5ZYVo5cWdwUXViTldVM0dCNFBYNWtid1AyOXk4?= =?utf-8?B?dGdRUnpsSTNWSEhYeFR5YjIxMUNlTkx3Qk10eXRSL3NIdmZjaXdXUFEvTzlU?= =?utf-8?B?dk5RUkthNW0yeDNMekdZUG5IcXBVNWFuVnFrQnZrSWRYRXM3ZnZOdHdheU5D?= =?utf-8?B?QzZ6N1l1RjRrNDR6TUVlMjUwYnNaN05FeFd2UlRJdGhvL0hXYjJXSE1qWDht?= =?utf-8?B?ZVNUL3RnRGhjRHJrM1I1dkYwNzNTS0xGcjlhL3dsTWJMVS9hUFBhZVFDbytK?= =?utf-8?B?cm8wNlN6eisxZXFYUHFkU0ptMUdKeDBxOU9kR2pxRlY0OWFzQ2pzY0RzeFJ3?= =?utf-8?B?MmZ2VUtSa0RDR29RdWE3RDVPamZQeTQzMjhIdVRsVUFBRFhxVEdnbFBTNHA2?= =?utf-8?B?eEs2WGdKaFN5a3ZzTHVQd0dIYkd4Ti9Tczd1YStESzlHZlY5RHRBaW9PVlhh?= =?utf-8?B?Z0hHQ0h0MVl5c1NFM0pSLzN3Wnh5ZmtGWFFVaTJoSnRHcDFMVVpVSGl2QzZj?= =?utf-8?B?MFdmOHlKM1ROMDREOFEyT2pSZ2FnNVFTRWVHTElCQW5QcUM5M3BwbkhNZUtr?= =?utf-8?B?L1k1c01teFllMWM2cUY1UGtvNnRVSWlBK3V1K0lYbjRadXZHSStFSXhoK3Rm?= =?utf-8?B?bW5nSHhvcTAvbzJiU3RxcWU2YzlZeDU1SUhRVVEyQ214NGZPaDF1dHo4THdz?= =?utf-8?B?czdFaGNHaVRrRzRpWEw2Zz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b016a62b-5646-43b1-1821-08dd941719e5 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2025 01:15:09.9832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2P250MB0992 Subject: Re: [FFmpeg-devel] [PATCH] mpeg12enc: fix wrong size when copying A53_CC side-data into output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jacob Lifshay: > Fixes: https://trac.ffmpeg.org/ticket/11591 > > Signed-off-by: Jacob Lifshay > --- > libavcodec/mpeg12enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c > index 8364368fde..e48437eb8a 100644 > --- a/libavcodec/mpeg12enc.c > +++ b/libavcodec/mpeg12enc.c > @@ -472,7 +472,7 @@ static int mpeg1_encode_picture_header(MPVMainEncContext *const m) > (side_data->size / 3 & A53_MAX_CC_COUNT) | 0x40); // flags, cc_count > put_bits(&s->pb, 8, 0xff); // em_data > > - ff_copy_bits(&s->pb, side_data->data, side_data->size); > + ff_copy_bits(&s->pb, side_data->data, side_data->size * 8); > > put_bits(&s->pb, 8, 0xff); // marker_bits > } else { Thanks for this patch (and for the bug report; and sorry for causing you trouble). Your patch was also my first attempt to fix this, but unfortunately ff_copy_bits() may overread, yet the side data buffer need not be padded, so my patch simply reverts the ff_copy_bits(). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".