From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] gcc: Remove auto-vectorization limitation.
Date: Wed, 21 May 2025 14:14:56 +0200
Message-ID: <AS8P250MB07440E86014D4DEA559BAAD28F9EA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <403b95bb-e73d-9ca-293a-e18cfd813ab@martin.st>
Martin Storsjö:
> On Wed, 21 May 2025, Andreas Rheinhardt wrote:
>
>> Jiawei:
>>> This patch modifies the FFmpeg build system to remove the explicit
>>> disabling
>>> of GCC's auto-vectorization feature.
>>>
>>> Modern GCC versions (>= 10.0) have demonstrated stable auto-
>>> vectorization
>>> capabilities through extensive optimizations in loop analysis and SIMD
>>> code generation. The explicit -fno-tree-vectorize flag originally added
>>> in commit 973859f (2009) to workaround early GCC vectorization
>>> instability
>>> is no longer necessary.
>>>
>>> Key improvements justifying this change:
>>> 1. Enhanced heuristics for loop vectorization cost models
>>> 2. Mature handling of alignment and memory access patterns
>>> 3. Robust fallback mechanisms for unsupported architectures
>>>
>>> This change allows FFmpeg to benefit from automated SIMD optimizations
>>> when built with -O3 optimization level, particularly improving
>>> performance on x86_64 (AVX), ARM64 (SVE) and RISC-V(RVV) architectures.
>>>
>>> [1] https://git.ffmpeg.org/gitweb/ffmpeg.git/
>>> commit/973859f5230e77beea7bb59dc081870689d6d191
>>>
>>> ---
>>> configure | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 3730b0524c..b9e95ce4ec 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -7656,7 +7656,6 @@ if enabled icc; then
>>> disable aligned_stack
>>> fi
>>> elif enabled gcc; then
>>> - check_optflags -fno-tree-vectorize
>>> check_cflags -Werror=format-security
>>> check_cflags -Werror=implicit-function-declaration
>>> check_cflags -Werror=missing-prototypes
>>
>> FYI: The last discussion about auto-vectorization is here:
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/299405.html
>> It contains a report about a failing build with vectorization enabled:
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/299421.html
>> I don't know whether this is still reproducible with the latest GCC.
>
> The issue which was reported last time, when compiling for i686 mingw32
> with --cpu=haswell, seems to have gone away in
> 182663a58a7a099e02e76da3b0f96d63e5c26a6d, where we made the whole
> problematic x86 inline cabac assembly noinline on i386. (That whole
> inline assembly block has been problematic in a large number of cases
> anyway.)
>
So there are currently no known miscompilations due to vectorization
with GCC?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-21 12:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 6:17 Jiawei
2025-05-21 6:52 ` Nicolas George
2025-05-21 10:17 ` Jiawei
2025-05-21 18:21 ` Frank Plowman
2025-05-22 6:32 ` Jiawei
2025-05-24 1:46 ` Kieran Kunhya via ffmpeg-devel
2025-05-24 4:10 ` Jiawei
2025-05-24 16:10 ` Rémi Denis-Courmont
2025-05-25 21:37 ` Michael Niedermayer
2025-05-26 8:43 ` Rémi Denis-Courmont
2025-05-30 0:46 ` Michael Niedermayer
2025-05-30 6:58 ` Rémi Denis-Courmont
2025-05-31 13:39 ` Michael Niedermayer
2025-06-03 16:14 ` Niklas Haas
2025-06-04 11:13 ` Rémi Denis-Courmont
2025-05-21 7:46 ` Michael Niedermayer
2025-05-21 10:32 ` Jiawei
2025-05-21 11:09 ` Michael Niedermayer
2025-05-21 9:04 ` Zhao Zhili
2025-05-21 10:26 ` Jiawei
2025-05-21 10:33 ` Andreas Rheinhardt
2025-05-21 12:09 ` Martin Storsjö
2025-05-21 12:14 ` Andreas Rheinhardt [this message]
2025-05-21 12:22 ` Martin Storsjö
2025-05-21 18:12 ` softworkz .
2025-05-24 12:00 ` Rémi Denis-Courmont
2025-05-21 10:08 Jiawei
2025-05-21 10:14 Jiawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07440E86014D4DEA559BAAD28F9EA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git