From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [RFC PATCH 3/3] HACK: avformat: rawenc: allow to output a raw PRFT
Date: Thu, 21 Sep 2023 22:51:06 +0200
Message-ID: <AS8P250MB07440CA77C691A92139703A18FF8A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230921200953.GT8640@pb2>
Michael Niedermayer:
> On Thu, Sep 21, 2023 at 02:17:00PM +0200, Clément Péron wrote:
>> Output the producer reference time to a dirty raw output.
>>
>> Signed-off-by: Clément Péron <peron.clem@gmail.com>
>> ---
>> libavformat/rawenc.c | 122 +++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 122 insertions(+)
>
> this breaks fate-filter-volume and others
> (Segmentation fault)
>
> I can rerun it with debug symbols and provide peoper gdb output
> but i suspect given this has "HACK" in the title you are aware of this
>
The reason is that this patch presumes that every user of
ff_raw_write_packet() uses the newly added RawVideoContext as context,
but that is just not true.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-21 20:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 12:16 [FFmpeg-devel] [RFC PATCH 0/3] Propagate PRFT side data Clément Péron
2023-09-21 12:16 ` [FFmpeg-devel] [RFC PATCH 1/3] frame: decode: propagate PRFT side data packet to frame Clément Péron
2023-09-21 12:16 ` [FFmpeg-devel] [RFC PATCH 2/3] avcodec: rawenc: Forward PRFT frame data to packet Clément Péron
2023-09-21 12:17 ` [FFmpeg-devel] [RFC PATCH 3/3] HACK: avformat: rawenc: allow to output a raw PRFT Clément Péron
2023-09-21 20:09 ` Michael Niedermayer
2023-09-21 20:51 ` Andreas Rheinhardt [this message]
2023-09-22 7:44 ` Clément Péron
2023-09-22 7:59 ` Andreas Rheinhardt
2023-09-22 8:38 ` Clément Péron
2023-09-22 9:26 ` Paul B Mahol
2023-09-22 10:05 ` Clément Péron
2023-09-22 11:41 ` Paul B Mahol
2023-09-22 12:39 ` Clément Péron
2023-09-22 13:16 ` Paul B Mahol
2023-09-22 14:29 ` Clément Péron
2023-09-22 17:39 ` Paul B Mahol
2023-09-22 10:02 ` Andreas Rheinhardt
2023-09-22 10:10 ` Clément Péron
2023-09-22 11:34 ` Andreas Rheinhardt
2023-09-22 12:31 ` Clément Péron
2023-09-21 13:12 ` [FFmpeg-devel] [RFC PATCH 0/3] Propagate PRFT side data Kieran Kunhya
2023-09-21 15:41 ` Clément Péron
2023-09-24 9:12 ` Clément Péron
2023-10-24 15:10 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07440CA77C691A92139703A18FF8A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git