From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4575F48E4D for ; Mon, 29 Jan 2024 10:53:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8EE0468D1EF; Mon, 29 Jan 2024 12:53:50 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2095.outbound.protection.outlook.com [40.92.75.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6C4DC68D0C1 for ; Mon, 29 Jan 2024 12:53:44 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MDYhk69m8jHKmaKk1Ih69k8K4KVaCnO5qnWLZpnuAJOyLXvPr+7RtISqqu0Oeb0GEd09LUWIvB8rQ8Qpbudgb/OzTd2LqbgrsOWTV7IeG9b1lgYR9PEIxHlgRkYGheOfEnb2cmrFHmovX0AhETonZRc38ItwrXs2SIXuFd0gQGYjJWkJnmuHFmtnArO2Gx8R8roWeAP9gTLhWZqSvoX5T2GajNspppTdup/S1wh07lAdwwuZIdipO3HhqvYStyd6tiA084DzTiU3qrFABHC8J5vI+2liq2kmOM2M7i1Qu171O7VJVQCCyXk7O71OJ4mUaRP8+6wiEZDno0YDkTT1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fHjrjkGNmBIR0RdUcb6j8k6OVV5VnoBLXhQc8yRNfcI=; b=ewGT3KyiAWeUWZmPjvii0EpI6dly5lptg/blBSW6XJWtdbtDozHCs4iOJaBuk1sJ+wAyRgvsG25NOtyDAH4zoCcXYUxiMX8qzRYvXBJ3M4UUnFBTKiHxVGukh1bXUtM0WoMuuNb7rgOqtIZUerRUmY7qCE5rkO6GfgGzSr6kXzOQOpvW219x+f18nv5E9ysWwhphKHsape/X8QgZMSMBgKzYdrsX7ImKKXkgADDhnkgo6qSl/4GJFViDtRF32PVG9RvWw+itDOXn2myCvMmHuF/P7vwASI97i7bAGwq5wJxUVWMxWX7XljyAYrV3jFQbQZLhNM9nuhjG8bVKB8lKIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fHjrjkGNmBIR0RdUcb6j8k6OVV5VnoBLXhQc8yRNfcI=; b=UNghV30zXY35+uTxSTp7+xI2taIClt5oixkdyHUEhWIVZDDj4r0500wTjZJWQBCbzeyThgV/6cN2+/qXWIklQyhPX69PrxuXiUFpeIOpSwySMS1eCjhfEIOY3oXb3mJ68cAsIR9nTGSJZE4gxjucCFdRhqGqX1jqY7LTMGzdV3QKuUjZoqWFZt8DosaOYJyqH+grH5hR7UIlNiOCnJ55Z2yeNOKZnmhOtUiTQNb6zp40szHo0J41YZJhPMdtQKPX9FL8jBbjwotYaPi0NtoehdUokS4hvowr7sBlvnf2Qh/Dye3Y9IL0jWKOwPV97jl8Rr60QEPsKs2x9zuOpNsFTA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0072.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:374::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Mon, 29 Jan 2024 10:53:39 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7202.031; Mon, 29 Jan 2024 10:53:39 +0000 Message-ID: Date: Mon, 29 Jan 2024 11:55:19 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240128174950.20735-1-anton@khirnov.net> <170652369508.1197.9274216714495603536@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <170652369508.1197.9274216714495603536@lain.khirnov.net> X-TMN: [CCAh97hTMIQagOqW0/BDljKPqE8nD/w8RHy1ujEJzeQ=] X-ClientProxiedBy: ZR0P278CA0206.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:6a::23) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0072:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f7e2199-257d-49a4-501b-08dc20b88d22 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnoDeMQYelObf/NOc8dndilFs8WimQlRlJ86MknAIi7qFfiFjOyD7sGUIfLqOYZVBS4P4tA6rBzAhYEC2wlLgQVMwransU9Br220x5Bp5RH5NdA8cIB5IF8wYFtl7HI0/pbhmQH+PkBYN3LZJ2fbXtk8a0NoG7UzIG+KRJBpOeTWlzBATzMZ/K494pB6mvNWvGInDDqVSfI2hHh0LarflH/wRnv7BKX2qkwuOcR8FiM55m4bVtOi6Bx1CvWO/oqkYWJ2l3dIq4nPcAYCH7mEyf9Tcxwe7k1SlEJJ+KtcshmVxmTdLqWOUWLkGkEMwwlpx+DwBPD2N0n+7GXsRID8CwO/PbhwUm2qSKhaUdX0rAqgJaGGegLMTve5gY9mEuC0yOvhOl8ql2nuDMHPXvNYw3BuHmFgc68j9eMwbboNRxsUoa1vlAbITOGuiJVsMidPWQpRBk6aTxksv1g76HVJtfGnl8WedZGQMuEv6YfmF2Lt8rVsyU24EEBxc1vSlskTRFKIDUztxo/wcfMlFa3KgSqts2iuOy5yKxSfLCwRgD8O/EDtzSGDszFXobCh5YyhZNImOY4QkJjYlMjM9p2RpeBak4kyW/0wDPvoeVcFGqcM2+XkdVpQI4oOqSjn8JR/xvMlOaBy7P3xI6U7TtkZlXDug775SPV3K+84MB4AT/sRFt/EnxGSk1LkmBloHHlJQGJzzBtH1oLMOZyWuOMUY4pY3hJAqLqtsL/9LBXmNJcrHwA+flN65XgI0780GiU/rhs= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4S2jrYmQwMDQqGpb9HAmdIg7CxCYmBi8aJDJq5lg/Kdobc8a5Wd19qepJlbkuLJByglD6P7KrNSTYbez6k9XfKRRem+cwKrq5shKUaCYIekv2mN/CoHYmvJZAc1Z57XAt4tXiNJlXPjSaVSrxLV6Tuh6Kavl+l7JtAzKU5vZ0kWpkE+nCx2Dp+SK8mJ9kOqGLyVChIohv/WhD0vQTHR0SOiwbEo1pdzQyJ9Hkyk6uUujLw7+Kp6OI7lH0imzSgUx/kPvxr7hz3NC0ZY477G88armDul3y9e9lh6Gvp3eT4cZjqv3TlZG51TRLryPqjZbRzzoyHD+UDayOo6DoSOhZv4vo5wRPEpNab9M7QKeo+03LMNn0DiaRarfLDRRvRs4rskanmSusRtznWmhZsrPnySEoAlbW3Supb9O3GADusNldZVT2IKZpLBsU249tn9Ro3yfFp9lA1IGq3vzlS075OyJLG1iYNzgnA7bj2NWCkD415O2r0qCbBkmZoDD2RVJuwIxMwjHSverb26VyTjKjURc6an6ydZFfY02jVgwKUgjvTUPOqr5oaAeCaq9Y6Qe X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QldBWWRSS0FwdG9pSnlud3JGYTFrdW0ydTM2N0RjSW81aW1Dekk2WExLd252?= =?utf-8?B?Z1pLOWFpQ2xUQytNSWRvTXZJOHlqVjJlU1MxSVJKczF5OWNCdzdZczdSQlN1?= =?utf-8?B?c0xORml4YmJVak5pWndPbnpUcjdQYjNxRkdxTUVGc1lEbjdpbWhqdXVpb2VL?= =?utf-8?B?R3ZOSSt3amV4TkFKc0d2YlpxblZRWXBOWm5BazZDWFFDMHN2Vlh4b2dBdjk0?= =?utf-8?B?c2tKakVLU3hxM3BYd1lYa1lLbGdETGlUd3JEdU5HaDE5TTMxTGI5UFBtQis5?= =?utf-8?B?cHd3YXNqVzBIaUZUeWRxTHhnMDUvb1RhM3BJQXdzWUl2bm9la3JkMDZ0eUov?= =?utf-8?B?VmtVbEo2SUF5SCtNYUVWMFBMTUN0d0syUjRHNmpsUUlkaTZjMFdGZEhPWHUx?= =?utf-8?B?c085YUtsNURLeGw5YzNucElVQ1llS0lFNGRvYXJBWCttdlJLNXhMZFhmYWo2?= =?utf-8?B?U1l6blgwcDVMOXR0Y2hVejhOZ1dZb01pTVRqQ3dCNU90bjZoRHBsTjErNDJP?= =?utf-8?B?V0U4a0wxeXozbjFCQ1ZSdkFldEJyV2IrUGw5U2tnZkxLaFhaTG1Cc2NjQW1B?= =?utf-8?B?eUt5dzRURUF2OUdyK1J6bjhhVXpobXlndjV2RXh2V1B5ZEsvd3RURE5RTGpw?= =?utf-8?B?N2k3N2FEVnZ1WUIyRllvN09BRngrYlN3UmlKZkcwd3dEQWtDTnRmTkxJSkZL?= =?utf-8?B?eFBwNko0QUI0RHRFVXlrU2pyRDZmMVc5Z3lWamY5cks4MFhudlMwcklTbzZj?= =?utf-8?B?Um9BbmVpbGliWTF1YlJHcklUT3VBU1c0V3lxZHBJZlhmK3NERTJlNUN2OHNI?= =?utf-8?B?VnV4YTRNTmVkWTVFaDJ0cUp0bkhWZUxwYkR5S1A2ZExSV1ZoTXF5M3AvcUNL?= =?utf-8?B?ZUJ1STZwS0hSVERTbUtJYmhGN3hOR25SNFhudDVYNEkyZ25FY1k4QWpXZXpr?= =?utf-8?B?OCt6cTlJNVNGNFU3VnVQemZqUXVRYmY1Um5IZW9uODcyVkhOVlZaQmR6SkRQ?= =?utf-8?B?ZTlYZExWbzNWUVUwaXM5NTFnMkxvdUhVcUpwS0tub1YrV0xJSGFvQ0hBVjIz?= =?utf-8?B?aTUyVzJ6UUpLY3daYnc0U0djSFNDMWhtR2c0NVk4US9QZ1llNTFKZ2JMVXlI?= =?utf-8?B?VTc5WFhLdElaNkV6TGJWdCtzaVJGcXYwVnZrakorR2YxVmlseTlic2RLWmZN?= =?utf-8?B?M0lGczBQTWRDTW14THhGRjZ6bDYxN2VDNUR6U1BzUnNlMC9Ed1Z3RzIwRE8w?= =?utf-8?B?d250MGhJV1c5eWFJZFMrOUdMUzhueWE0OTdhNDduaWY5dVhWdEFCbG1hcUNl?= =?utf-8?B?YkVqQ1crUG1aRWttejQzV2EwV3l0VjdMalU0OWJoMWNtMUM1bk11N3FFRXl0?= =?utf-8?B?UVNPRk1VbFEzL2tDbDRyYW1uT1IrekdELy9TZlVJZ0hzdFY4TkdrRXVEUS9R?= =?utf-8?B?anM0VUJENU9sOEpTYWtXUlM5LzFxWUVhbi9SUThqRUJReFRFbTU4ZCt1cmtw?= =?utf-8?B?bURJdXdDdkZWWkxJcjdIazlvRkYvSk1QTFMxQzR5SDhOeTRTWUY4aUcyOVZF?= =?utf-8?B?dFFORDdqQXl6Q29PYkZScGdHaXJjOEJ6L1hIMTE2QldGaVF1ejM0OTJUOWZF?= =?utf-8?B?NmoxcWxvejZLQkdWTWo2ZmRGdUxQYi82WDdIWVh6Nm0zSUloSC9DK2s1Smo2?= =?utf-8?Q?6gX7JYFr4d4LiYS4Ulc/?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7e2199-257d-49a4-501b-08dc20b88d22 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 10:53:39.5568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0072 Subject: Re: [FFmpeg-devel] [PATCH] lavc: move bitstream filters into bsf/ subdir X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2024-01-29 10:57:19) >> Anton Khirnov: >>> +# add libavcodec/ to include path for bsfs >>> +$(addprefix libavcodec/, $(sort $(filter bsf/%,$(OBJS_BSF-yes)))): CPPFLAGS += -I$(SRC_PATH)/libavcodec/ >> >> 1. Why sort? > > To get rid of duplicates, otherwise the flags can be added multiple > times. > Why not just use libavcodec/bsf/%.o: CPPFLAGS += -I$(SRC_PATH)/libavcodec/ >> 2. Adding dependencies for stuff not in this folder is different from >> how we do it for arch-specific stuff. > > Yes, but as I said in the previous email - bitstream filters tend to > include more headers from libavcodec/ than code in arch/. > Both 2. and 3. were not meant about headers/include folders, but about the fact that you add dependencies to files in libavcodec/ in this very Makefile. > By my count, the 96 *.[ch] files in under libavcodec/x86 only include 98 > headers from libavcodec/, 1.02 per file on average. > By contrast the 43 *.c files under bsf/ include 187 files from > libavcodec/, which averages to 4.35 per file. > So IMO it makes sense to avoid the pointless noise and busywork from adding > libavcodec/ prefixes to all those includes. > > I would also be fine with adding -Ilibavcodec for arch files. > >> 3. And actually, it is worse: Imagine someone changed >> h265_profile_level.c in such a way that h265_profile_level.o now relies >> on stuff provided by a different translation unit. Then you need to add >> said dependency to all the components that require h265_profile_level.o. >> If such a dependency exists in another Makefile for a subfolder, it is >> likely that this will be forgotten. >> (Of course, seeing that a BSF requires h265_profile_level.o might make >> the developer think twice whether it is really a good idea to add this >> new code to it.) > > That's an argument against subfolders in general though, not against > modifying include flags. And it seems to me we have an overwhelming > consensus in favor of subfolders. > I was actually proposing that the dependencies for stuff in libavcodec/ stays in libavcodec/Makefile. - Andreas PS: Why don't you move e.g. bsf_internal.h as well as bsf.c itself? And where has this actually been discussed for there to be "overwhelming" consensus for it? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".