Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/9] checkasm/vc1dsp: Use declare_func_emms only when needed
Date: Mon, 10 Oct 2022 02:30:24 +0200
Message-ID: <AS8P250MB07440B70F02493302FDA8ED58F209@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737C14BE0518E155E6AC4D88F5E9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> There is no MMX code for vc1_inv_trans_8x8 or
> vc1_unescape_buffer, so use declare_func instead of
> declare_func_emms() to also test that we are not in MMX
> mode after return.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/checkasm/vc1dsp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/checkasm/vc1dsp.c b/tests/checkasm/vc1dsp.c
> index 52628d15e4..570785776f 100644
> --- a/tests/checkasm/vc1dsp.c
> +++ b/tests/checkasm/vc1dsp.c
> @@ -261,7 +261,7 @@ static void check_inv_trans_inplace(void)
>  
>      if (check_func(h.vc1_inv_trans_8x8, "vc1dsp.vc1_inv_trans_8x8")) {
>          matrix *coeffs;
> -        declare_func_emms(AV_CPU_FLAG_MMX, void, int16_t *);
> +        declare_func(void, int16_t *);
>          RANDOMIZE_BUFFER16(inv_trans_in, 10 * 8);
>          coeffs = generate_inverse_quantized_transform_coefficients(8, 8);
>          for (int j = 0; j < 8; ++j)
> @@ -404,7 +404,7 @@ static void check_unescape(void)
>  
>      if (check_func(h.vc1_unescape_buffer, "vc1dsp.vc1_unescape_buffer")) {
>          int len0, len1, escaped_offset, unescaped_offset, escaped_len;
> -        declare_func_emms(AV_CPU_FLAG_MMX, int, const uint8_t *, int, uint8_t *);
> +        declare_func(int, const uint8_t *, int, uint8_t *);
>  
>          /* Test data which consists of escapes sequences packed as tightly as possible */
>          for (int x = 0; x < UNESCAPE_BUF_SIZE; ++x)

Will apply this patchset tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2022-10-10  0:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08  1:23 Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 2/9] checkasm/blockdsp: Be strict about MMX Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 3/9] checkasm/audiodsp: " Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 4/9] checkasm/pixblockdsp: " Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 5/9] checkasm/llviddsp: " Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 6/9] checkasm/huffyuvdsp: Use declare_func_emms only when needed Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 7/9] checkasm/llviddspenc: " Andreas Rheinhardt
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 8/9] checkasm/vp8dsp: " Andreas Rheinhardt
2022-10-08  2:01   ` Ronald S. Bultje
2022-10-08  1:24 ` [FFmpeg-devel] [PATCH 9/9] checkasm/idctdsp: " Andreas Rheinhardt
2022-10-10  0:30 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB07440B70F02493302FDA8ED58F209@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git