From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function
Date: Sat, 2 Sep 2023 10:33:12 +0200
Message-ID: <AS8P250MB07440AA43B43FD091B0685E68FEBA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230901134336.1455166-1-stefasab@gmail.com>
Stefano Sabatini:
> +static void print_frame_side_data(WriterContext *w,
> + AVFrame *frame,
> + AVStream *stream)
I am pretty sure both frame and stream can be constified.
> +{
> + int i;
We support C99 variable declarations in for loops.
> +
> + writer_print_section_header(w, SECTION_ID_FRAME_SIDE_DATA_LIST);
> +
> + for (i = 0; i < frame->nb_side_data; i++) {
> + AVFrameSideData *sd = frame->side_data[i];
This can probably be const, too.
> + const char *name;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-02 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:43 Stefano Sabatini
2023-09-01 13:43 ` [FFmpeg-devel] [PATCH 2/3] ffprobe: correct section name for side data piece Stefano Sabatini
2023-09-01 13:43 ` [FFmpeg-devel] [PATCH 3/3] ffprobe: introduce section type, use for the compact output Stefano Sabatini
2023-09-05 23:15 ` Stefano Sabatini
2023-10-05 23:26 ` Stefano Sabatini
2023-09-02 8:33 ` Andreas Rheinhardt [this message]
2023-09-02 15:33 ` [FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07440AA43B43FD091B0685E68FEBA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git