From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CCC1C49A71 for ; Mon, 26 Feb 2024 23:26:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1AE4C68C9E5; Tue, 27 Feb 2024 01:26:38 +0200 (EET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01olkn2013.outbound.protection.outlook.com [40.92.64.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD9DC68BC86 for ; Tue, 27 Feb 2024 01:26:30 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fEKM1qp/mJOytxkp6UFTdR97NqshoxWhy3fDdGZMe53wY4OH68WHchLuj3ZoJNjl3Po5M7BcvG8wXgZzXsDdyhY/PMb4FvXXTmh/YIjcu39DjSrBDMnYPwpxFnAX2kVddC/+snLUgmtA9vj9CKgdvbjkhKUzBYR7TrbHPbekXFG2wPxW2KKbbQvg+BkXrAW21xqq8nvbMXMdRLSe2XKkgftwF9O02u/6h+ie3dneQI2gyd1hiPgqkkHMoKrpvySzUGXtK/opc5aYh9TLyj7xtkUHZ8eGa9FS6Umuj7QUarZ1MoKmO4TeccyHA6bXLLcZYCzKV3bOse0PhIBBxC8CrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bb0raodwR/Y49A0i3Qlm4vzLma/TuYPGUO2gUved0i0=; b=V8AdZTZN7Gb2wRPHZCdKjV7/xf/qtC4af6eJO3MZmQuQHzQh32AdZaBSlcV4ifP33yguVBTm0T53mfkp9TGGApbQhq5vaOqQ6COs2fix1Pgknq8+wFRXJ4ROEjZFg/03oalJSCuKdzr7RqGkK6Ul2W/L6Zebb73NzD3slTRJOiicJz6acbT+lZdEhbTsLnTuEYno9v9NF8hQmOfD9ZQd+1fd0LU0zQ10QvIQMXzH5kDCLaLot7f0WvoczD+Rd/FskTBgWT/ZZpl/0RgQs/psCOBlGM1TUPFL/o7eNqRDi7OUagwbcep45B0hfl1qURwOOdbxU3t7xHT8CWGyeMSbgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bb0raodwR/Y49A0i3Qlm4vzLma/TuYPGUO2gUved0i0=; b=HutIgezfvW2Kr4eR1uIDmeUJK0lP4hXlIdoi6MvsSGQkYQ9nycFdvLLHzwpeVk2MqJ038ICTP2oZ0sTgMWGwVYJgSZLMOwOqVG4CZ0i5CFRkDdHzxCvIG145BY7NSRnJpfZd7qiNtFT46Lwae/h/o0CMuRro+xYcirrv/HdaYdY0nRFA6OHfR5yBKlZXc9l+i+GiJ3phh6m6rgtAkIxzF1Qa5XnaBr05tLttEshW1z11M/itKNZDIH4tLXlPv2WJAlwqXjOdJy8fzmsylnuxYrXCt7EyTkTSWxU5zeLXi2i+PTbwAdHGNjUloj62yx2bpXDZLjQkbjktsDiS+LBNFQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0283.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Mon, 26 Feb 2024 23:11:44 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Mon, 26 Feb 2024 23:11:44 +0000 Message-ID: Date: Tue, 27 Feb 2024 00:13:43 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [TAyUq3CyluTDKHQSNBD7vQsZRIKg9gka8L2YUHreoso=] X-ClientProxiedBy: ZR2P278CA0035.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0283:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cf31fa8-eeca-48bd-8560-08dc37204ccd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cNI8Te9J5GZglUfaGLKiuAyXKNe2neBF4E98zPJcJ+ConjbspUoVctsEgoEMWoTeU62+zxIU6EPlInftD/LDr/t2QiK6IB4z0dOEpqpjGx/hiiDSL6hyqFNShFiCurJHwdKXd9BU9PydT9/9yHmfRepa9nYfk/fymT3ERjKXdBmv0VDHjn0bplIvLR5PXk+ZULiqQeSAH5BxCRl5WFCVUFxBCdrxyNGBNjXbfvtOFOibR5mLIzmiqzhUc4/psxePllSzBsDK44P7QB1wjCooGZKNAWVGUBWB74AIcKibWdewW/spNsssQjv7aEJAYBjRWR3HQ8+tlMWinLnf3ANnHUs6YdezstqLFzRCICZSAcQ7kzV3gkKr8Qq7ypyEWn+GYrIW3HhfCmxDNDwlQMW07sDJ8E/6ZwvuYlRHl7bdwZ9n/kJl/bfbuy88dAV/L5pNXPMKF/8+91EZoBpFkQo6mQYxUzkOmK9Xs+otHHcb+Yx1S4szBi4Ql3tBosEicLS6TlD9oCI/EQi+3k2Ohxrk3sILUT9HVPbK1J138NIzU8xKn1AIIrCmRTPcz72N38Sq X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zi9OVERtZW1LSDgrTzZoR093L1d4L041dVRuQWJnTytjbGU0RGdkZ2NDbUpM?= =?utf-8?B?SGk2N08xUGFPbVR6eU0wZlA3b2V4SS82VHlUSGxZQjkvc3VRckFocHZUczRJ?= =?utf-8?B?ZS9YSkg0VXZJbFRYanJvMHFHUVR0d1ZrbC9SOFNocnhHc20zRnZkVytmL3Vz?= =?utf-8?B?L1dkSkd2RG40blF0WmYvQjFWcFhKSGRqMGxPbHdtbElKQnh2V040bEVZbHZv?= =?utf-8?B?eFo4Y1VHUXBiTnYwRUZnWkhWSjNiZGl6eVZ5WVBhOEFvQzNZNWs5SkUzN1hn?= =?utf-8?B?R284N2hleWVSQXFTU1lkRlN6eWgvZG5oY0E5OEFpdkQyWW96OVArQ2UzOEU0?= =?utf-8?B?bDVkKzhoY205R1k2ODVsWEdiaTIrRkFZT1Rnd3A4SWZoMmhtcmw4czllcCtE?= =?utf-8?B?NE56cDZaVy9jbC9KSUI0WDBPNjUwaG5SNmNtTkUvTFdCemFhZ1dZUWVDamNq?= =?utf-8?B?b210Uzk4TEN2OE1ScEJSczdXUTNhRXhPR3RPR2o0YWNHVEh5TnlUWE16dUhi?= =?utf-8?B?Z1d6Z0tjQ1VOTDVIOHo2dXlGZkc0cnNvRElLOVoyMytoMFhLNjlzVjd6aVVI?= =?utf-8?B?M2xmWTNaYS9TTmpyVnE1VHYwU3dudlhqL2JaU3RYSHdleGU0VHBDcmVSUXYv?= =?utf-8?B?RHV2bG5QeFpRT0dKaXZ2ckk3UWcyaGo3Z3BlZHk5RVlwY1BDK3RHRXNHV0xk?= =?utf-8?B?R00vS3M1dkxXQlNLcDdTUE50cGsxd0NVZjJacmFzYnd5TFBVaGU1YzdQZkJx?= =?utf-8?B?aGdnRXBnWjYwMWthWlYyT2h6dzRIaDUvQ3VYQ28zZnZMQUx6L0w3Q2h0SlQ1?= =?utf-8?B?VEJDcEM5Q2duVWRNeUlhM2o0L2lEM2NGcC85R1krd0ZYemJ5a2VCZDEwOXk3?= =?utf-8?B?VlcwbEs5Y0F3YUZuby8rNWliMERySldzNE52aTJhOExQbkdJRFdTS3Z1TGJ2?= =?utf-8?B?Wnl3aXV6TkpWV0tCQ2R3djdEc2JBRlpxMWRNQWtoenMrOHo4U1QxZnQrL2JP?= =?utf-8?B?STVNbVNWUmpkeTFGTC9HVHRNbVJBTnJuaHoycEtxdUxBaFRKM1ozUUJTRUlM?= =?utf-8?B?aldrdlpkdnBPTmlZdHp2bDVPOW52Qk8vZlo0MXQvRElJWGdFRjUzRG9WSkRl?= =?utf-8?B?VVhHYnFIdnNOUUhqSUpCaTRXOExGWjZ5UDFmSGdhNHQ3Nm84U2htV3AzbHNz?= =?utf-8?B?T0FpQXl0R25xUTMzK1ZqanJRRG4xY0hpUEo1ZHBkUUt6STFnYzZTYUIraEpt?= =?utf-8?B?MDd5bEJKRXBDTXVBWWRzYVZ1dERLRWNXc2lNbnJnc1B2dzhqNVhLVC9BN0tB?= =?utf-8?B?ZmFqV00rWkhZb21EN0tsMGgrTEh4enVnK1JuVUJhZTkxZ0JkZ0d5THFCcEkw?= =?utf-8?B?Y3N4emZNb0VoUEVrMmliRVR0SzlvM2JGK1hZNjZCTU5hbVRmTTYvSjRmVFhM?= =?utf-8?B?NjkrK21qUUZSVUJHeGpBUU44UGJ6ZXZqdXBMc1BsdEZnOGF2elhrenJkSU8z?= =?utf-8?B?RW04RFI0TTJZUmNlTmk5b2tJMkpod2FNYlovalFqNEdwNkdkWEpwSzFrRDlR?= =?utf-8?B?QjZWT01VYVdudWJxT2JvNHg0bncwVGR2WEowNk5lZ1VOMmM3YmsyZ2VJK0RD?= =?utf-8?B?N3c2RWZZZW5WcVNlNDYzQVdMZmdYTVVzY1BjMk1NNnJEdzYyczNSQ0xRUFo5?= =?utf-8?B?TkhKanhCRmJyVnQrL3puQkl4Y3d0Zk92bjBUMG1rRmJNbWczem9qU3RnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cf31fa8-eeca-48bd-8560-08dc37204ccd X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 23:11:44.8421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0283 Subject: Re: [FFmpeg-devel] [PATCH 6/8] avcodec/aacsbr_template: Avoid using AACDecContext; pass logctx directly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > Feb 26, 2024, 02:25 by andreas.rheinhardt@outlook.com: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/aacsbr_template.c | 131 ++++++++++++++++++----------------- >> 1 file changed, 66 insertions(+), 65 deletions(-) >> >> diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.c >> index ce3834e2dc..72bec96d2c 100644 >> --- a/libavcodec/aacsbr_template.c >> +++ b/libavcodec/aacsbr_template.c >> @@ -237,15 +237,15 @@ static int array_min_int16(const int16_t *array, int nel) >> return min; >> } >> > > Patchset LGTM, except this commit. Would you mind leaving > AACDecContext usage here? SBR is still technically part of the decoder, > and it has been useful for 2 of my unmerged patches to have > access to the header. Ok, applied the set without this patch. Thanks for the review. > I think SBR went too hard on abstracting itself, maybe for a hypothetical > sbr mp3 reuse. +1 - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".