From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D523047B1C for ; Mon, 2 Oct 2023 11:06:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C1A068CD83; Mon, 2 Oct 2023 14:06:10 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2082.outbound.protection.outlook.com [40.92.90.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B135A68CDC1 for ; Mon, 2 Oct 2023 14:06:03 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qff/nwlHd+tWiagVOXs9XiEQzNM0LzQoM7zKKYCDjTo8vV8IoimSaiOryEnVxUL/VJ1OtB8pqkboEkaHlHOeQq7ZwvyGkwAIFcL043CGugCNDsPRcG3T8Lzw8rsgIUs3cmP/JFToinpRJYy2+PjYJH1GHXvdrLtIdHdwNHZCM7iSQRoZ/QXh/EFtSoyQuJreWFULUmyOLJkS1wAYyVRuL8UMsQ3pGnzwN+r9H+PldR9XY8jM0g6X+BCWxJP65ncPiU2jwK0hF6NHONCZylD1s7KxzXusxzYyHaSS0xF3Lon/2K45v+Ec7slr9j48yO9MJXFBc31H60pkqrrzvi2SGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hmnUWWxZpJ6ZTc//PS9YCmMGXPrdBZhVVuVOff8sl5o=; b=jsvJAWNXaxRkho1s946dV3uk8nrbo8DrADlljv1dE2UBo+Or/mzNjv6PFRyylEOKbNIxQy/d7SsdrmpzsAVbcHgKhYxSiIF2NO5IhGJG7H1WwYrA0eHrGEu7fLMRaRT5dr86SQadQAw6Rx9gB46+LtOYCkAnrSiV6Pir1JBsRmoqRK9qLj7DSfeIumxJOXx1aS9bjZPlFTRjO5xyZxohflh3qyERfb+ltqdQKnH3vlhwqfRIdGlBiW3zW6B7oYhfRH6vqlWC3XaVfG0NyxrK1v8VNlYL4BtXI1+NZ9EM/rONhFPivwOEl/VfjGdeDUlUReIID0XaoZUYMOAQw0etww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmnUWWxZpJ6ZTc//PS9YCmMGXPrdBZhVVuVOff8sl5o=; b=VdBLBaaDTLetdRqOwAq80L4k9albfnWMN6uTiK4E7uBwuAaqIj93+f7IyDZPtwBeMwNR7wD4/wZTT6kB5Bvu9VGlGc/3Miiwz9zvpcMSMmGZqbwYo4pEFb6FJVYAg5Vc0IEnOjSUREb67j67XSLlL/P2gXx0cVPNXzJa/gB4PXl4hFiLLCzAmcEsGY3Hss/XizZQFEwX3ymkXSyAU10WW4El8GbCMOMbrnxG/++xkv193+Tyt5LCYjTEp9/9Yc4+lkyCQTuTJlzGVzmoDxhj3K9xzFpe/gBk6MiitBwwIX8lRXLb9Z/aFvg/wic1OG5O8Opsx5cJvlB3cxYg+sbmqA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0274.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29; Mon, 2 Oct 2023 11:06:00 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Mon, 2 Oct 2023 11:06:00 +0000 Message-ID: Date: Mon, 2 Oct 2023 13:07:14 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: FFmpeg development discussions and patches References: <169624366647.6638.939649870927700518@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <169624366647.6638.939649870927700518@lain.khirnov.net> X-TMN: [7vhuFBOTz+gjADgo7esntHhadgSRHm2l] X-ClientProxiedBy: ZR2P278CA0066.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0274:EE_ X-MS-Office365-Filtering-Correlation-Id: 8755bcf0-2411-497c-60c6-08dbc3378f4b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BXQzMe21I+QW7F+RBVeXktaKOBFYWPxOO7y0RwU3i+EdvOw3ohcrduQGqUN+uZXsmIcMvUM6AL+zV2V0jcaWNvz6YySDpsT2XB8/7mgy5ypjYQqVM0EmZOzFhnZr+TPR5MY3jOCZ7gWpqkfrzp3zWOrk2n3j0BrYq6jlmvAJ7RpBbRsHi3X6p3eR1ccfHE1AhYz9w8/8D00kGuRTYiZnCJ73I1eNdy/9f1JV8xCXEOyN2FnooLH/Svq8UlMpeP4htEMFbOZN1bagOcd04WqFBzKjSRanbY+Xh0U0vWXdyTWqz0Y46k9/Vr+M4Y7ln8uAvvbZ0n+LPc/G4tmXvQrQQj1xjhMZ7GXBwUfcqbOh7FPw9sniOPoJXuM26l3atcHSQYxeC/ttEBWO6+3tT0GeuCYoR62IWpynXGRvr703bDz9C6cp2mDn7StJtRdSZff+YaW5DAnCpSAgRhkxLwJgOWuZfLqGZyZNwYtfg96BDLoovrrwcF9uCIq1REq3280sh2IvxQz0QZe2imV+IS1Bf9712hH41SSwu7Fv31Z0dcoJHzu9v2OnSpjb3Xa+23Si X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2ZWWG9Sa0dMQ3pvekJSZ295cXJabjgyUTBicy9IYzY4RFdaNS90QVROSlRx?= =?utf-8?B?UlBNUTMvclh5VXk4Rm9RQURiVWVyWHRCbEdVamRtVkdaTDYvRmpLKzZ3amx1?= =?utf-8?B?VWo0aHRadFNCaWtEZi8zeGRuL09hVXByZDRwRzIzNmxIb0lnR3RXTUJGZ1Zw?= =?utf-8?B?MXVSYk1WbUJrRDdZcXFCWGxjK08rMy90T2o2WjRwWklTWm5LeEdTS2RvNHpM?= =?utf-8?B?TmRiZHNtZHRyWUVPTVBDTTlvNGJEUFgvVWFoeEx2RGxQNWNEdGpBdFdhb1Ft?= =?utf-8?B?RWFBdXBhRG1BVkhMVW0yeXlIZ2RCcmgrMkhtQTdDWFppZGdCRi93bk54NFZu?= =?utf-8?B?UXNyTkhXSmhkRURSTW5wREI3TUJRbE1XQWthak9UMXZIOFN0MlZkUkJPSFNU?= =?utf-8?B?eFo4SGpuUEttN2FUbkVSb016dlhhczJjdG5UVGNXbkJNc1VXaURDTzZTWUZH?= =?utf-8?B?ZnNjSGRxWEU2WlJKeHZXazFFaTIxN1h6aUx2b1lSQm1HdnVIN3BVZDFHYnNC?= =?utf-8?B?ZVZxa29keVZBYWkwYkRBbWdvZlBIM2xJVmhvTFFuL0ZOYlZtb2owbUxIcnpP?= =?utf-8?B?clZXblVJZ1htakxsY0tma3ovZy8yUEpuZ0RZUi9nYlNBb01Pa3h6WTBMcXdy?= =?utf-8?B?ZzVzdzZoNERCRTQzckxRVndVU3ViMy80cVhiUExwZkx3THJqUkoyc1hnL2Fq?= =?utf-8?B?bVRSRllWU0ZqekZ5Y3prTUp3RUpqZVNHSUsrd2xoYzJvMUcrd2h3Q2I0TTdl?= =?utf-8?B?bXhvTzM2YlpwYXdtcFd2NE13bXh0WTdwQnZ6SG9xMzdHdGNzdW4zOFJXcEZP?= =?utf-8?B?WGxId1dJS0o4dVJMT1lhdXEwSWFuZHZESGhPMmpGRVNja2Jac3BPMzlnTmw5?= =?utf-8?B?QS9SYTJCZUpoaWNkejdWV09XZFdJRjh0SnZ0WEFqWHFITDZkd2xWVVlsSzZx?= =?utf-8?B?aGZHdFV0cWJpcUpvVVZ5QU9kaFJ6a2pDMVdkM092Z0VMMDg0dFVkK1JkbllV?= =?utf-8?B?eGtuSEppQVR6Qmpvd1pnaHhDam5oT1FFT2hzaXN4NDNJVVk2UjVUcUEreDk0?= =?utf-8?B?OVFhS0hvU01MS3FEMHNiM3JpSkM0OEROL3VrSHNEeFllaWNybkU4SHMrNVYw?= =?utf-8?B?WEs2SkJIb1hKNFZVTFpSVlIwcVhvSHhZQ3VRdmErNStRZWNrL1dlUE82VnZM?= =?utf-8?B?QnNrY2NBZW5Id0thMmx1Vlp6UHZwYVJicXZ5M1BlTCtNMys1eFdUd1I1cXdW?= =?utf-8?B?Lzdwa3VPZ3UzV0FreEpyOEk3V2NJOWZMSExpTGt3L3BNNk1DdXArc2VKTHB5?= =?utf-8?B?QzVaNC8rNS9wRzhDdTNhWCtFR1lWOW04WnFOS3dLcWRRRDRSM0pzZU55Smdy?= =?utf-8?B?aXhBWDRCTEpDYkp1TlozOFJEN0hkWEFrL1pIZzljOUxpcWJsMzVBZFN2SUh1?= =?utf-8?B?bnh1VDl6UXd2MktCZGhYSzdBSldzMFEzVGhPSkZMVmlVMVJyYk4yQXlUWk1q?= =?utf-8?B?eW5VZ2Ntb0swSjVKbUZMMnFFOE0xZ01qNS8rS0VVTVdYazQrZFd0UFpKWnF0?= =?utf-8?B?TE5LNENvbVVRVk1MRHljQ25IS0VZd2Nsb1dSS1hkV09KLzlCYnoyMm1UbUEy?= =?utf-8?B?Y3c1RGUvVEhwOUI5bkN5WEVGN2FObDBQRzM4QVVUcmVhL2RFTGZEcFNsdlc3?= =?utf-8?Q?Za5H5GjL/bzGLHEqdd/M?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8755bcf0-2411-497c-60c6-08dbc3378f4b X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 11:06:00.0187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0274 Subject: Re: [FFmpeg-devel] [PATCH 14/42] avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2023-09-19 21:57:06) >> avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer > ^ > b > >> Given that the RefStruct API relies on the user to know >> the size of the objects and does not provide a way to get it, > > Is there a reason you decided not to provide it, or there just wasn't > any code that would be improved by it? > In this example, there would be no improvement if RefStruct recorded the size (in bytes) and provided a getter for it. In general, the philosophy of the RefStruct API is that the user and not the API knows what is in the user data. So the user has to keep track of stuff like this in cases where the user doesn't know it. The only scenario where keeping track of the size would be advantageous would be for using arrays-of-whatever if the callbacks provided the size as a parameter (to be ignored by most users), because one could then derive the number of elements from it. I pondered this, but given that the AVBuffer API doesn't do so either, I didn't do it. Shall I change this? >> we need to store the number of elements allocated ourselves; >> but this is actually better than deriving it from the size >> in bytes. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/hevc_refs.c | 14 ++++++++------ >> libavcodec/hevcdec.c | 5 ++--- >> libavcodec/hevcdec.h | 3 ++- >> 3 files changed, 12 insertions(+), 10 deletions(-) > > The actual code looks good. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".